Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <21044180-faeb-a590-f195-dc2dc5257e05@kernel.org>
Date:   Mon, 21 Mar 2022 09:59:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
From:   Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v4 1/2] dt-binding: mmc: Add mmc yaml file for Sunplus
 SP7021
Content-Language: en-US
To:     =?UTF-8?B?VG9ueSBIdWFuZyDpu4Pmh7fljpo=?= <tony.huang@sunplus.com>,
        Tony Huang <tonyhuang.sunplus@gmail.com>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "lhjeff911@gmail.com" <lhjeff911@gmail.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>
Cc:     =?UTF-8?B?V2VsbHMgTHUg5ZGC6Iqz6aiw?= <wells.lu@sunplus.com>
References: <cover.1647652688.git.tonyhuang.sunplus@gmail.com>
 <27dba330ec0c1cd7edbcec53083f78169713a42e.1647652688.git.tonyhuang.sunplus@gmail.com>
 <c78aa9fa-8001-2c48-7a25-1f44f9952c9b@kernel.org>
 <cab5bdafed86451a99cd59da3b1c5a38@sphcmbx02.sunplus.com.tw>
In-Reply-To: <cab5bdafed86451a99cd59da3b1c5a38@sphcmbx02.sunplus.com.tw>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 21/03/2022 03:35, Tony Huang 黃懷厚 wrote:
> Dear Krzysztof:
> 
>>> +++ b/Documentation/devicetree/bindings/mmc/sunplus,mmc.yaml
>>> @@ -0,0 +1,79 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) # Copyright
>>> +(C) Sunplus Ltd. Co. 2021 %YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/mmc/sunplus,mmc.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: sunplus MMC controller
>>
>> s/sunplus/Sunplus/
>>
> 
> Below is my modification:
> title: Sunplus MMC Controller
> 
>>> +
>>> +allOf:
>>> +  - $ref: "mmc-controller.yaml"
>>
>> allOf below maintainers,
>>
> 
> I will modify it.
> 
>>> +
>>> +maintainers:
>>> +  - Tony Huang <tonyhuang.sunplus@gmail.com>
>>> +  - Li-hao Kuo <lhjeff911@gmail.com>
>>> +
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - sunplus,mmc-v1
>>> +      - sunplus,mmc-v2
>>
>> How did this happen? Versions of blocks are usually discouraged, unless you
>> have clear specification,. The previous discussion did not end with "add v1 and
>> v2".
>>
>> Do you have clear documentation/specification of these blocks? If no, please
>> use SoC compatibles.
>>
> 
> v1: support SDIO 2.0							
> v2: support eMMC 4.41		

That's spec is not enough. You need to provide detailed specification of
each of them. See for example versioned blocks of Synopsys DeisgnWare
(e.g. eMMC/SDHCI).

					
> The register base address and offset address of emmc and sd card are different.							
> eMMC and sdcard are individual hardware settings							
> We need version to distinguish different speeds	

That's not the answer. How did it happen that you have now versions and
before there were SoC compatibles? No one pointed to this and you did
not mention it in description of changes.

Best regards,
Krzysztof