Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 21 Mar 2022 13:46:40 +0100
From:   "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To:     "Rantala, Tommi T. (Nokia - FI/Espoo)" <tommi.t.rantala@nokia.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "sashal@kernel.org" <sashal@kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "memxor@gmail.com" <memxor@gmail.com>,
        "ast@kernel.org" <ast@kernel.org>
Subject: Re: [PATCH 5.4 21/43] selftests/bpf: Add test for bpf_timer
 overwriting crash
Message-ID: <YjhzsKYWXw0/Zy0z@kroah.com>
References: <20220314112734.415677317@linuxfoundation.org>
 <20220314112735.013019647@linuxfoundation.org>
 <a0a7298ca5c64b3d0ecfcc8821c2de79186fa9f7.camel@nokia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a0a7298ca5c64b3d0ecfcc8821c2de79186fa9f7.camel@nokia.com>
Precedence: bulk

On Fri, Mar 18, 2022 at 07:27:07AM +0000, Rantala, Tommi T. (Nokia - FI/Espoo) wrote:
> On Mon, 2022-03-14 at 12:53 +0100, Greg Kroah-Hartman wrote:
> > From: Kumar Kartikeya Dwivedi <memxor@gmail.com>
> > 
> > [ Upstream commit a7e75016a0753c24d6c995bc02501ae35368e333 ]
> > 
> > Add a test that validates that timer value is not overwritten when doing
> > a copy_map_value call in the kernel. Without the prior fix, this test
> > triggers a crash.
> > 
> > Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
> > Signed-off-by: Alexei Starovoitov <ast@kernel.org>
> > Link: https://lore.kernel.org/bpf/20220209070324.1093182-3-memxor@gmail.com
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> Hi, this patch in 5.4.185 breaks bpf selftests build for me:
> 
>   progs/timer_crash.c:3:10: fatal error: 'vmlinux.h' file not found
>   #include <vmlinux.h>
>            ^~~~~~~~~~~
> 
> Based on quick look, vmlinux.h generation was added to selftests in v5.7,
> so drop this patch in v5.4?

Now reverted, thanks!

greg k-h