Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <82bcda66-cf26-c9f5-fe2e-e41f739ec1ff@nvidia.com>
Date:   Sun, 20 Mar 2022 15:50:55 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] rapidio: remove unnecessary use of list iterator
Content-Language: en-US
To:     Jakob Koschel <jakobkoschel@gmail.com>,
        Matt Porter <mporter@kernel.crashing.org>
Cc:     linux-kernel@vger.kernel.org,
        Alexandre Bounine <alex.bou9@gmail.com>,
        Kees Cook <keescook@chromium.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mike Rapoport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>
References: <20220319203344.2547702-1-jakobkoschel@gmail.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20220319203344.2547702-1-jakobkoschel@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWhXN0d6QjV4WGVxMlNOVHphUEoxS2pucXpRcjRydVJyT1UxY1JVNk5sdDAz?=
 =?utf-8?B?cDVsbTRPQWZrc2ZGeDRyRHVuNzk0aGViblQzZlNoWWlNZ3FzVTdacnY5dy9v?=
 =?utf-8?B?QURENkRBNEpBSHNpdGhTaThNdzBSSldtVk14TXgyVHRudTVPU1J5ZXkrNTlK?=
 =?utf-8?B?ZVBJRm1OUE1IVTRUK1BJUzh3NUNBbFdoSUVDSTUxdmdqWW1oSDZMZ1VsdVJW?=
 =?utf-8?B?bkJaKytoc1Z1bzMzaUhuYnVUNTltQ2dqQmFjSldmNTM0WUVrb3BDSFBJeWMz?=
 =?utf-8?B?QjlGeUZNV2Ruc0wyL1F0elVNcGttbk5VWXpPRGJlam9FL0JzWnNJUGF4dm1v?=
 =?utf-8?B?d1hWUGYrZGoxajZzeDBkWTZoZ1h2SkRtekFnR1EzVm9odDRYS0FyRVgreTN2?=
 =?utf-8?B?L3l0b1N0dVUzWEthK0xQSmlJYkk2WjIrank0QlhGeEhwWWxJT2RVRmxZZ0hi?=
 =?utf-8?B?Yi80bHE0Sy9sdVhQSHJDWHJUNGdzZ243L0ZxcXBtakMxUGJEZ25ETWR6bkJm?=
 =?utf-8?B?dzVpUXNHL1FaU2hxamVHbTFLM3pFV3dFaWpwUm4xUHpnUjk4cnBuMnVSb0RD?=
 =?utf-8?B?ZzhqVGhBT0kvSC9WNmt1UEMybjBpRlM3UlJNQTFINWQrYTVPY3pCQTl5cWY5?=
 =?utf-8?B?VXBoSm5aM2l4NzNjK09UbmhXOWdWNTlsZ2NoV3pnbUd3RlZtdElMazhZdzlG?=
 =?utf-8?B?bFVZbDJWMEtlM1cvYzV5NFFyV015RXlob0t1Tk1kNCtpYzRxM0FHWGU3eGxY?=
 =?utf-8?B?WFFRd1B6cXRncVlKM0V4eis4U2hRUEliTUZ3OFBtS3ZtMWpwOEZmbm5xZHdW?=
 =?utf-8?B?YklaNXp2TEptczBDNVEwVEZUc1ZDbkJQL3U3YlJ0WXdlazczQkMwc3Bwekt2?=
 =?utf-8?B?NlA2NjhXSldrRzZHMnNYUXpEVUNBR3M2MXJ6MUEvSDhNa3REMVQ4dzBYa3JC?=
 =?utf-8?B?b2VuZWg3YnJ2UU5yT0M5eitzUnBVSHdvaGhnRVZtbXJDUElaazZqVzZIS3Iw?=
 =?utf-8?B?UDFxaTZYa3ZlUVp0bzg0d0RMcGxDQWJINjBENHpRZXMrTlJ4ekI5eXlnc0Rl?=
 =?utf-8?B?RFpsLzV6OUErQ1VPK2o4OVltckxNanp6TWcwai84ZXlwS2I3cm1yS0lZRnM1?=
 =?utf-8?B?NGRKKzl3Q0hRNUlJaDJtNkNobm9VU1hwa2NuRzYxbzExRzczN2FjTzcxYmIy?=
 =?utf-8?B?QVpyczlUa0t3ZXFwbkpEbHFoUnhicU0wVzVTRUNQcTlCL2x3MzhmdVBSaUp1?=
 =?utf-8?B?K1drL2dVMHNac3VkbDlIQ01lc0ZlUmVTR0NRdWJCTGxTL09CeGgzck1DTXQ1?=
 =?utf-8?B?K21aTTBSaUVoRDhxSkFVOThBQ2VqRVltQlJzeCs0aW5NVXZobmlOMHN6NVFt?=
 =?utf-8?B?Y2grNkxWdVdhbFNsMlRXdE5aRVcyRStnbDJDZkFmdmhtV1FwbkNRQWQvMldo?=
 =?utf-8?B?dENoaVdnTzJSNlk1RnJHdTBZU3pIYVQyOS9UODlQYjI3YnhjNjBSdGMrSTNE?=
 =?utf-8?B?SUZHM1NoUlk2cUhGQkRIY3g5eFBLdVRTaldlVFFoNnhtQmJBNTlLT2Z0VWQ4?=
 =?utf-8?B?UmZqNTRqdGhzSFNVTlFtQkRtdFJFeXpUZVBLK05ZTkRzOTdMK2FrTnkrdGQ2?=
 =?utf-8?B?MForU1VXVUs0eWNxaVo4c3dOb3JSMnp6VGRqZlplWnltSitxbE5YK2ZIT3Ay?=
 =?utf-8?B?VXJuSi9GRnkxTXBMOTRHNXlROXVmN2F6Qzg1OUdQcm1QWU1JSWo0WGd5aFNy?=
 =?utf-8?B?TCtiT0NjN1p4UlM0cmNaUWVmc2RJcWhkeVg4TmliSzAzR2pGbVVFVGdLWXRn?=
 =?utf-8?B?WURUVkExT04xcmhlaXg4ZzZqTksyZmZWQmFHV0hTS2wxc0kwYnltd3dmWGlZ?=
 =?utf-8?B?MmVIUGExVHpjcXh3T29OZnloZDZoTFhHN1BzQnFlNUlpT3JoUktkN3p2WnFa?=
 =?utf-8?B?UHl6YnhTUWNmZThuT3kwZUNGNEJyMlNRaDZ6bXhBNXAzUkIzMU5zd2lCSDNz?=
 =?utf-8?B?cVdkWG1oODFBPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d022bf82-c6e8-4c53-e6b5-08da0ac41930
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2022 22:50:58.4473
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lA69hn5peMBThSOCMwmMddyxQ5DaXMuvNVTZgUI+qm/50pTYCIQlxhmbEWy+cAKgMwZEvvB+g9Pdo8bXJZjRMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5409
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/19/22 13:33, Jakob Koschel wrote:
> req->map is set in the valid case and always equals 'map' if the break
> was hit. It therefore is unnecessary to use the list iterator variable
> and the use of 'map' can be replaced with req->map.
> 
> This is done in preparation to limit the scope of a list iterator to
> the list traversal loop [1].
> 
> Link: https://lore.kernel.org/all/YhdfEIwI4EdtHdym@kroah.com/
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
> ---
>   drivers/rapidio/devices/rio_mport_cdev.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
> index 7df466e22282..2cdc054e53a5 100644
> --- a/drivers/rapidio/devices/rio_mport_cdev.c
> +++ b/drivers/rapidio/devices/rio_mport_cdev.c
> @@ -915,7 +915,7 @@ rio_dma_transfer(struct file *filp, u32 transfer_mode,
>   			goto err_req;
>   		}
> 
> -		if (xfer->length + xfer->offset > map->size) {
> +		if (xfer->length + xfer->offset > req->map->size) {
>   			ret = -EINVAL;
>   			goto err_req;
>   		}
> @@ -927,7 +927,7 @@ rio_dma_transfer(struct file *filp, u32 transfer_mode,
>   		}
> 
>   		sg_set_buf(req->sgt.sgl,
> -			   map->virt_addr + (baddr - map->phys_addr) +
> +			   req->map->virt_addr + (baddr - req->map->phys_addr) +
>   				xfer->offset, xfer->length);
>   	}

I'm not a RapidIO expert, but this change is small and clearly correct,
so:

Reviewed-by: John Hubbard <jhubbard@nvidia.com>


thanks,
-- 
John Hubbard
NVIDIA
> 
> 
> base-commit: 34e047aa16c0123bbae8e2f6df33e5ecc1f56601
> --
> 2.25.1
>