Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Xiaomeng Tong <xiam0nd.tong@gmail.com>
To:     jakobkoschel@gmail.com
Cc:     alim.akhtar@samsung.com, avri.altman@wdc.com, beanhuo@micron.com,
        bvanassche@acm.org, daejun7.park@samsung.com, jejb@linux.ibm.com,
        keosung.park@samsung.com, linux-kernel@vger.kernel.org,
        linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
        xiam0nd.tong@gmail.com
Subject: Re: [PATCH] ufs: remove an unneed NULL check on list iterator
Date:   Sun, 20 Mar 2022 12:57:34 +0800
Message-Id: <20220320045734.14087-1-xiam0nd.tong@gmail.com>
In-Reply-To: <6EEE0ACC-6F7F-4D29-AA2B-751E4677B35E@gmail.com>
References: <6EEE0ACC-6F7F-4D29-AA2B-751E4677B35E@gmail.com>
Precedence: bulk

On Sun, 20 Mar 2022 01:57:39 +0100, Jakob Koschel <jakobkoschel@gmail.com> wrote:
> Maybe it make more sense to move that check after the loop body instead
> of removing it completely? This code obviously does nothing in it's current
> state but it's clear what the original intention was, so restoring that would
> perhaps be better.
> 
> But probably someone with more experience about this code can make the call
> 

This seems like a better choice, if it doesn't go against the author's original
intention. I will fix it in PATCH v2, thanks.

--
Xiaomeng Tong