Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Sun, 20 Mar 2022 23:31:19 +0200
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Nayna <nayna@linux.vnet.ibm.com>
Cc:     Nageswara Sastry <rnsastry@linux.ibm.com>,
        Nayna Jain <nayna@linux.ibm.com>,
        linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
        dhowells@redhat.com, zohar@linux.ibm.com,
        linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org, dimitri.ledkov@canonical.com,
        seth@forshee.me, Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [PATCH v11 0/4] integrity: support including firmware
 ".platform" keys at build time
Message-ID: <YjedJxNNv8KifAKd@kernel.org>
References: <20220310214450.676505-1-nayna@linux.ibm.com>
 <4afae87c-2986-6b0e-07be-954dd4937afd@linux.ibm.com>
 <f78d11fefd13bd17748e36621acee9c2f27a77f6.camel@kernel.org>
 <f92ec4d8-47c0-ece5-3c52-caeb8265881c@linux.vnet.ibm.com>
 <YjLlYTs+2ep80zoK@iki.fi>
 <57d7034a-fb5c-444e-a709-4f993459688e@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <57d7034a-fb5c-444e-a709-4f993459688e@linux.vnet.ibm.com>
Precedence: bulk

On Fri, Mar 18, 2022 at 05:25:07PM -0400, Nayna wrote:
> 
> On 3/17/22 03:38, Jarkko Sakkinen wrote:
> > On Fri, Mar 11, 2022 at 04:03:12PM -0500, Nayna wrote:
> > > On 3/11/22 11:42, Jarkko Sakkinen wrote:
> > > > ".platform" keyring.
> > > > > > Changelog:
> > > > > > v11:
> > > > > > * Added a new patch to conditionally build extract-cert if
> > > > > > PLATFORM_KEYRING is enabled.
> > > > > > 
> > > > > Tested the following four patches with and with out setting
> > > > > CONFIG_INTEGRITY_PLATFORM_KEYS
> > > > > 
> > > > > Tested-by: Nageswara R Sastry <rnsastry@linux.ibm.com>
> > > > OK, I added it:
> > > > 
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git
> > > Thanks Jarkko. Masahiro Yamada would prefer to revert the original commit
> > > 340a02535ee785c64c62a9c45706597a0139e972 i.e. move extract-cert back to the
> > > scripts/ directory.
> > > 
> > > I am just posting v12 which includes Masahiro feedback. Nageswara has
> > > already tested v12 version as well.
> > > 
> > > I am fine either way 1.) Adding v11 and then separately handling of
> > > reverting of the commit or 2.) Adding v12 version which includes the revert.
> > > I leave the decision on you as to which one to upstream.
> > > 
> > > Thanks & Regards,
> > > 
> > >  ??? - Nayna
> > > 
> > I already sent PR for v5.18. Too many late changes to include this, which
> > means that v12 is the way to go.
> 
> Assuming v12 looks good, could you please queue it now ?
> 
> Thanks & Regards,
> 
> ??? - Nayna
> 

Unfortunately, I've already sent my v5.18 PR over a week ago. I can put it
to my queue but I think it is lacking some of the tested by tags, doesn't
it?

BR, Jarkko