Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2267381pxp; Mon, 21 Mar 2022 15:24:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzY5ixVDGIM8djnh6FCo4xYPglM2PfjL5vMW7wWuAMfRsxSX5q/rBl5vQV254Qp4GiD6Wid X-Received: by 2002:a05:6a00:130e:b0:4cc:3c7d:4dec with SMTP id j14-20020a056a00130e00b004cc3c7d4decmr26316913pfu.32.1647901441985; Mon, 21 Mar 2022 15:24:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647901441; cv=none; d=google.com; s=arc-20160816; b=t39spiXP2ZWXlDyu7J3Ks3LkU7k8h+sD84c1Fi+nvF8TBkdRMldlbmYWlSrYF++mwr 2/OMJASFZYfhXkpPA+OzIxns4c3MBYYek/BhfjLgZ6ZEKtPLwMUB65f+BB1Em4mgSh2K fEmL5dLqm/fvIbQ7MPcpmoYFKQbIzylU6DS6ZafaS5sPDRK2AFxKzaGrB5E1XR4OE+gL dsjyZZcq8VpJbIVaoH5J9q/9T3nvh/hGF/HblGhQ2ylL0WLvGl1v47U/swlGcL0dscCy L4HoCx1kzLhafoJsRtYLTgsztusvB71Y2wVsbg943KoaK2H7Y4IKqgh/lC8B5hASQohy g9wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Ytyp9zXagZWtFeq5TLgzmPPD+BIQXFpQvKpDVD18b0I=; b=Zbc+WuOYwgVGB7lyujbFqlyyHVOd6BOCq/R5Gj9BPA4N2wXC5vhc+b2IOPCbyVrtgG aBAPwTNZmbLmUmcgrTU8KXNHi3oKSLC58id5BHlHrr22ZNttiLUBER+xz34KswnUJPDK aYyx7iRx5HXf80JmuqzQXAVL4qyhGESOhjAKo76dG0hWNWjknT468Uv9jYCrPNuUWaLg 6YloVMV4DT2oJOYuaSwTtriBfRwc3YjihJoId4MieI8jRWm5aq1QB51lyfKc1boRWoAK 8UMVxbxkDiCfCyTkX2tpkkCchvb26Nimb+xFKd2lrdWFvD9/uHGH4qzzqsPy4QDJk9O5 Okhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RlpZskjf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id q13-20020a170902b10d00b00153b691f326si11450091plr.364.2022.03.21.15.24.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 15:24:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RlpZskjf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1F77F39508E; Mon, 21 Mar 2022 14:39:47 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346495AbiCUKuz (ORCPT + 99 others); Mon, 21 Mar 2022 06:50:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346469AbiCUKup (ORCPT ); Mon, 21 Mar 2022 06:50:45 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2997A23BD7; Mon, 21 Mar 2022 03:49:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 736D7B81202; Mon, 21 Mar 2022 10:49:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37DB5C340E8; Mon, 21 Mar 2022 10:49:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647859757; bh=huUpho3oZIwwEpj2ZIcjMR8j8ncYN4uWkyHSQ8QxcSg=; h=From:To:Cc:Subject:Date:From; b=RlpZskjfYCQaHWnm3drieTw6GwGmKilaNAWb6JJpHjiRftl/luhKimA3ugS8iUjys 9PcvMy7xLWmhAhsI0FxaRZzgJt5Kd/w/PJuIyy+vlLi01PnhLQBwL5Em809Zy0+E5j daOnB02G1bC3mFPOQezcP6gNNLJLyrGBnXM+XN8ZjVV9ZG3xDyB/XZodYBFudRTsjH Xv4H/Z7C2yUGatVUPvVX8MGezPMc5YUpkNcTRMtGrt8+ymHY4VNd6NBTXbJVI+tDKM KHZVeOBiKA700Zyt7Fe4ZBZyVh7bLhlpsXPHXKudFcva4ThrczkYX2OwOE9BwYkfwf O5Z28nXSLtoCA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nWFb8-00FvJp-On; Mon, 21 Mar 2022 10:49:15 +0000 From: Marc Zyngier To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org Cc: Rob Herring , Toan Le , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Bjorn Helgaas , =?UTF-8?q?St=C3=A9phane=20Graber?= , dann frazier , kernel-team@android.com Subject: [PATCH v2 0/2] PCI: xgene: Restore working PCIe functionnality Date: Mon, 21 Mar 2022 10:48:41 +0000 Message-Id: <20220321104843.949645-1-maz@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, robh@kernel.org, toan@os.amperecomputing.com, lorenzo.pieralisi@arm.com, kw@linux.com, bhelgaas@google.com, stgraber@ubuntu.com, dann.frazier@canonical.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since 6dce5aa59e0b ("PCI: xgene: Use inbound resources for setup") was merged in the 5.5 time frame, PCIe on the venerable XGene platform has been unusable: 6dce5aa59e0b broke both XGene-1 (Mustang and m400) and XGene-2 (Merlin), while the addition of c7a75d07827a ("PCI: xgene: Fix IB window setup") fixed XGene-2, but left the rest of the zoo unusable. It is understood that this systems come with "creative" DTs that don't match the expectations of modern kernels. However, there is little to be gained by forcing these changes on users -- the firmware is not upgradable, and the current owner of the IP will deny that these machines have ever existed. Given that, revert both changes and let people enjoy their XGene boxes once again. * From v1 [1]: - Also revert c7a75d07827a ("PCI: xgene: Fix IB window setup") [1] https://lore.kernel.org/r/20220314144429.1947610-1-maz@kernel.org Marc Zyngier (2): PCI: xgene: Revert "PCI: xgene: Use inbound resources for setup" PCI: xgene: Revert "PCI: xgene: Fix IB window setup" drivers/pci/controller/pci-xgene.c | 35 ++++++++++++++++++++---------- 1 file changed, 23 insertions(+), 12 deletions(-) -- 2.34.1