Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 21 Mar 2022 10:34:16 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     "Sandeep Maheswaram (Temp)" <quic_c_sanm@quicinc.com>
Cc:     Felipe Balbi <balbi@kernel.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Doug Anderson <dianders@chromium.org>,
        Matthias Kaehlcke <mka@chromium.org>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Pawel Laszczak <pawell@cadence.com>,
        Peter Chen <peter.chen@kernel.org>,
        Roger Quadros <rogerq@kernel.org>,
        Aswath Govindraju <a-govindraju@ti.com>,
        linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, quic_pkondeti@quicinc.com,
        quic_ppratap@quicinc.com
Subject: Re: [PATCH v2 2/3] usb: xhci: Remove unwanted header inclusion
Message-ID: <YjhGmJYbATchV+Zs@kroah.com>
References: <1646130507-26796-1-git-send-email-quic_c_sanm@quicinc.com>
 <1646130507-26796-3-git-send-email-quic_c_sanm@quicinc.com>
 <YjR0gNPdeI5FTBGs@kroah.com>
 <adb12afc-4591-4a96-9988-e0d6a2ceb060@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <adb12afc-4591-4a96-9988-e0d6a2ceb060@quicinc.com>
Precedence: bulk

On Mon, Mar 21, 2022 at 02:47:08PM +0530, Sandeep Maheswaram (Temp) wrote:
> Hi Greg,
> 
> On 3/18/2022 5:31 PM, Greg Kroah-Hartman wrote:
> > On Tue, Mar 01, 2022 at 03:58:26PM +0530, Sandeep Maheswaram wrote:
> > > Remove the header file and forward declare struct usb_hcd.
> > Why?
> 
> This was done to address below comment in previous version
> 
> https://patchwork.kernel.org/project/linux-arm-msm/patch/1644949454-814-2-git-send-email-quic_c_sanm@quicinc.com/#24739885

Then EXPLAIN THAT in the changelog text.  Don't make us guess.

Please read the kernel documentation for how to write a good changelog
text.  This single sentance does not follow the guidelines at all.

> 
> 
> > 
> > > Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> > > ---
> > >   include/linux/usb/xhci-plat.h | 3 ++-
> > >   1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/include/linux/usb/xhci-plat.h b/include/linux/usb/xhci-plat.h
> > > index 906e907..576e400 100644
> > > --- a/include/linux/usb/xhci-plat.h
> > > +++ b/include/linux/usb/xhci-plat.h
> > > @@ -9,7 +9,8 @@
> > >   #define _XHCI_PLAT_H
> > >   #include <linux/types.h>
> > > -#include <linux/usb/hcd.h>
> > > +
> > > +struct usb_hcd;
> > >   struct xhci_plat_priv {
> > >   	const char *firmware_name;
> > > -- 
> > > 2.7.4
> > > 
> > Where did this come from?  Is this fixing a build breakage from a
> > previous patch?  If not, why is this needed?
> > 
> > confused,
> > 
> > greg k-h
> 
> There wasn't any build breakage.
> 
> This was done to address below comment in previous version
> 
> https://patchwork.kernel.org/project/linux-arm-msm/patch/1644949454-814-2-git-send-email-quic_c_sanm@quicinc.com/#24739885

Again, how were we supposed to know any of this?

Please read the documentation again for how to do this properly.

thanks,

greg k-h