Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933633AbXBYCa4 (ORCPT ); Sat, 24 Feb 2007 21:30:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933634AbXBYCa4 (ORCPT ); Sat, 24 Feb 2007 21:30:56 -0500 Received: from mtiwmhc13.worldnet.att.net ([204.127.131.117]:49978 "EHLO mtiwmhc13.worldnet.att.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933633AbXBYCaz (ORCPT ); Sat, 24 Feb 2007 21:30:55 -0500 Message-ID: <45E0F4D1.9080900@lwfinger.net> Date: Sat, 24 Feb 2007 20:30:41 -0600 From: Larry Finger User-Agent: Thunderbird 1.5.0.9 (X11/20060911) MIME-Version: 1.0 To: Pavel Machek CC: Greg KH , linux-kernel@vger.kernel.org, stable@kernel.org, Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk Subject: Re: [patch 01/18] bcm43xx: Fix for oops on resume References: <20070221014413.282048309@mini.kroah.org> <20070221014939.GB3684@kroah.com> <20070223052526.GA1889@elf.ucw.cz> In-Reply-To: <20070223052526.GA1889@elf.ucw.cz> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1517 Lines: 42 Pavel Machek wrote: > Hi! > >> -stable review patch. If anyone has any objections, please let us know. >> >> ------------------ >> From: Larry Finger >> >> There is a kernel oops on bcm43xx when resuming due to an overly tight timeout loop. >> >> Signed-off-by: Larry Finger >> Signed-off-by: Greg Kroah-Hartman >> >> --- >> drivers/net/wireless/bcm43xx/bcm43xx.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- linux-2.6.18.7.orig/drivers/net/wireless/bcm43xx/bcm43xx.h >> +++ linux-2.6.18.7/drivers/net/wireless/bcm43xx/bcm43xx.h >> @@ -21,7 +21,7 @@ >> #define PFX KBUILD_MODNAME ": " >> >> #define BCM43xx_SWITCH_CORE_MAX_RETRIES 50 >> -#define BCM43xx_IRQWAIT_MAX_RETRIES 50 >> +#define BCM43xx_IRQWAIT_MAX_RETRIES 100 >> >> #define BCM43xx_IO_SIZE 8192 > > I'm sorry, but this does not look like fixing an oops. It may make it > go away for you, or make it less probable, but it certainly can't fix > it. Upon resume, it was taking 65 times through the loop, which caused an oops. We think it is due to a slow-clock setting at that point, but it certainly does get rid of the oops. This change has also eliminated the odd oops seen by a few users. Larry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/