Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 21 Mar 2022 09:28:36 +0000
From:   Paul Cercueil <paul@crapouillou.net>
Subject: Re: [PATCH] iio: dac: ad5592r: Fix the missing return value.
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Zizhuang Deng <sunsetdzz@gmail.com>, Jonathan.Cameron@huawei.com,
        linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
        Paul Cercueil <paul.cercueil@analog.com>
Message-Id: <OZ839R.NWJC2LY54LGX@crapouillou.net>
In-Reply-To: <20220320152047.2a04a62e@jic23-huawei>
References: <20220310125450.4164164-1-sunsetdzz@gmail.com>
        <20220320152047.2a04a62e@jic23-huawei>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

Le dim., mars 20 2022 at 15:20:47 +0000, Jonathan Cameron=20
<jic23@kernel.org> a =E9crit :
> On Thu, 10 Mar 2022 20:54:50 +0800
> Zizhuang Deng <sunsetdzz@gmail.com> wrote:
>=20
>>  The third call to `fwnode_property_read_u32` did not record
>>  the return value, resulting in `channel_offstate` possibly
>>  being assigned the wrong value.
>>=20
>>  Signed-off-by: Zizhuang Deng <sunsetdzz@gmail.com>
> Hi,
>=20
> Definitely rather odd looking and I think your conclusion is correct.
> +CC Paul for confirmation that this isn't doing something clever..

It's been a while, but I don't think there was anything clever going on=20
here - so the patch is fine.

Cheers,
-Paul

>=20
>>  ---
>>   drivers/iio/dac/ad5592r-base.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>>  diff --git a/drivers/iio/dac/ad5592r-base.c=20
>> b/drivers/iio/dac/ad5592r-base.c
>>  index a424b7220b61..4434c1b2a322 100644
>>  --- a/drivers/iio/dac/ad5592r-base.c
>>  +++ b/drivers/iio/dac/ad5592r-base.c
>>  @@ -522,7 +522,7 @@ static int ad5592r_alloc_channels(struct=20
>> iio_dev *iio_dev)
>>   		if (!ret)
>>   			st->channel_modes[reg] =3D tmp;
>>=20
>>  -		fwnode_property_read_u32(child, "adi,off-state", &tmp);
>>  +		ret =3D fwnode_property_read_u32(child, "adi,off-state", &tmp);
>>   		if (!ret)
>>   			st->channel_offstate[reg] =3D tmp;
>>   	}
>=20