Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220321053815.71316-1-schspa@gmail.com> <87a6dj3b5c.fsf@jogness.linutronix.de>
In-Reply-To: <87a6dj3b5c.fsf@jogness.linutronix.de>
From:   Shi Schspa <schspa@gmail.com>
Date:   Mon, 21 Mar 2022 19:57:19 +0800
Message-ID: <CAMA88TpV6p4wRhx1dpRf7V2Oc27FzV_HR7mb70oGn83RGnfF-w@mail.gmail.com>
Subject: Re: [PATCH 5.10-rt] printk: fix suppressed message print when reboot/panic
To:     John Ogness <john.ogness@linutronix.de>
Cc:     pmladek@suse.com, sergey.senozhatsky@gmail.com,
        rostedt@goodmis.org, linux-rt-users@vger.kernel.org,
        linux-kernel@vger.kernel.org, bigeasy@linutronix.de,
        tglx@linutronix.de
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

John Ogness <john.ogness@linutronix.de> writes:

> On 2022-03-21, Schspa Shi <schspa@gmail.com> wrote:
>> Update printk_seq for suppressed message.
>>
>> Affects 5.9-rt and 5.10-rt
>>
>> When message is suppressed, printk_seq should be updated, otherwise
>> this message will be printed when reboot. This problem was introduced
>> in commit 3edc0c85d154 ("printk: Rebase on top of new ring buffer").
>>
>> Signed-off-by: Schspa Shi <schspa@gmail.com>
>
> Reviewed-by: John Ogness <john.ogness@linutronix.de>
>
> Nice catch. Thanks.
>
> 5.15-rt also has this issue, although the fix is slightly different. For
> 5.15-rt, writing to con->printk_seq (via latched_seq_write()) requires
> the console locked. Would you like to post a patch for 5.15-rt as well,
> or would you like me to do it?
>

I have upload a new patch for 5.15-rt, please review it too.
Message-Id: <20220321111501.68241-1-schspa@gmail.com>

> 5.16 and beyond does not have this issue.
>
> John Ogness

BRs

Schspa Shi