Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2285534pxp; Mon, 21 Mar 2022 15:54:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNx/PqcgxbShhICHccbd0m2xO8gAz6lsAmjMV5f5r194oWqhvNqqEm2qWbqZJepHwBNyxp X-Received: by 2002:a63:6685:0:b0:381:b709:4e20 with SMTP id a127-20020a636685000000b00381b7094e20mr19450996pgc.24.1647903266716; Mon, 21 Mar 2022 15:54:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647903266; cv=none; d=google.com; s=arc-20160816; b=rA052pyt+8ABXTBDE8qoSUrOM/CGS7zc/HOfhaRvz/3c8fni5Tu9D6BeOyfdXvuRsp V6o+6hzxjVdspp7tPmUk7QuD5UGK121wgqUmdC1i0soUnvAxozAtXNgXLXre780wD92S ptdYRqNsDDmhmAnzBZLooqlPymb+g/0wHo/1gOMoXqOmfTpaC5a6ffpvLqzSt+ftaFNE SrOBms+iuHuau5P94tl3RwpVZAjVCpXHGkQY/KLTyllYYwc37zSEXn57Z+gEZcZne4aQ 4Rm4c6ZQWKMIiLf6ag3LdSW4Vh6PshrWkmcC+AUHDpLqCmsT2zb0QGS0s7Vsf9me9ZuP 1jZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=X3VYIi0jCMGNpCQqFXFHRVg4AjxiBTyWf2+lhO8Oqcc=; b=A7mAiJHN3gC7WIB7DvEgzS98vI4auVzNEO08+ZipbNpLRgr6wgzsAYTE9zb232f0Gr M5qdvnRIeMRKA4TCZiMptRtcn5JCrzFNeel5l616q2yQso8A/iJiaiy4zEWxDaF1oe3X ipNf32saaVmSuAarXJO4z20zr49knYZIWG6FgGlotVg5igOa1drU0X2hD25vGRUYCohB 9Emn6rexGrhOZ3HGSkbXWIGo7BUI/yhXqAdENl/GoubnX/wQvCL5eb9qpGONBiQwGGPc W1AOMY8Dg/9T0k7hIjMZ8EFKjdsK4t4rjyo/4taMpw/JsIbLczWtGg1vK5n1QPiwHaM7 iQIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VXFT1sHf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id q2-20020a17090aa00200b001c6a671b0adsi611095pjp.113.2022.03.21.15.54.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 15:54:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VXFT1sHf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7D1A969483; Mon, 21 Mar 2022 15:04:18 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349074AbiCUOHn (ORCPT + 99 others); Mon, 21 Mar 2022 10:07:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348513AbiCUOAW (ORCPT ); Mon, 21 Mar 2022 10:00:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18C9B396A6; Mon, 21 Mar 2022 06:58:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 925596125C; Mon, 21 Mar 2022 13:58:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8084C340F2; Mon, 21 Mar 2022 13:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647871126; bh=lhp5KPgkqNQMD0iMwsTPMTbGR16W4F3pRMK30uJXhLY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VXFT1sHfWHi3FSTV8U3w7z9tYRqc37t9twwL1fL24uuplD2WkBjKMzdGBaw1dJQ1g eg9gc6lcZYflBfLlUHmnbsa3vEPbcy6AHhIS9pD1IYzAlxcNg648UxH1EqYvfeRiTt 9uwZ7uuudEV8pug3R6dTzs05BWRJYa/eaWgquaZE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Paolo Abeni , Sasha Levin Subject: [PATCH 5.10 14/30] net: dsa: Add missing of_node_put() in dsa_port_parse_of Date: Mon, 21 Mar 2022 14:52:44 +0100 Message-Id: <20220321133220.058790653@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220321133219.643490199@linuxfoundation.org> References: <20220321133219.643490199@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit cb0b430b4e3acc88c85e0ad2e25f2a25a5765262 ] The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done. Fixes: 6d4e5c570c2d ("net: dsa: get port type at parse time") Signed-off-by: Miaoqian Lin Link: https://lore.kernel.org/r/20220316082602.10785-1-linmq006@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- net/dsa/dsa2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index 71c8ef7d4087..f543fca6dfcb 100644 --- a/net/dsa/dsa2.c +++ b/net/dsa/dsa2.c @@ -766,6 +766,7 @@ static int dsa_port_parse_of(struct dsa_port *dp, struct device_node *dn) struct net_device *master; master = of_find_net_device_by_node(ethernet); + of_node_put(ethernet); if (!master) return -EPROBE_DEFER; -- 2.34.1