Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933664AbXBYFuP (ORCPT ); Sun, 25 Feb 2007 00:50:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933666AbXBYFuP (ORCPT ); Sun, 25 Feb 2007 00:50:15 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:48691 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933664AbXBYFuM (ORCPT ); Sun, 25 Feb 2007 00:50:12 -0500 Date: Sun, 25 Feb 2007 05:50:11 +0000 From: Christoph Hellwig To: Artem Bityutskiy Cc: Christoph Hellwig , Linux Kernel Mailing List , Frank Haverkamp , Josh Boyer , Thomas Gleixner , David Woodhouse Subject: Re: [PATCH 05/44 take 2] [UBI] internal common header Message-ID: <20070225055011.GA8616@infradead.org> Mail-Followup-To: Christoph Hellwig , Artem Bityutskiy , Linux Kernel Mailing List , Frank Haverkamp , Josh Boyer , Thomas Gleixner , David Woodhouse References: <20070217165424.5845.4390.sendpatchset@localhost.localdomain> <20070217165449.5845.18238.sendpatchset@localhost.localdomain> <20070219105445.GA16930@infradead.org> <1171976753.4039.27.camel@sauron> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1171976753.4039.27.camel@sauron> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 801 Lines: 15 On Tue, Feb 20, 2007 at 03:05:53PM +0200, Artem Bityutskiy wrote: > > Having this kind of global information directly exposed is a very > > bad idea. In general you only want to access it through more > > specific information and avoid allocating the global array at all. > > I do not see what is the problem with this. Please, refine. global variables are very bad for code maintainability and understanadbility. So we usually try to avoid them if possible and make them static to a single file and provide proper accessors for allowed actions on them. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/