Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220321123626.3068639-1-jakobkoschel@gmail.com>
In-Reply-To: <20220321123626.3068639-1-jakobkoschel@gmail.com>
From:   Vaibhav Agarwal <vaibhav.sr@gmail.com>
Date:   Tue, 22 Mar 2022 00:08:43 +0530
Message-ID: <CAAs364-0t4rF4QPywshd2-CnkRmOpP3xZ_K7zZay8UqNOCo1vg@mail.gmail.com>
Subject: Re: [PATCH] staging: greybus: codecs: fix type confusion of list
 iterator variable
To:     Jakob Koschel <jakobkoschel@gmail.com>
Cc:     open list <linux-kernel@vger.kernel.org>,
        "moderated list:GREYBUS SUBSYSTEM" <greybus-dev@lists.linaro.org>,
        linux-staging@lists.linux.dev, Mark Greer <mgreer@animalcreek.com>,
        Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mike Rapoport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Mar 21, 2022 at 6:07 PM Jakob Koschel <jakobkoschel@gmail.com> wrote:
>
> If the list does not exit early then data == NULL and 'module' does not
> point to a valid list element.
> Using 'module' in such a case is not valid and was therefore removed.
>
> Fixes: 6dd67645f22c ("greybus: audio: Use single codec driver registration")
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
> ---
>  drivers/staging/greybus/audio_codec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index b589cf6b1d03..e19b91e7a72e 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -599,8 +599,8 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
>                         break;
>         }
>         if (!data) {
> -               dev_err(dai->dev, "%s:%s DATA connection missing\n",
> -                       dai->name, module->name);
> +               dev_err(dai->dev, "%s DATA connection missing\n",
> +                       dai->name);
>                 mutex_unlock(&codec->lock);
>                 return -ENODEV;
>         }
>
> base-commit: f443e374ae131c168a065ea1748feac6b2e76613

Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>


> --
> 2.25.1