Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <fb1a6cb4-1a75-d28c-09e8-5561a84198fe@intel.com>
Date:   Fri, 18 Mar 2022 20:42:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.7.0
Subject: Re: [PATCH v2 2/2] PCI/PM: Fix pci_pm_suspend_noirq() to disable PTM
Content-Language: en-US
To:     Rajvi Jingar <rajvi.jingar@intel.com>, <bhelgaas@google.com>
CC:     <david.e.box@linux.intel.com>, <linux-pci@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>
References: <20220317233153.2617938-1-rajvi.jingar@intel.com>
 <20220317233153.2617938-2-rajvi.jingar@intel.com>
From:   "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego
 173, 80-298 Gdansk
In-Reply-To: <20220317233153.2617938-2-rajvi.jingar@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2l5V0F5UkdMYzg5eDZvK3RFVnc4UzFRQUxvL29TdEoyQWZ6MlliL2svMSt5?=
 =?utf-8?B?cUNzcFJhbXUvVU9URnRwTTFMeFNOc25sQmY0dW5BV21oQ1Z5N0gyWERtZitj?=
 =?utf-8?B?ZXQybG5ZYWdESXU0cUIzdVg0S2taa2RQeTFVODVDanNPbnRNUzdybnZEKzdz?=
 =?utf-8?B?NHNtbU5Zd0JqL1IwOWVKb2VDWHpNTUZQdUJKb3hPRnIwU1BOSi9tUjY2dFI3?=
 =?utf-8?B?YzBZQXVCM2J0TU1uMk1CazEvN3lOejJ1aFRyQ1E5UnhGbVhBYnlNakRWT0li?=
 =?utf-8?B?b01nRTltTWY1dFB4UHVzK3pUZmM1clgyajNFbmVYQXRyRzRxeE54MXM1ampi?=
 =?utf-8?B?Zm15dmdiNHB4T0NqTDFHNENPUldacmY2VzUvd2N4dkVTQk5TU3o1RVRwT3F4?=
 =?utf-8?B?cEljclo5NnYrdkN5SkR2bkJYaDFDYkVsdUVsNXUvcGpodHl3RS85UnRyR25u?=
 =?utf-8?B?aW1CUUU3NEJDOFlIVmdPdXgxaGY2MFZyMEpuQUs0VktXZWdvQ245ay9ZREZR?=
 =?utf-8?B?dWlINFEwNG9LQnlRYU5MK0FsaFU0UmhyNGthRmdETHZXRTZmc2hPKzVjZkN0?=
 =?utf-8?B?Z1F2dm5tT0ZDVk1VV1owd1daYnJ1WlMyK1IzRmwzQllzaURDQnIxZnRUUDJk?=
 =?utf-8?B?VWdEeno3TnVobm11ZHp1MWN2Zjl1bWNrZ3c2N0Rndi8raTlIVDBLNnovSlpI?=
 =?utf-8?B?dXR4RTA1enEyS2I5KzV5QmN2UHNwNmIvUW9aZCttTUVzdHoyVW5Hakh3M0M2?=
 =?utf-8?B?aTNERUEydlJJYk5vWDhhMkVKaXNyZjZVMjNXT3g0NXkrdUhlc2RZY013RmtK?=
 =?utf-8?B?K1pjR0d0UkNoSGdPVTJ6UUk4bUNuRXZyMXIzd3hrSFdlY21zbXkrSG9oK2RP?=
 =?utf-8?B?bHdST0E2emt5L0RDNnRiZklRWXRNa1JwNTVuWGdXbVdtV1VzU09MRzVtd3Fq?=
 =?utf-8?B?MWl2YTlmeGtManFQS1pOd2hoU1VFalIxSmN3b0JJU2xBNGhMWUlZZExhdStt?=
 =?utf-8?B?aDhxNTloTWZ0SE0yR0pyRDNlN1FTckh1eGFkVDBlUi9qNjZTckdJK0EyWWRE?=
 =?utf-8?B?UGJ6MlNwL1RIbHhQUEp1UnpJZXByNWpkVkxsME95RC9TVllCVmFDMGFSd3V3?=
 =?utf-8?B?NDBkRGJhSG5TbkNVbHUxK2JQaVlCTHpoa2QwRGVkMlIrMnR0bmZuTnkyYnRs?=
 =?utf-8?B?UTU0U2JjQTdVTEVoclVXMjBHYmhiSVYyM09MakpMNVN1dVhCSTFDZDdSQnBh?=
 =?utf-8?B?TFJORXB4SFhsbFptRmR2L25uVG1XaWNEK3NIR0RVV05kdDBwYzAzcVNKRmJJ?=
 =?utf-8?B?UUtCdWdwNHNGNUdLK2dDdm5aVno2d0tpWEdMZURjeGYxTldWUndadjk0blhm?=
 =?utf-8?B?UXJzeHcwTjJ6Y0ZRbnpESkFUU2tXL3R0eHZoWi9VWnNtRFVTbUtWcnZLNlZB?=
 =?utf-8?B?SjloK3MrRGFETWczMk1TUWQxMnRZQm9FMkVhRnpCMEFxSnFxSzNRR2ZZTVps?=
 =?utf-8?B?MkpWdEl5bWlmb3BIeWV2OXg4Um5oZ016OVh4Y2kzaStWRjVHZ3UyY1BQT1ZT?=
 =?utf-8?B?c1k2eTlyVkN4b3FnbUFKdGV4bWpSdGVwZy9JUlBnd0YrdjZpWTl1anZOYjJP?=
 =?utf-8?B?RnRJQXpkaDNCTnFTenN2Z3NCYkZNQlAxKzBGamtBRWIxSVFhcXZIUkhSbzFH?=
 =?utf-8?B?QmZCUmRDYkpjcUtEY2FkU1ZLMDVZOHQzell0cll2K25nNmJFZmhCVXU1SitO?=
 =?utf-8?B?ZEFkeFBYcXluaUtsNEdHUy9oS2pVaGZIc0c1Wk9ucWpncWVmNVRpVmRwTEkw?=
 =?utf-8?B?aGQ1emhyWmRQWHBsZnFPdXJOalRTVnU1d3BNSDY5anVoakh0N3dDYTJNRUll?=
 =?utf-8?B?aWVSZEtmU0p6Sk1vN012Tk9zK1VRT0wrcjJ2ZXRrMENIMHRIU3BxOGZuakpQ?=
 =?utf-8?B?NUZOQXpDKzI3WFJEZ0d6dHJJVWJIaDBRLzlnY05jd0ZXelh2Nm1QZkh1amhX?=
 =?utf-8?B?WU5uMFE4Q2dBPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 83e0d58e-3087-4aee-5dbb-08da09177e2b
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5810.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2022 19:42:53.4528
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yGBEjoWx3RO1h917vMbFk9Cu8tq/oWjq8rqy7W+Ckqi46y8KbUmgZ2v5j0uSlhshuyDlc+Y7bZaM/59nijvpx2lpHSHe+DDwtsvzGi02egM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2254
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/18/2022 12:31 AM, Rajvi Jingar wrote:
> For the PCIe devices (like nvme) that do not go into D3 state still need to
> disable PTM on PCIe root ports to allow the port to enter a lower-power PM
> state and the SoC to reach a lower-power idle state as a whole. Move the
> pci_disable_ptm() out of pci_prepare_to_sleep() as this code path is not
> followed for devices that do not go into D3. This patch fixes the issue
> seen on Dell XPS 9300 with Ice Lake CPU and Dell Precision 5530 with Coffee
> Lake CPU platforms to get improved residency in low power idle states.
>
> v2: add Fixes tag in commit message

Again, please move the above line after the tags below and add another 
--- marker between it and the tags.


> Fixes: a697f072f5da ("PCI: Disable PTM during suspend to save power")
> Signed-off-by: Rajvi Jingar <rajvi.jingar@intel.com>
> Suggested-by: David E. Box <david.e.box@linux.intel.com>
> ---
>   drivers/pci/pci-driver.c | 10 ++++++++++
>   drivers/pci/pci.c        | 10 ----------
>   2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
> index ffe76f238d7e..228d21700825 100644
> --- a/drivers/pci/pci-driver.c
> +++ b/drivers/pci/pci-driver.c
> @@ -836,6 +836,16 @@ static int pci_pm_suspend_noirq(struct device *dev)
>   
>   	if (!pci_dev->state_saved) {
>   		pci_save_state(pci_dev);
> +		/*
> +		 * There are systems (for example, Intel mobile chips since Coffee
> +		 * Lake) where the power drawn while suspended can be significantly
> +		 * reduced by disabling PTM on PCIe root ports as this allows the
> +		 * port to enter a lower-power PM state and the SoC to reach a
> +		 * lower-power idle state as a whole.
> +		 */
> +		if (pci_pcie_type(pci_dev) == PCI_EXP_TYPE_ROOT_PORT)
> +			pci_disable_ptm(pci_dev);
> +
>   		/*
>   		 * If the device is a bridge with a child in D0 below it, it needs to
>   		 * stay in D0, so check skip_bus_pm to avoid putting it into a
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 9ecce435fb3f..f8768672c064 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -2660,16 +2660,6 @@ int pci_prepare_to_sleep(struct pci_dev *dev)
>   	if (target_state == PCI_POWER_ERROR)
>   		return -EIO;
>   
> -	/*
> -	 * There are systems (for example, Intel mobile chips since Coffee
> -	 * Lake) where the power drawn while suspended can be significantly
> -	 * reduced by disabling PTM on PCIe root ports as this allows the
> -	 * port to enter a lower-power PM state and the SoC to reach a
> -	 * lower-power idle state as a whole.
> -	 */
> -	if (pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT)
> -		pci_disable_ptm(dev);
> -
>   	pci_enable_wake(dev, target_state, wakeup);
>   
>   	error = pci_set_power_state(dev, target_state);