Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2287304pxp; Mon, 21 Mar 2022 15:57:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjajFVpOPpARyxjGwRM8dP3xXmH/IHXbrlW+jBmPH3LQH2tLnYsOLW2hINtu1WIpMedLfM X-Received: by 2002:a17:902:ce05:b0:14f:8cfa:1ace with SMTP id k5-20020a170902ce0500b0014f8cfa1acemr14915588plg.149.1647903471979; Mon, 21 Mar 2022 15:57:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647903471; cv=none; d=google.com; s=arc-20160816; b=pxCGnlKQPoQxGXFWY7iKO0NRwWMs+QiAW1LBrXP/CWzwJFQm/Zf1FXATOh2RcvgCvy kL3/LtUIgbKIvqwfWLbkUDs7FOMDwXFAo52EgD28m50SjbkBfynj8GJSucGgRVsrOZ6D TuvOQKs1CuIzuUO5hkZrj084sxLy1qYYGFS01zPkCXSit3e8Ql2rMJGCiY038n2bSDAY hnctXW/NUAZ8l1RPGd5ypwaF55FEBjP+IK404z0o/4pGC+bIiJuRYXAmJesUgJBigP8M TP1Fv8PiUvu2wSsBSEhh+i77esk2Vs3R8S+YxQX3lixI6p9bI2YxakpOUM4Hj4xQYtKQ 6rXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=FLDbE82mxCKRHI7RE3CFsCL4X77GCuEUqduBBgWENhQ=; b=Ik4YTaFoFbaonN5/navDowVNORBPMXGqxdXno/sRgbWI0LCGxYZ55EnIxyiT61ewAO Q+gkHBeESwpBgwuH530FcvkfZE+y0ymnMutZU5kOj1qRvSd2letkKBtqr0JGIieHOdAT nsvnXCgE15YUemjxNb7sAuPE7LYzNqKdqluVNNbtd6AlEOhs+NkxiqYl7PbV/PPLyIE4 wEYBgzicS4mD29j3SDqnJvB7nM+BDT9X1AFH27Wzgc3czGQK9DQynZiUedGdmxgKfu8F BtZ9QztcyuLoexC/89Poj9Iqz29mmyX4a0WiOygzsX7vNAO3aWDMo7L2aNPb7sDTR0L3 B5Eg== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id ck3-20020a17090afe0300b001bd14e03046si551738pjb.30.2022.03.21.15.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 15:57:51 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D95AC356E59; Mon, 21 Mar 2022 15:10:05 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344310AbiCUK7w (ORCPT + 99 others); Mon, 21 Mar 2022 06:59:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346524AbiCUK7u (ORCPT ); Mon, 21 Mar 2022 06:59:50 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C5D21ADB8 for ; Mon, 21 Mar 2022 03:58:25 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWFjs-0007N4-Vq; Mon, 21 Mar 2022 11:58:17 +0100 Message-ID: <73570ee11ddbbda96463e8fad3ad533c83716782.camel@pengutronix.de> Subject: Re: [PATCH V2] soc: imx: imx8m-blk-ctrl: Fix IMX8MN_DISPBLK_PD_ISI hang From: Lucas Stach To: Adam Ford , linux-arm-kernel@lists.infradead.org Cc: aford@beaconembedded.com, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org Date: Mon, 21 Mar 2022 11:58:15 +0100 In-Reply-To: <20220320205212.701548-1-aford173@gmail.com> References: <20220320205212.701548-1-aford173@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Sonntag, dem 20.03.2022 um 15:52 -0500 schrieb Adam Ford: > The imx8mn clock list for the ISI lists four clocks, but DOMAIN_MAX_CLKS > was set to 3. Because of this, attempts to enable the fourth clock failed, > threw some splat, and ultimately hung. > > Fixes: 7f511d514e8c ("soc: imx: imx8m-blk-ctrl: add i.MX8MN DISP blk-ctrl") > Signed-off-by: Adam Ford Reviewed-by: Lucas Stach > > diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c > index a0a0d2d7ca4a..7109f0d508e2 100644 > --- a/drivers/soc/imx/imx8m-blk-ctrl.c > +++ b/drivers/soc/imx/imx8m-blk-ctrl.c > @@ -50,7 +50,7 @@ struct imx8m_blk_ctrl_domain_data { > u32 mipi_phy_rst_mask; > }; > > -#define DOMAIN_MAX_CLKS 3 > +#define DOMAIN_MAX_CLKS 4 > > struct imx8m_blk_ctrl_domain { > struct generic_pm_domain genpd;