Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2287867pxp; Mon, 21 Mar 2022 15:59:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAb+52HisXF39DqNURqTbiPGRKkqyEyVjignc8lvQxaJYHE4/wcoZTwJNPjXTs4aYElJrQ X-Received: by 2002:a63:d316:0:b0:380:85b6:d595 with SMTP id b22-20020a63d316000000b0038085b6d595mr19919298pgg.0.1647903539950; Mon, 21 Mar 2022 15:58:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647903539; cv=none; d=google.com; s=arc-20160816; b=tk/4kdUgB2LAYeOCrtzRBXNcdpyAfAkP0DInN+HsQrv35onDxpfGZuSr/GvM/2eQsL B+7AFIr8fvipKLG+sUhsynd1CmmBymhMvyPMZauhqXW5DyO52Ra03leobfA3ztbl//yu asmKArtg/jBQORMGdTqOv69xMknehdHrsFeZ+l8611ix9tmj8C/1KsRoxCluPZlMKXIg NuXakPm+T1/s7L91QzIYWX7zMmpUiXPK2ajlZFw3FyaVsSuYVlwfiqLYSTkHQIynXNBK LOmv7D3br80+CeXLLomblkQfGjhHSfhHUi4ZAVm8Y1yUJOW4Yoh0tNsydM0W7wn1HYoZ lrww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=axQy2qCAlsIoCv1hQbGH/v2b+oq9maOH1YETcxdSZxg=; b=dxAIUjjCabAVuUg+6+iRc5cKamXYc5MP5AvPBSjoTGpLcUmwmmhCJkIiGutmIqCvi0 Bf1ar1/s503kyI7pJ59RAcwAVqC92PsK2RzPsckHR0Ch9FdTFin5AJcb8xbIymVPf1Mp 756iWle8Sl4ri2CA9lNFsDuID5w+RDMXP0V62Q/+Ec28BCacMH46mvE1B9KQbcWtA1ch 2Gqzdb/EbK1C2YhS3lpOGPtAuWr5CSMbaZGwXCYvY9gil3QZUR3Tha9X09ElsdxNuiWl Ct1+jqfWeXhixkoef+IIw/d7hKAiYZW6rMVLoEetlxtfr/V4hMLuB+4Yr977J1993KT4 QsWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=fT6kxIzW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id d7-20020a056a00198700b004fa3a8e008fsi8013401pfl.326.2022.03.21.15.58.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 15:58:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=fT6kxIzW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 93A2342ECBC; Mon, 21 Mar 2022 15:12:07 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352294AbiCUSp7 (ORCPT + 99 others); Mon, 21 Mar 2022 14:45:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347846AbiCUSp6 (ORCPT ); Mon, 21 Mar 2022 14:45:58 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 874AB18CD08; Mon, 21 Mar 2022 11:44:32 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id p9so21918520wra.12; Mon, 21 Mar 2022 11:44:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=axQy2qCAlsIoCv1hQbGH/v2b+oq9maOH1YETcxdSZxg=; b=fT6kxIzW8ZZFIk0vIyx/K+RXK/LNnjWhKg6LbNDZgLrANujlVUA1QcGw+Ct7yILkXV dMIKchd1WFdj5qNCDxsDbNGYxlapSBSPxBZwHEhlCNHqqcYktrKAX6OzUplUpLGwTe5K yapGBJZ6uH5p+EK29VpxiU1O4Act+B3Zh14aSXP5t4kst0nP1SBf0LpuBdHs3FuTGrYI YG3gpytp0hE/fIx8cply7IwFX+eE19Ajn46q8nBzyKsL75ZwIRF/OBaeADiJwEZBtP3z KLVih/97h8FJdBBQM3gXYK6cCBVlYnDZy4s/y68/ySu6s4xROvZq/mHoWc79cSydKU0V tATg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=axQy2qCAlsIoCv1hQbGH/v2b+oq9maOH1YETcxdSZxg=; b=fCX/EXwimwgdGrA7DtO3tAmvJR4F/Hcjx5W86197wzL8apzd3+4a2NAAwnEzBHDbLa OFwV/IvNuMWg0sgJKc9R8Tvec9wXorb5Vx419cjLQKLDBwvP5XtyzqeAl970TM0VKxyI SHUPVVa3tKLR+VdqpgzDRlLeUIMsbTCpTlfcSE3jCwaqJM1W64Kxh7HHeAYM0ImfyXsT MEYO9H5zlQwzh0Bdqic2tfMovcj27jF5pSdnMlimwNquqgmQQqHy1ctAJf4rg087ql6d ACBMKbj/R+lJlHfcYKLmyQcc7NISoJa+yJ7l0YsucH30IwFvrGkjgC5gPe4AcxOAuyIf q1hA== X-Gm-Message-State: AOAM5324/K+yC1XKBoHmJ9FVdyIQq8T4271Nr6UZ6Fx5eIMslZgMLo4j EcKUHbsifUUGb3lKB93w+mQ= X-Received: by 2002:a5d:6e8e:0:b0:1e6:754b:47de with SMTP id k14-20020a5d6e8e000000b001e6754b47demr19609439wrz.208.1647888270918; Mon, 21 Mar 2022 11:44:30 -0700 (PDT) Received: from localhost.localdomain ([94.73.33.246]) by smtp.gmail.com with ESMTPSA id z5-20020a05600c0a0500b0037bb8df81a2sm301886wmp.13.2022.03.21.11.44.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 11:44:30 -0700 (PDT) From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= To: jkosina@suse.cz Cc: tiwai@suse.de, benjamin.tissoires@redhat.com, regressions@leemhuis.info, peter.hutterer@who-t.net, linux-input@vger.kernel.org, stable@vger.kernel.org, regressions@lists.linux.dev, linux-kernel@vger.kernel.org, =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= Subject: [PATCH] Revert "Input: clear BTN_RIGHT/MIDDLE on buttonpads" Date: Mon, 21 Mar 2022 19:44:05 +0100 Message-Id: <20220321184404.20025-1-jose.exposito89@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 37ef4c19b4c659926ce65a7ac709ceaefb211c40. The touchpad present in the Dell Precision 7550 and 7750 laptops reports a HID_DG_BUTTONTYPE of type MT_BUTTONTYPE_CLICKPAD. However, the device is not a clickpad, it is a touchpad with physical buttons. In order to fix this issue, a quirk for the device was introduced in libinput [1] [2] to disable the INPUT_PROP_BUTTONPAD property: [Precision 7x50 Touchpad] MatchBus=i2c MatchUdevType=touchpad MatchDMIModalias=dmi:*svnDellInc.:pnPrecision7?50* AttrInputPropDisable=INPUT_PROP_BUTTONPAD However, because of the change introduced in 37ef4c19b4 ("Input: clear BTN_RIGHT/MIDDLE on buttonpads") the BTN_RIGHT key bit is not mapped anymore breaking the device right click button and making impossible to workaround it in user space. In order to avoid breakage on other present or future devices, revert the patch causing the issue. Cc: stable@vger.kernel.org Link: https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/481 [1] Link: https://bugzilla.redhat.com/show_bug.cgi?id=1868789 [2] Signed-off-by: José Expósito --- drivers/input/input.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/input/input.c b/drivers/input/input.c index c3139bc2aa0d..ccaeb2426385 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c @@ -2285,12 +2285,6 @@ int input_register_device(struct input_dev *dev) /* KEY_RESERVED is not supposed to be transmitted to userspace. */ __clear_bit(KEY_RESERVED, dev->keybit); - /* Buttonpads should not map BTN_RIGHT and/or BTN_MIDDLE. */ - if (test_bit(INPUT_PROP_BUTTONPAD, dev->propbit)) { - __clear_bit(BTN_RIGHT, dev->keybit); - __clear_bit(BTN_MIDDLE, dev->keybit); - } - /* Make sure that bitmasks not mentioned in dev->evbit are clean. */ input_cleanse_bitmasks(dev); -- 2.25.1