Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     syzbot <syzbot+d55757faa9b80590767b@syzkaller.appspotmail.com>,
        syzkaller-bugs@googlegroups.com,
        David Howells <dhowells@redhat.com>
Cc:     dhowells@redhat.com, christophe.jaillet@wanadoo.fr,
        linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] KASAN: null-ptr-deref Read in __free_pages
Date:   Mon, 21 Mar 2022 09:43:58 +0100
Message-ID: <2113719.Icojqenx9y@leap>
In-Reply-To: <970502.1647851062@warthog.procyon.org.uk>
References: <000000000000b1807c05daad8f98@google.com> <970502.1647851062@warthog.procyon.org.uk>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On luned=C3=AC 21 marzo 2022 09:24:22 CET David Howells wrote:
> It should be possible to just test for the pointer being NULL in the loop
> before calling __free_pages() since the list was allocated with kcalloc().
>=20
> David
>=20
> #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-f=
s.git 6d39b096627f0a1eb6e14f049d8ae3c93e0290f2
>=20
> --=20
> You received this message because you are subscribed to the Google Groups=
 "syzkaller-bugs" group.
> To unsubscribe from this group and stop receiving emails from it, send an=
 email to syzkaller-bugs+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgi=
d/syzkaller-bugs/970502.1647851062%40warthog.procyon.org.uk.
>=20
Hello David,

I had already sent a patch for this problem:
https://lore.kernel.org/lkml/20220321014246.19941-1-fmdefrancesco@gmail.com/

However, I see that you ignored mine and preferred yours. I would have appr=
eciated=20
to have your review of my patch or to discuss the pros and cons of yours vs=
=2E my=20
solution and be CC'ed in this thread because I've spent some time on it :)

Best regards,

=46abio M. De Francesco