Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2288896pxp; Mon, 21 Mar 2022 16:00:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxEYpQvnyY6TUyKO36/xFiQwGU/wedE3+cmB0VqWJeGI4UAc8IPL8Y1Jkzd18LAC5xlprtO X-Received: by 2002:a05:6808:578:b0:2d9:e017:f267 with SMTP id j24-20020a056808057800b002d9e017f267mr737981oig.2.1647903643242; Mon, 21 Mar 2022 16:00:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647903643; cv=none; d=google.com; s=arc-20160816; b=xHT36my9g1E0F+gdsEpRgLIbxy2wP7+HKxU/w9yJC2qgA8tE3PHTLggZtcUhBz4vVD Oc2VxenvJvAuwv8V8XYxg3Q0xNJZWi+L01zVRjbeKWgyzO3+pLgYkZDOlUt80vrc7uSq 7Gq4DIpT/kSkuwDRiXx3iwCX7B20bSnZ5G+egdK3X1FzTFMq+q6UiqAteOtII0bpjVur zG8QYVeRe3rC4HvoZRlwjtehMiTNZ/XITvM5nfehZRWct/W2CESupZeIMxpXfP0oCpwf h0fZdho+po2Hmb9jWqnoWRTwaIQm98wFgMui7cVyeslq0SdXGmaVQzl4iyWFC66EYQXk KLKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=n30E3nDjwaOIKK9ulZEPcByc19x2iR9Tl8iGEUpVfgc=; b=SXIQF7kisWLTSIKRw05cyQcff0mETdRtTn8qAo6ud40SRGHQKoxTgYrMjBPatrhXj3 gdX96ySpa1WWdJB+yI3nu1628oAe5cX01P1OgK0oeDw2CvQO++Pz7DMv3bus3w/xmDV0 wxQI/nqL6lvRnAc25OkmoZFF1dXb6825QIJszVzX+u11vPkvVbcba5rSulpNcXn6auco DHn6lImTdjmshgriMhjW804DD0Q+sWOiyi7blgc0cYxFbRiPCSM0oEB7vPZSvYkvaE57 pESBEPqAG/YPmBy0pXqW1DyAS9qHySNI2uoV7sG5aBEgQFAqHIUtfeWnhqzokqbjx+E9 lKxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id k9-20020a544409000000b002ef0c3475e0si4160400oiw.96.2022.03.21.16.00.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 16:00:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9F798343DE1; Mon, 21 Mar 2022 14:59:46 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349685AbiCUOxd (ORCPT + 99 others); Mon, 21 Mar 2022 10:53:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349859AbiCUOxP (ORCPT ); Mon, 21 Mar 2022 10:53:15 -0400 Received: from out30-42.freemail.mail.aliyun.com (out30-42.freemail.mail.aliyun.com [115.124.30.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0942754F8A; Mon, 21 Mar 2022 07:51:49 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R891e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0V7r0Du3_1647874305; Received: from 192.168.31.65(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0V7r0Du3_1647874305) by smtp.aliyun-inc.com(127.0.0.1); Mon, 21 Mar 2022 22:51:46 +0800 Message-ID: Date: Mon, 21 Mar 2022 22:51:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v5 06/22] cachefiles: implement on-demand read Content-Language: en-US To: David Howells Cc: linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com References: <20220316131723.111553-7-jefflexu@linux.alibaba.com> <20220316131723.111553-1-jefflexu@linux.alibaba.com> <1029512.1647871543@warthog.procyon.org.uk> From: JeffleXu In-Reply-To: <1029512.1647871543@warthog.procyon.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/21/22 10:05 PM, David Howells wrote: > Jeffle Xu wrote: > >> + { "cread", cachefiles_ondemand_cread }, > > Rather than adding the cread command, would it be better to use an ioctl on > the anon fd as the /dev/cachefiles write op is serialised? Sounds reasonable. I will try it in the next version. Thanks. > >> + /* Stop enqueuig request when daemon closes anon_fd prematurely. */ > > "Enqueuing" Wow.. Maybe I need to update my checkpatch... -- Thanks, Jeffle