Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 21 Mar 2022 19:22:21 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     David Laight <David.Laight@ACULAB.COM>
Cc:     Jakob Koschel <jakobkoschel@gmail.com>,
        Joseph Qi <joseph.qi@linux.alibaba.com>,
        Mark Fasheh <mark@fasheh.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "ocfs2-devel@oss.oracle.com" <ocfs2-devel@oss.oracle.com>,
        Joel Becker <jlbec@evilplan.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Miguel Ojeda <ojeda@kernel.org>,
        Mike Rapoport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>
Subject: Re: [PATCH] ocfs2: fix check if list iterator did find an element
Message-ID: <20220321162221.GQ336@kadam>
References: <20220319203106.2541700-1-jakobkoschel@gmail.com>
 <abcbf5d2-c348-7dc0-cfd3-9bcc6431bc64@linux.alibaba.com>
 <A7AA04AA-6B4C-4211-99A6-0D3C04ED7B26@gmail.com>
 <20220321135435.GL336@kadam>
 <75180dd18a3f460891cd93f7fcb3aa1c@AcuMS.aculab.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <75180dd18a3f460891cd93f7fcb3aa1c@AcuMS.aculab.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nbVuDx8nZvGH6Dunlox/cj9XSmUQwk8tmn9yRcJGSlAmSOF5IiZT+10sJdg1?=
 =?us-ascii?Q?vQNmqSq3fBfbiUBcHNx8RaClouXGBtvJ7Y/h3AFeJ0rN1RFfgaVxE8hd0CgM?=
 =?us-ascii?Q?Z5H0cpHRhvpcHsoTC9Dkzytv8hHIeT0Om7cPdLMemGpxgf86Zl8tpepv/arH?=
 =?us-ascii?Q?rOrZHGa/ikM70tIamRSaoCJVhi2+2mtvM0W3SJAD1STuXyH3xHaDNkO+JDZ8?=
 =?us-ascii?Q?S376OoTYwYo+dkjcbC+qULQrfqAdn9q18sJOMVydFFhQeAnQz6hSgw42Syv7?=
 =?us-ascii?Q?Eoiw5/NPuQydGZt2+JK5OddMM7RbINEaB0frvwOioArbOt2hz3QdZfAqBmGj?=
 =?us-ascii?Q?LGbXGjLMDSCGldUzf1sBo9bx+ryrF5/h0Z/8s33fntgWZ/8D0oO2c5CG/Cui?=
 =?us-ascii?Q?ZKhcH7KKeybKEEobRhOW8IUYXex3q2AEUsxA6IP4VandPxJm19eshM/ljF9P?=
 =?us-ascii?Q?F103sORGP5HxWSceRr8UvQCAPg6W3F8Ir8hqNVVhsCiOkS1ZW6+x2ukHOeFL?=
 =?us-ascii?Q?JM7UJqyulviArABp0D+BE/jvwk8mym8jzovfAIzRTySnkIjhE0R2VQl34BDX?=
 =?us-ascii?Q?pTVpiaDSZnKNg/Nlj+ol3nhjI+7SbNjAbYCcpk9yd/cuo5I4gi4+s7v9rJ5P?=
 =?us-ascii?Q?Pc4gruQCzdk5H12Ipm+deeiNXHBgnlzYdwgzN89hM2RptA7GoWlvn2SkA2Wq?=
 =?us-ascii?Q?5q2hgQUtCToqu+AowTPJ3L2UTabztBBcHecGKrcckMSrb59zs1V9+fV+5vMe?=
 =?us-ascii?Q?62c2HTDbINwizV31S3O+hDyxpZWEnUlMkTOo5dNSmC5kT65ZF3znn+Q0tu+V?=
 =?us-ascii?Q?7n+DUZwLjv27NVmtGMnoGK1g/bTU/+D+WyoDF0CN/4WQpXN8FQ7j2NqX2yA2?=
 =?us-ascii?Q?jKIZuSXg1qIewIw9lCFV4TNaADdJwJWyQuIVAdhbPrw74rbWWIOCcj0rShdk?=
 =?us-ascii?Q?sjnXUVhTUMbB+y+CyrR+1ISUNoJJGCEhRfNhVnsIZ9Y6XP9DmxlnwblQamoM?=
 =?us-ascii?Q?p2PDuLJS7mhU32qN4L/PnCUuRLIrRxS1j90RS5Fr+bHYdhS7VU3ZtOCXOa+b?=
 =?us-ascii?Q?MJePFIiMjIr5vY2LmRVKYjbMqLdNiB16TYTOfWZx8PW/EobJLe8/l5t0L1MF?=
 =?us-ascii?Q?IheuXeDho6+2pX9oMoo/e/I126p5rwtmzZHgiCNFMbV9WZPzysG0XmxMSdyk?=
 =?us-ascii?Q?J9ZHvDt6NU+x1mkRgoOiFdNZsSzq0OEB2v1FHM1bS1L8dpvPid8+jL6194kg?=
 =?us-ascii?Q?Ii7lM+GCEeXZlmONaeqZDsci7JT0cWx/BZhvjbiXX276raRg5VurDAZTdh7s?=
 =?us-ascii?Q?ri6NE8+GVbzRTjpgvSBZVn1M3cNMBTfKQNHht4KMJz6lJD88BSx7avnbOO+7?=
 =?us-ascii?Q?fKq02/JFTfK8yCEhc+0InVmH0qEwThnncZ+mKti3+dapKni+DhJ6Yd1RL6yW?=
 =?us-ascii?Q?31wZ2H95jy7VMXHCnOVz5hiZEcT7favlHOioqDYJp7rJAtJiBuu2PQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 731ca3f1-472a-4c4a-1967-08da0b57081f
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 16:22:45.8599
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +Pfw1YbE6xsdSUccUpN41hqocWOLly5UXYXAO/RD7PxsIYKLczCy3wZsXzXNX2m2ysqS20EKeDZhEBuvqMxXPca34SGOURY9Qt8DUX7h1Bo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5568
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10293 signatures=694221
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 spamscore=0
 mlxlogscore=999 phishscore=0 bulkscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203210104
X-Proofpoint-ORIG-GUID: 9eVlIrmUp8knXfxSMLVE7U4B75noplic
X-Proofpoint-GUID: 9eVlIrmUp8knXfxSMLVE7U4B75noplic
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 21, 2022 at 04:00:10PM +0000, David Laight wrote:
> From: Dan Carpenter
> > Sent: 21 March 2022 13:55
> > On Mon, Mar 21, 2022 at 02:34:34PM +0100, Jakob Koschel wrote:
> > > >> @@ -556,11 +556,11 @@ static void *lockres_seq_start(struct seq_file *m, loff_t *pos)
> > > >> 		}
> > > >> 	}
> > > >>
> > > >> -	list_for_each_entry(res, track_list, tracking) {
> > > >> -		if (&res->tracking == &dlm->tracking_list)
> > > >> -			res = NULL;
> > > >> -		else
> > > >> -			dlm_lockres_get(res);
> > > >> +	list_for_each_entry(iter, track_list, tracking) {
> > > >> +		if (&iter->tracking != &dlm->tracking_list) {
> > 
> > This is an open coded version of:
> > 
> > 	if (!list_entry_is_head(iter, &dlm->tracking_list, tracking)) {
> 
> Doesn't list_for_each_entry() terminate before that happens?
> So this code is probably still horribly broken.

There is ! in the condition.  It's just a complicated way of writing
if (!0) { so code works fine, it's just messy.

regards,
dan carpenter