Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 21 Mar 2022 12:28:08 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Veerasenareddy Burru <vburru@marvell.com>
Cc:     <davem@davemloft.net>, <corbet@lwn.net>, <netdev@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Abhijit Ayarekar <aayarekar@marvell.com>,
        Satananda Burla <sburla@marvell.com>
Subject: Re: [net-next PATCH v4 1/7] octeon_ep: Add driver framework and
 device initialization
Message-ID: <20220321122808.427d7872@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20220321055337.4488-2-vburru@marvell.com>
References: <20220321055337.4488-1-vburru@marvell.com>
        <20220321055337.4488-2-vburru@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 20 Mar 2022 22:53:31 -0700 Veerasenareddy Burru wrote:
> Add driver framework and device setup and initialization for Octeon
> PCI Endpoint NIC.
> 
> Add implementation to load module, initilaize, register network device,
> cleanup and unload module.
> 
> Signed-off-by: Veerasenareddy Burru <vburru@marvell.com>
> Signed-off-by: Abhijit Ayarekar <aayarekar@marvell.com>
> Signed-off-by: Satananda Burla <sburla@marvell.com>

Clang says:

drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c:51:19: warning: unused function 'octep_ctrl_mbox_circq_inc' [-Wunused-function]
static inline u32 octep_ctrl_mbox_circq_inc(u32 index, u32 mask)
                  ^
drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c:56:19: warning: unused function 'octep_ctrl_mbox_circq_space' [-Wunused-function]
static inline u32 octep_ctrl_mbox_circq_space(u32 pi, u32 ci, u32 mask)
                  ^
drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c:61:19: warning: unused function 'octep_ctrl_mbox_circq_depth' [-Wunused-function]
static inline u32 octep_ctrl_mbox_circq_depth(u32 pi, u32 ci, u32 mask)
                  ^

Please don't use static inlines in C files, static is enough for 
the compiler to do a reasonable job.

Please fix and repost in 2 weeks we're currently in the merge window
so networking trees are not accepting new drivers.

Thanks.