Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220319181023.8090-1-jagathjog1996@gmail.com> <20220319181023.8090-6-jagathjog1996@gmail.com>
In-Reply-To: <20220319181023.8090-6-jagathjog1996@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 21 Mar 2022 10:45:23 +0200
Message-ID: <CAHp75VeKDpiLo9eJ+578XSqsoRx3YyKuJ4AJJJ3jTQLaENo=Lw@mail.gmail.com>
Subject: Re: [PATCH v1 5/5] iio: accel: bma400: Add step change event
To:     Jagath Jog J <jagathjog1996@gmail.com>
Cc:     Dan Robertson <dan@dlrobertson.com>,
        Jonathan Cameron <jic23@kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Mar 19, 2022 at 8:10 PM Jagath Jog J <jagathjog1996@gmail.com> wrote:
>
> Added support for event when there is a detection of single step
> or double step change. INT1 pin is used to interrupt and event
> is pushed to userspace.

...

>  #include <linux/iio/trigger.h>
>  #include <linux/iio/triggered_buffer.h>
>  #include <linux/iio/trigger_consumer.h>
> +#include <linux/iio/events.h>

Keep this block ordered,

...

> +       switch (chan->type) {
> +       case IIO_STEPS:
> +               switch (type) {
> +               case IIO_EV_TYPE_CHANGE:
> +                       return data->steps_enabled;
> +               default:
> +                       return -EINVAL;
> +               }
> +       default:
> +               return -EINVAL;
> +       }

> +       return 0;

Dead code.

...

> +       case IIO_STEPS:
> +               switch (type) {
> +               case IIO_EV_TYPE_CHANGE:
> +                       mutex_lock(&data->mutex);
> +                       ret = regmap_update_bits(data->regmap,
> +                                                BMA400_INT12_MAP_REG,
> +                                                BMA400_STEP_INT_MSK,
> +                                                FIELD_PREP(BMA400_STEP_INT_MSK,
> +                                                           state));
> +                       mutex_unlock(&data->mutex);
> +                       if (ret)
> +                               return ret;
> +                       data->steps_enabled = state;
> +                       return 0;
> +               default:
> +                       return -EINVAL;
> +               }
> +       default:
> +               return -EINVAL;
> +       }

> +       return 0;

Ditto.

-- 
With Best Regards,
Andy Shevchenko