Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Stephen Brennan <stephen.s.brennan@oracle.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        viro@zeniv.linux.org.uk
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] namei: make filename_parentat static
In-Reply-To: <20220317014859.4292-1-jiapeng.chong@linux.alibaba.com>
References: <20220317014859.4292-1-jiapeng.chong@linux.alibaba.com>
Date:   Mon, 21 Mar 2022 11:27:28 -0700
Message-ID: <87sfrb40vj.fsf@stepbren-lnx.us.oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dG5TZVphUG95ZTVwYlFqbnBFUUJ1TjRBaGk3MFBvdmM2ZHY5MisvSGNJMkJQ?=
 =?utf-8?B?ckI4MlR6V3RKclB4bnRRd3J3T0hJTW44STFTTjB3MEV4STVDVFFsa2JkU0pB?=
 =?utf-8?B?bFd5UStSdkdtZnVtWExkM2g4QTdnQUFaYi96Mlk3aVFCbTFwbDRUTXV0R1dv?=
 =?utf-8?B?SkFwMDk5NlRFT0VUb3p6b3VKbXg3S0xoK2QvK0t3Q3ZaR2VEYmdlY3lKS3Ny?=
 =?utf-8?B?S0E5a1M5aU9wazkvZjVWSnhBSHBpNTNaVmZiTzIxTXdRM0h2cVBIQ0NRMjYw?=
 =?utf-8?B?cTR2TzY5aGNUYVg1TU0vbVlpZXN1M0dQNzVYUy9DRDV2dkxmb2pxcnc5Q1lB?=
 =?utf-8?B?OVQwcDNhd2Nhc1dkNVRVLytXemJ0QWMrbHdMUmJvaTV2eTJkb3IvaDhqcGRV?=
 =?utf-8?B?RncwYXFKdUhLZmgwYlQrUnhTM1hhRGZPVXM1NXVZbzdVUWhHazhmcVpMcEtB?=
 =?utf-8?B?a3hzb0EyTG1rTHF0UHNWZTZueGhPMnFsT243K3lLdUoxckdKR2I0cGozVUEr?=
 =?utf-8?B?M1NmV3hYZmE4cnVTQVBZQ3lneTlRaW5aSlNyS1FmMEd3RFIvSklmd2ZwT00y?=
 =?utf-8?B?MUtCVmZYelMrNHBjQ3dIMkNCSDRETWsvYlVRdHJqQWl4bTFXRzdObFZaa0xH?=
 =?utf-8?B?QkFUNC91L3UrN0ZkVW5JMWVVQnhNQnpsRXhvREdlZTlHS3lUc0pkci9tZ0xk?=
 =?utf-8?B?c1JnK1lQaTRMbUpSd0o0RVNvZHNHaVc4K2FCYlU1a003Q0hub2gzYmZZS0Nw?=
 =?utf-8?B?aHMrY0hLNVR3cDhLRFJCeXBUKzhJLzV1Qkx3M2pqdmFDd3M3eWZKalBBMytK?=
 =?utf-8?B?ZTFPRUF2eFh2R2YrUUZwb3ZrZERWbjlrWlFBQWl6UWxtTnhvZEhQRzVjcmFl?=
 =?utf-8?B?UTNEckpVV0htbHhiamEyNVF6b2ZmWGRhaVlJVjdHbUFxT200aUd2VDIybytS?=
 =?utf-8?B?UTU4cWdEdFNRNVZqMzJIVi9kKzI4NkVFRHl0UjJWTG1ON2U2cVBtelVBbzRq?=
 =?utf-8?B?WUlEdUpZa08zTUwxeDVrbWVWQ2lBMzNUVlF0V3BHa1lXRExVK2xuam9iMHMx?=
 =?utf-8?B?ZG9nRUI1OHgrQXhNTUd2SlRTWmVoY1VoeVF3MGxSczZqSXJLVlNKekp4MXl1?=
 =?utf-8?B?MXI3bUs3bDZ1bXV2cUJIckcxSUtwbmFsVmdiRFBRalc0aVg3Tlh5ZzdRYzBr?=
 =?utf-8?B?WFhSck01R1VTNzZuOUthTHY0emdzQk9Wa3MxYTBISTNKQTFqNllod20xc1B2?=
 =?utf-8?B?WndzM2s5emgraUsxN2h0UVU3R2JPQ041dEM1dzAzdHNKdG04T2xUQVVHUnpF?=
 =?utf-8?B?VjZkMzF2RnpGWGZEaCtOVGZWMFRBaTJkbkdxN1BZZnIvOWJMclNTS1ByY0kx?=
 =?utf-8?B?SE9CdXhjSXBQb2JKaEV6bHQ2dEJFQmFPb3YyK2MzOW1TZ3BXRHpZb2p3cU9u?=
 =?utf-8?B?b0cxM1FnVS91c3FDMEhKbC9nUW5CaWZ4RklpSWwwckloTG9pY3ZNdDF3OUFW?=
 =?utf-8?B?ZFhDSERXc0JFZi9mVHE3dWUyUWo5WjdsN2puSTVOUEV6WEtJblc3NzA1cnpk?=
 =?utf-8?B?MFlZdkxGdnVGQ1hNOWs0TzBBUUFYaXFmbUdGZzBHNkFJZlJ1YU1IU2QwKzZW?=
 =?utf-8?B?SXRkb3VqMlp0VGtLNnNXSEhLRDY2NVVVL2hkaHpDWUpmU25iSmNXZ0RzMFJx?=
 =?utf-8?B?aEdnRCtHTXR2UTdSRUEvVXpjdEpuVVJQajJrTElYcXUzTDJvMUJGVWRZQ2N3?=
 =?utf-8?B?Q3pjOWtLMmZoRGt3ZWVTcWlEdkdoKzliSVdobDZPUkNNMG9JSCtGVENwWmEx?=
 =?utf-8?B?dXA2SVpSSXloMkZIZDltTCtIMjNhbEtvOFpsaFdRZUJRcXcwSi9LbmRQRFVY?=
 =?utf-8?B?a1FCaGNYc3N1cmE0NkhQc3g1L3R6bkNIdUN0QWJ6aENBN1NmcGw3b1J3SlRu?=
 =?utf-8?B?SXhzK0ZMRzkyRkVlUEVIYkwzdHMvSkE5QS9GUTRaUFRzNVhLYUFTYWJXOTd1?=
 =?utf-8?B?YWErL3N5eGlBPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3d3698d-a744-4783-aabd-08da0b6876bc
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4166.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 18:27:32.5738
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VbpwJW4HS8LWRMX7s1UA1eQjuMWjyoCvgIhkCNwy1I3qKAAlPL9TdmeQNJV2NzbObF1MAV2Sxrw5spm6AlSomYc81qzlfPyoFAhoO1SXNjo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1281
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10293 signatures=694221
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 suspectscore=0 malwarescore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203210117
X-Proofpoint-GUID: BRgbSX7G1VMPVvNTV8fsUcVwYEgEAYaK
X-Proofpoint-ORIG-GUID: BRgbSX7G1VMPVvNTV8fsUcVwYEgEAYaK
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Jiapeng Chong <jiapeng.chong@linux.alibaba.com> writes:
> This symbol is not used outside of namei.c, so marks it static.
>
> Fix the following w1 warning:
>
> fs/namei.c:2587:5: warning: no previous prototype for
> =E2=80=98filename_parentat=E2=80=99 [-Wmissing-prototypes].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  fs/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/namei.c b/fs/namei.c
> index 44c366f3152f..fe3525807361 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -2584,7 +2584,7 @@ static int __filename_parentat(int dfd, struct file=
name *name,
>  	return retval;
>  }
> =20
> -int filename_parentat(int dfd, struct filename *name, unsigned int flags=
,
> +static int filename_parentat(int dfd, struct filename *name, unsigned in=
t flags,
>  		      struct path *parent, struct qstr *last, int *type)
>  {
>  	return __filename_parentat(dfd, name, flags, parent, last, type, NULL);

You must have based this on something other than the latest upstream
tree. Currently on v5.17 we have:

2559 static int filename_parentat(int dfd, struct filename *name,
2560 			     unsigned int flags, struct path *parent,
2561 			     struct qstr *last, int *type)

Regards,
Stephen

> --=20
> 2.20.1.7.g153144c