Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2312569pxp; Mon, 21 Mar 2022 16:38:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyo9/vQoiVMpFZUJbpdHMmNwgk8OjLkUAvwGJAO8ODqPqUK1fP3BKTFegdwYeW0B08bV9kR X-Received: by 2002:a05:6a00:9aa:b0:4fa:964f:9024 with SMTP id u42-20020a056a0009aa00b004fa964f9024mr9013049pfg.12.1647905911029; Mon, 21 Mar 2022 16:38:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647905911; cv=none; d=google.com; s=arc-20160816; b=T8ONa6CxZBZ47TLgq1JJLOO7iv3UN4Ar5/MG5KJ1xXpXYn6a882QwG0CFMpvmBVVgm akCOrKtWf2ZVn2u72FWS+ojeVz/H3wnsM/jBN8vWeui+83d27+FWintWpfpm9yzwQcSo 9PDkqplEy9/w+NjYHkt9w2E47jiS8olHHuFoWPh2ZrEvBGqlTx8tcXu9jRQiqrjeXwZT BuY4Pl66n/GDbi0etb/y4DxkvS4QC6DVJI0NnMviMlP9hrUdDlWg7iG68G5UlcSpxM/n /M6NmtOWgJNPT2DdwLRHRnleVJX0HM97inBp2mHJkk8vxTFamgK6x2WEMOPVu3DWEMts bsEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Pu9sP3Vp2j3gOE49BQ2QfPCjG4QbaWJACH5l1dVezI4=; b=SR/HY5GxqgtO8KhDmOXyqmOBanNCOMPBPFqSIcImj1jz+MFAMZrJwjDX5tw+I+TNZI PkGsYzBsVfxL5QbOcjUp0jUCGndTmazfEq6hMGu2h+Vwzra+8l+UrJ56UvBHd0MVz42Z BIOZCKvxtwlIouGavBIDbhgLFxV/49je/iIodQBIdhGM9CjbBqoqDfdQ3Tg4dOOHV7RF NefgE3NBmR/Ev4ZYdVRJGFtnPh0gjuwmCXyE390wiLDJDOm/1G0mzk/dw21Jc8ir8uUX M+6+1Q1n5ZaUM5um0dIYl365U2hv17kBAZuUk5qVQJ2rIobSls07KOr0oPKmURNLaYvs IYHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SLjoLzMs; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id a20-20020a056a001d1400b004fa3a8e004csi7316236pfx.259.2022.03.21.16.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 16:38:31 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SLjoLzMs; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3175942C41B; Mon, 21 Mar 2022 15:52:34 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230333AbiCUWxY (ORCPT + 99 others); Mon, 21 Mar 2022 18:53:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230330AbiCUWxQ (ORCPT ); Mon, 21 Mar 2022 18:53:16 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6808F3C8AFF; Mon, 21 Mar 2022 15:32:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4CD2CB819FE; Mon, 21 Mar 2022 21:26:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35EB8C340E8; Mon, 21 Mar 2022 21:26:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647898008; bh=MdFVdpU9BRlhC7Gxb+jB5c2HWKX2X/KfKn/uOM/qpiE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SLjoLzMsOepdgVQIUkD155E5Lv55uy4SxBqRQjREUvxi64ef+SR6i/X6QLx0XX3hq u/Abo0XBjstS3FnpI+jMs1dIVs1Jb3qIIvYYbOL24vW8qsK7iKtuEjDvHbBAo+JY28 4hKPJWksHKgboXCrZJz+lJjb06PDnEA9LpEJTJ5XWrWBv6kL4+jv4N8aM6fqGVb+Pb H4xNx9ptFyCNwuKTg7hyJi/A6VbawiG5/Rqi5fkc69HnVTfO9rDC3VPNo9fDaXQ+K1 UKki2tLUjqoju+7pLD84rTGAAQTZHnOsssm7A8IGfgNQLg4Wir3Fp52qsjpKr0V22v GaBbEUjG9NWug== Date: Mon, 21 Mar 2022 14:26:45 -0700 From: Jakub Kicinski To: Florian Fainelli Cc: Jeremy Linton , netdev@vger.kernel.org, opendmb@gmail.com, davem@davemloft.net, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, Peter Robinson Subject: Re: [PATCH] net: bcmgenet: Use stronger register read/writes to assure ordering Message-ID: <20220321142645.38b8a087@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <0465ecd0-0cd7-1376-51bf-38aa385c128a@gmail.com> References: <20220310045358.224350-1-jeremy.linton@arm.com> <0465ecd0-0cd7-1376-51bf-38aa385c128a@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Mar 2022 12:04:34 -0700 Florian Fainelli wrote: > On 3/9/22 8:53 PM, Jeremy Linton wrote: > > GCC12 appears to be much smarter about its dependency tracking and is > > aware that the relaxed variants are just normal loads and stores and > > this is causing problems like: > > Fixes: 69d2ea9c79898 ("net: bcmgenet: Use correct I/O accessors") > > Reported-by: Peter Robinson > > Signed-off-by: Jeremy Linton > > Acked-by: Florian Fainelli Commit 8d3ea3d402db ("net: bcmgenet: Use stronger register read/writes to assure ordering") in net now, thanks!