Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Subject: Re: [PATCH 1/1] drivers: hwmon: jc42: add HWMON_C_TZ_REGISTER
Date:   Mon, 21 Mar 2022 16:44:55 -0700
From:   Eduardo Valentin <eduval@amazon.com>
To:     Guenter Roeck <linux@roeck-us.net>
CC:     Eduardo Valentin <eduval@amazon.com>,
        Jean Delvare <jdelvare@suse.com>,
        <linux-hwmon@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        "Eduardo Valentin" <evalenti@kernel.org>
Message-ID: <20220321234455.GB3248@uf8f119305bce5e.ant.amazon.com>
References: <20220318233011.13980-1-eduval@amazon.com>
 <9cec7367-e6ec-5fe4-94ce-c908452c9385@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <9cec7367-e6ec-5fe4-94ce-c908452c9385@roeck-us.net>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Sat, Mar 19, 2022 at 06:01:27PM -0700, Guenter Roeck wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
> 
> 
> 
> On 3/18/22 16:30, Eduardo Valentin wrote:
> > Add a thermal zone interface to the devices added
> > under jc42 driver. This way, thermal zones described
> > in device tree can make use of the of nodes of these
> > devices.
> > 
> 
> Makes sense. I'll apply the patch, but it is a functional change
> and a bit too risky to include in the upcoming commit window.
> I'll apply it after the commit window closes.

Thank you Guenter. Yeah, this can go on the next window.

> 
> Thanks,
> Guenter
> 
> > Cc: Guenter Roeck <linux@roeck-us.net> (maintainer:JC42.4 TEMPERATURE SENSOR DRIVER)
> > Cc: Jean Delvare <jdelvare@suse.com> (maintainer:HARDWARE MONITORING)
> > Cc: linux-hwmon@vger.kernel.org (open list:JC42.4 TEMPERATURE SENSOR DRIVER)
> > Cc: linux-kernel@vger.kernel.org (open list)
> > 
> > Signed-off-by: Eduardo Valentin <eduval@amazon.com>
> > Signed-off-by: Eduardo Valentin <evalenti@kernel.org>
> > ---
> >   drivers/hwmon/jc42.c | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
> > index cb347a6bd8d9..f40df2f29d41 100644
> > --- a/drivers/hwmon/jc42.c
> > +++ b/drivers/hwmon/jc42.c
> > @@ -443,6 +443,8 @@ static int jc42_detect(struct i2c_client *client, struct i2c_board_info *info)
> >   }
> > 
> >   static const struct hwmon_channel_info *jc42_info[] = {
> > +     HWMON_CHANNEL_INFO(chip,
> > +                        HWMON_C_REGISTER_TZ | HWMON_C_UPDATE_INTERVAL),
> >       HWMON_CHANNEL_INFO(temp,
> >                          HWMON_T_INPUT | HWMON_T_MIN | HWMON_T_MAX |
> >                          HWMON_T_CRIT | HWMON_T_MAX_HYST |
> 

-- 
All the best,
Eduardo Valentin