Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jean-Philippe Brucker <jean-philippe@linaro.org>,
        Lu Baolu <baolu.lu@linux.intel.com>
CC:     Joerg Roedel <joro@8bytes.org>, Jason Gunthorpe <jgg@nvidia.com>,
        Christoph Hellwig <hch@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Eric Auger <eric.auger@redhat.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH RFC 08/11] iommu: Handle IO page faults directly
Thread-Topic: [PATCH RFC 08/11] iommu: Handle IO page faults directly
Thread-Index: AQHYPCXDh2h0i76XWk2TXkPzYVpKc6zJt0cAgADZqqA=
Date:   Tue, 22 Mar 2022 00:39:23 +0000
Message-ID: <BN9PR11MB527618AE2998043E84D7B5768C179@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220320064030.2936936-1-baolu.lu@linux.intel.com>
 <20220320064030.2936936-9-baolu.lu@linux.intel.com> <YjhjCsrcTNDsFRwm@myrica>
In-Reply-To: <YjhjCsrcTNDsFRwm@myrica>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9pTiSbcu+JMTGnteWevpoef1vRAa8a3RgrZMxEEZoV5GZ7YU1E2bQGQISzUq?=
 =?us-ascii?Q?AoDEyT7efw5VI6TT3rsCHAw0tadTpNnh3k6wgx62f3DJAJzslfvzDfwlassb?=
 =?us-ascii?Q?mdNV7U6On7BKQQZkea+S1QW2xQfXm+DUv4LqzbMo3wsXlWWI94Gp0NIT5ow4?=
 =?us-ascii?Q?dgVv16iIpea2nCzlcRr4EZTE/pBj2JnoYP+HHF2Ru0GHZ2P9mzjG+e2I8ro7?=
 =?us-ascii?Q?p5MXHclVUYjqOMJSpmnAWYlTdAh9DCriC6wWqhtYfIuSpKbHPTLm28htGwFE?=
 =?us-ascii?Q?i7KAwm9rJILvtHLJkYRhnxSedn1vYSm+Hl71iJ+N3g87CRxZqnMD8Kv1jt/7?=
 =?us-ascii?Q?PxGNbJNJgcJi+UhsTTKFdfD1vOLTDK3f5nFEWSAKDwXzJzHHsyWUm9n+hQAw?=
 =?us-ascii?Q?ntWeoHxRmmqV642IRD7wc2uQOosw2hQCGfXJ8eyVJh7YWa5AzVfXcsUXurL7?=
 =?us-ascii?Q?JaCKvZX5Z/b7awFGFURDM4RVZ/v2rbLd10DhGvfYuS7JHmz+53yD45yZYRPg?=
 =?us-ascii?Q?A9llneo6Rsmxd3iY2/0ET+x2nBgF09xKEgf1qFDmJ67CHKtPSOmtxsIA9e44?=
 =?us-ascii?Q?7vrhAdJ9dXgny6KBIaMFFrjtfg9LpA6FT5uWH4N/BO0hPRQ9YrHmmf0dbVN2?=
 =?us-ascii?Q?veqqWjYnW8IpP5ilIodpfjdtZqo9d8uCtEdP7Kmpt0OeKdkp8ii52gtcmT9K?=
 =?us-ascii?Q?6eLmL51v/5zlX8RXT3uLZSdelt/jknghP/hwkfZa7yHb7zLGwO7+IgTyBuKd?=
 =?us-ascii?Q?UjrGFlfrvfOgqQRIUY1R+NfGp2I4I7ZPUVBg+jwEoSc8Tsjn0gNrSF7ciV13?=
 =?us-ascii?Q?XoI2XYPu0c3xxbR53IK1vuqjzfu/JVMOsAsTrQc8ha5bXIs46YpbsqUV3P4b?=
 =?us-ascii?Q?EfDwe6IV49xpnXNXLqO0XqbDYcV7Osj/4EgTHAdBZP7BqTVLSBByEzyYEYLb?=
 =?us-ascii?Q?G18H8zc8xMrzm6fYEj5VnkfNpcbtrJfLVC9gGCfOjlgJsoHDZwjhKNcR3ern?=
 =?us-ascii?Q?C/3SmZ+ExwXtF4N/CMfroQ11iTygKDJzPzZRRxkE0kJV/7QbReK7TwGVVqQX?=
 =?us-ascii?Q?uMP5vqsZUKfZ1zEsANKSpDCrKIEDiqPQVP/a8yNnTGm/52fxG3RX1fR1yg7j?=
 =?us-ascii?Q?T+raKVWaWLFs70Tnk6RbfmuRkxx+5LjA1XqXcpX9CCijcmp709rtR6lzEwnK?=
 =?us-ascii?Q?np7aLNt0gORVxMAdm6FlDUTbRcBAmp5YytqHTo8hjm/oChMHZsKjCrbLXL+G?=
 =?us-ascii?Q?wa3b6w+uoGykiyCmaWI6xR3hl7+wwhHQDjyR7+MyB8V95xd5XTTNKvr+hZkj?=
 =?us-ascii?Q?Bk+Cg0cdn5GJwGyVeFidaJo8b1qUP05w+VAeqZOeDpO+xoNTIRv7Fh/1Rao+?=
 =?us-ascii?Q?ThJWS/2O1knMWUh7UoK71HaYZPRe8rNmyU3ZUv4I/DUnX+opzWaLI7+xEG1r?=
 =?us-ascii?Q?0o39C04fqE5w8O3YgtF3vTk3WhNVVMBw?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f7b5ede4-d92a-44d8-372d-08da0b9c6915
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2022 00:39:23.1367
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gXC7JDCjTvTAuHvgSMrvpwrONFRiSBWMjBILlJoBrbhSCrF/uWaSnwDAqZqr16Xpe9EnWw3NZ0f/4EpHoahEjw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4218
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Sent: Monday, March 21, 2022 7:36 PM
>=20
> On Sun, Mar 20, 2022 at 02:40:27PM +0800, Lu Baolu wrote:
> > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> > index c0966fc9b686..4f90b71c6f6e 100644
> > --- a/drivers/iommu/iommu.c
> > +++ b/drivers/iommu/iommu.c
> > @@ -27,6 +27,8 @@
> >  #include <linux/cc_platform.h>
> >  #include <trace/events/iommu.h>
> >
> > +#include "iommu-sva-lib.h"
> > +
> >  static struct kset *iommu_group_kset;
> >  static DEFINE_IDA(iommu_group_ida);
> >
> > @@ -1177,10 +1179,9 @@ int iommu_report_device_fault(struct device
> *dev, struct iommu_fault_event *evt)
> >  	if (!param || !evt)
> >  		return -EINVAL;
> >
> > -	/* we only report device fault if there is a handler registered */
> >  	mutex_lock(&param->lock);
> >  	fparam =3D param->fault_param;
> > -	if (!fparam || !fparam->handler) {
> > +	if (!fparam) {
> >  		ret =3D -EINVAL;
> >  		goto done_unlock;
> >  	}
> > @@ -1198,7 +1199,11 @@ int iommu_report_device_fault(struct device
> *dev, struct iommu_fault_event *evt)
> >  		mutex_unlock(&fparam->lock);
> >  	}
> >
> > -	ret =3D fparam->handler(&evt->fault, fparam->data);
> > +	if (fparam->handler)
> > +		ret =3D fparam->handler(&evt->fault, fparam->data);
> > +	else
> > +		ret =3D iommu_queue_iopf(&evt->fault, fparam->data);
> > +
>=20
> I like the change, but we'll need to consolidate this, because now if the
> driver registers a fault handler it disables IOPF. We could instead
> prevent registration if an IOPF param is present. We could also just merg=
e
> fparam->handler but eventually I'd like to make IOPF fall back to the
> fault handler registered by device driver, in case of invalid page faults=
.
> I have a couple patches for this but am still missing some bits.
>=20

Probably we need two different fault reporting interfaces:

  iommu_report_device_fault()
  iommu_report_domain_fault()

iommu driver knows the type of faults and just calls individual API
accordingly. fallback is also managed by iommu driver if necessary.

Thanks
Kevin