Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2443843pxp; Mon, 21 Mar 2022 20:39:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPwWfDfWDV3C4zHRA6VDTWlPGK4o6vdD/ZGkQvQ/WSGZpcX0yWQph/rRYkOlIH75ZOu7tn X-Received: by 2002:a17:903:404b:b0:154:297b:7125 with SMTP id n11-20020a170903404b00b00154297b7125mr15095762pla.11.1647920366917; Mon, 21 Mar 2022 20:39:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1647920366; cv=pass; d=google.com; s=arc-20160816; b=BAzH51+uY893xtoOzSYqIDtpJvQDjJVUGtYtQ6JdRBOqZebxbiNBPpmoh/0aNFPlMA YqTg6TsYGUQJAt67IDastAf5eu81dmBziZ3bR5pR2VAEeL71YBSgaf3urKAAmLHeVH+H jSUAwK52DcW6oKo6ehv/4MEp+b3XSwO1ytfD/VBUJtf6zxAzv7w2b/XGHzxOyJTaMd5P xZFqLgBQTlxE7uS1hwafQJuIBNPJQUBvSQs//kL4o4uuOFHYCDs2u8b6XqknVV2otK3v jqe8LlFXyKeFE9i+qs4uKL5frv8AgQ4Wc5SiunDJ/nBRUWe4ydCXwgtC2U+4xaba+F8T r6Vg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:dkim-signature; bh=SDRgY4hCcw5IyJP6ZI91B9IoNIRgIUTKVFMsD2qfdRk=; b=fRnKVCDbdCa9aCLgnHF7wwnwoXHgi7AWS1SQ55E35e4ZiZRL1LciPs5CP+lVmPBapI y5zlXK90XYv0IYChBDJGlSKYJXftqvhTX06DhB/sNGCsUflWpbCMn4yKwK0M654I18k1 ItGWi1uCnJ1dZi587lCCUi/U6WQHwPdO0LNppRcIs+cYC1+mVvJHyp9RH7tZWTYES670 ww2DFjOjsTzgapsIGmXkfRCCR74vddQHIiCbhRIZ8sB/bBjPXlEkAH+Eio/Q8Vtw/dnv ukLn2F82bIt5h95yiPrPquXDEBR63yLXAbaw0SNjHtho+ukP8FuX9JMehkHh7ypV1LHC j6rQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@stgolabs.net header.s=dreamhost header.b=ZroK2pC8; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id e15-20020a65678f000000b00383884f1eeesi1255416pgr.269.2022.03.21.20.39.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 20:39:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@stgolabs.net header.s=dreamhost header.b=ZroK2pC8; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DF58B47568; Mon, 21 Mar 2022 20:07:10 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235995AbiCVDI0 (ORCPT + 99 others); Mon, 21 Mar 2022 23:08:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235991AbiCVDIZ (ORCPT ); Mon, 21 Mar 2022 23:08:25 -0400 X-Greylist: delayed 559 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 21 Mar 2022 20:06:56 PDT Received: from crane.ash.relay.mailchannels.net (crane.ash.relay.mailchannels.net [23.83.222.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E47939690 for ; Mon, 21 Mar 2022 20:06:55 -0700 (PDT) X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 195B0800DEE; Tue, 22 Mar 2022 02:57:33 +0000 (UTC) Received: from pdx1-sub0-mail-a295.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 05E17800E65; Tue, 22 Mar 2022 02:57:32 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1647917852; a=rsa-sha256; cv=none; b=OpX/wT83WSUgkwuyqo+AX183ZF64agEolIpgS5YaHhEw+K5Z5HdloR1lKnlVv6tLbessRM cgwpsu3lSwUJYEjZwzjLR+TWW2zvxqDLFMJnEsriR9WrnLyIy+yRrhFRGhktfzLWVBDbU/ nst71cZedfBM0b354icqNabdXWG7ppuH53O67CUwlBuADn1ldo0cv3TffoR+mJcovapUok CTSdlHQC7biMgfqvsW9yEzja/6S6JJsrOyrcxnjfUYc79JP/qMaGpkthwXHk0JFY7C99f0 jQfS5UzqyXU6VpUy6U0bomHKQcPzoQYpZOeV/K+jPHEsY2woRC0FSycbWtbpHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1647917852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SDRgY4hCcw5IyJP6ZI91B9IoNIRgIUTKVFMsD2qfdRk=; b=CuIXw+6epD9n3Q+3WuIKBbuh+kRU4d+NMYi5nnCcsDAspzmVy7hYMofjScXYZ7DmqBB14Q EXWzxT+genBBJaGYbIUY22K7LydDAgMIJ1Dwyx8/lJdBpfHLhagwmHcGyQitCGgmR+5hz4 w6XMcXzk6lahpAwNlc5kbWSifSt/ERGHbe5SR+h7NeKFPFJ11wN6ZJjxNc5Of+o2BDtdQQ BOqxnwdOrY86JdjHx9E8VMheV1e8I9sujZm3rZTp8RGH1mIjwrsZd3ZmqRCQVpUwNlBWXh nouyDEr2B+ThmaRmTrve0Vl7T/ySxjEskJPwRC//jCgQO5zq4t8SdRCMWUcVoA== ARC-Authentication-Results: i=1; rspamd-74bfb75fc6-dqqqm; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from pdx1-sub0-mail-a295.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.121.210.153 (trex/6.5.3); Tue, 22 Mar 2022 02:57:33 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Glossy-Thread: 2b8b6da7311fbb33_1647917852452_1069914907 X-MC-Loop-Signature: 1647917852451:2066250030 X-MC-Ingress-Time: 1647917852451 Received: from offworld (unknown [104.36.25.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a295.dreamhost.com (Postfix) with ESMTPSA id 4KMx3s4gbMz3f; Mon, 21 Mar 2022 19:57:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1647917851; bh=SDRgY4hCcw5IyJP6ZI91B9IoNIRgIUTKVFMsD2qfdRk=; h=Date:From:To:Cc:Subject:Content-Type; b=ZroK2pC8DsKo78Rr0oYJm5AKcTKhlJq8fuI5kDFImQeZG8OpdaZdgtMKnVF6YyeIw vrG7aUVDDlLMyK1Avt0J3Q3nb5MS6p3icwP/XxcWoVZ/zYN06R5q2gAm6Q5T1/4Agh iVHLtPeC0UrzHe4XtjIzYufm+YiL/ZjKh8+daF3Pg5UVC4Mm3vU29PYygc81DlKEok EVhVtf0F+HxuXufstBjni/DdzHFuqG70PIPcto4MzvpGBZSJlm0waWlG01tRHG2a1L vR4+5e9zq4dAnqFKobDNmRWctorBX6mci0CFpslaPGNzhbuyeyDDbqDd2YoEGerkYD /2R3fmoTk0a/g== Date: Mon, 21 Mar 2022 19:57:24 -0700 From: Davidlohr Bueso To: Nico Pache Cc: Michal Hocko , linux-mm@kvack.org, Andrea Arcangeli , Joel Savitz , Andrew Morton , linux-kernel@vger.kernel.org, Rafael Aquini , Waiman Long , Baoquan He , Christoph von Recklinghausen , Don Dutile , "Herton R . Krzesinski" , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Andre Almeida , David Rientjes Subject: Re: [PATCH v5] mm/oom_kill.c: futex: Close a race between do_exit and the oom_reaper Message-ID: <20220322025724.j3japdo5qocwgchz@offworld> Mail-Followup-To: Nico Pache , Michal Hocko , linux-mm@kvack.org, Andrea Arcangeli , Joel Savitz , Andrew Morton , linux-kernel@vger.kernel.org, Rafael Aquini , Waiman Long , Baoquan He , Christoph von Recklinghausen , Don Dutile , "Herton R . Krzesinski" , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Andre Almeida , David Rientjes References: <20220318033621.626006-1-npache@redhat.com> <20220322004231.rwmnbjpq4ms6fnbi@offworld> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20201120 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Mar 2022, Nico Pache wrote: >We could proceed with the V3 approach; however if we are able to find a complete >solution that keeps both functionalities (Concurrent OOM Reaping & Robust Futex) >working, I dont see why we wouldnt go for it. Because semantically killing the process is, imo, the wrong thing to do. My performance argument before however is bogus as the overhead of robust futexes is pretty negligible within the lifetime of a lock. That said, the users still have good(?) reasons for not wanting the lock holder to crash on them. Thanks, Davidlohr