Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Mime-Version: 1.0
Subject: RE: [PATCH 1/1 module-next] kallsyms: enhance %pS/s/b printing when
 KALLSYSMS is disabled
Reply-To: maninder1.s@samsung.com
Sender: Maninder Singh <maninder1.s@samsung.com>
From:   Maninder Singh <maninder1.s@samsung.com>
To:     Sergey Senozhatsky <senozhatsky@chromium.org>
CC:     "mcgrof@kernel.org" <mcgrof@kernel.org>,
        "pmladek@suse.com" <pmladek@suse.com>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>,
        "linux@rasmusvillemoes.dk" <linux@rasmusvillemoes.dk>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "wangkefeng.wang@huawei.com" <wangkefeng.wang@huawei.com>,
        Vaneet Narang <v.narang@samsung.com>,
        "swboyd@chromium.org" <swboyd@chromium.org>,
        "ojeda@kernel.org" <ojeda@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
        "avimalin@gmail.com" <avimalin@gmail.com>,
        "atomlin@redhat.com" <atomlin@redhat.com>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "ndesaulniers@google.com" <ndesaulniers@google.com>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "void@manifault.com" <void@manifault.com>
Message-ID: <20220322062219epcms5p1bc1cc758470ebf175aa4eee20b7837ae@epcms5p1>
Date:   Tue, 22 Mar 2022 11:52:19 +0530
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <CGME20220316043552epcas5p29b0723b7c55a3bcc9b4d858660e45933@epcms5p1>
Precedence: bulk

Hi=C2=A0Sergey,=0D=0A=C2=A0=0D=0A>=C2=A0>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if=C2=
=A0(add_offset)=C2=A0=7B=0D=0A>=C2=A0>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0base=C2=A0=3D=C2=A0mod->core_layout.=
base;=0D=0A>=C2=A0>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0offset=C2=A0=3D=C2=A0value=C2=A0-=C2=A0(unsigned=C2=A0=
long)base;=0D=0A>=C2=A0>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=7D=0D=0A>=C2=A0=0D=
=0A>=C2=A0What=C2=A0if=C2=A0address=C2=A0is=C2=A0in=C2=A0module=C2=A0init?=
=C2=A0Shouldn't=C2=A0this=C2=A0be=C2=A0something=C2=A0like=0D=0A>=C2=A0=0D=
=0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if=C2=A0(within_m=
odule_init(value,=C2=A0mod))=0D=0A>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0offset=C2=A0=
=3D=C2=A0value=C2=A0-=C2=A0(unsigned=C2=A0long)mod->init_layout.base;=0D=0A=
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0else=0D=0A>=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0offset=C2=A0=3D=C2=A0value=C2=A0-=C2=A0(unsigned=C2=A0lon=
g)mod->core_layout.base;=0D=0A=C2=A0=0D=0AYes,=C2=A0this=C2=A0can=C2=A0be=
=C2=A0done,=C2=A0but=C2=A0I=C2=A0think=C2=A0then=C2=A0we=C2=A0need=C2=A0to=
=C2=A0handle=C2=A0it=C2=A0with=C2=A0some=C2=A0more=C2=A0info.=0D=0A=C2=A0=
=0D=0AIn=C2=A0module=C2=A0allocation=C2=A0first=C2=A0we=C2=A0load=C2=A0core=
_layout=C2=A0and=C2=A0then=C2=A0init_layout=C2=A0w.r.t=C2=A0address=C2=A0ra=
nge=0D=0Aas=C2=A0below=C2=A0(ARM64):=0D=0A=C2=A0=0D=0Affff800000eb0000=C2=
=A0->=C2=A0core_layout=0D=0Affff800000eb4000=C2=A0->=C2=A0init_layout=0D=0A=
=C2=A0=0D=0A=C2=A0=0D=0ASo=C2=A0if=C2=A0we=C2=A0write=C2=A0only=C2=A0offset=
(w.r.t=C2=A0core_layout),=C2=A0then=C2=A0user=C2=A0can=C2=A0get=C2=A0a=C2=
=A0hint=C2=A0if=C2=A0it=C2=A0going=C2=A0beyond=C2=A0normal=C2=A0text=0D=0At=
hen=C2=A0it=C2=A0means=C2=A0it=C2=A0is=C2=A0init=C2=A0text.=0D=0A=C2=A0=0D=
=0ABut=C2=A0if=C2=A0we=C2=A0take=C2=A0offset=C2=A0from=C2=A0init=C2=A0and=
=C2=A0core=C2=A0separately,=C2=A0and=C2=A0we=C2=A0only=C2=A0print=C2=A0the=
=C2=A0offset=C2=A0(not=C2=A0function=C2=A0name),=0D=0Awe=C2=A0need=C2=A0to=
=C2=A0write=C2=A0alongwith=C2=A0offset=C2=A0that=C2=A0it=C2=A0is=C2=A0init=
=C2=A0or=C2=A0core=C2=A0area.=0D=0AOtherwise=C2=A0user=C2=A0will=C2=A0get=
=C2=A0confused=C2=A0which=C2=A0offset=C2=A0it=C2=A0is,=C2=A0whether=C2=A0to=
=C2=A0check=C2=A0init=C2=A0or=C2=A0core=C2=A0text=C2=A0area.=0D=0A=C2=A0=0D=
=0AAnd=C2=A0also=C2=A0while=C2=A0printing=C2=A0modules,=C2=A0kernel=C2=A0al=
so=C2=A0uses=C2=A0core_layout=C2=A0as=C2=A0base=C2=A0address=C2=A0only:=0D=
=0A=C2=A0=0D=0Astatic=C2=A0int=C2=A0m_show(struct=C2=A0seq_file=C2=A0*m,=C2=
=A0void=C2=A0*p)=0D=0A=7B=0D=0A..=0D=0A=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0/*=C2=A0Used=C2=A0by=C2=A0oprofile=C2=A0and=C2=A0other=C2=A0sim=
ilar=C2=A0tools.=C2=A0*/=0D=0A=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0value=C2=A0=3D=C2=A0m->private=C2=A0?=C2=A0NULL=C2=A0:=C2=A0mod->core_la=
yout.base;=0D=0A=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0seq_printf(=
m,=C2=A0=22=C2=A00x%px=22,=C2=A0value);=0D=0A..=0D=0A=7D=0D=0A=C2=A0=0D=0Aa=
nd=C2=A0also=C2=A0normal=C2=A0%ps=C2=A0prints=C2=A0like=C2=A0below:=0D=0A=
=C2=A0=0D=0Aps=C2=A00xffff800000eb4004=0D=0Aload=C2=A0address=C2=A0of=C2=A0=
module=C2=A0is=C2=A00xffff800000eb0000=0D=0Aso=C2=A0normal=C2=A0offset=C2=
=A0is=C2=A04004=C2=A0for=C2=A0init=C2=A0text=C2=A0section.=0D=0A=C2=A0=0D=
=0Aand=C2=A0same=C2=A0thing=C2=A0is=C2=A0printed=C2=A0with=C2=A0current=C2=
=A0patch:=0D=0ApS=C2=A00xffff800000eb0000+0x4004=C2=A0=5Bcrash=5D=0D=0A=C2=
=A0=0D=0AStill=C2=A0if=C2=A0we=C2=A0need=C2=A0to=C2=A0handle=C2=A0separatel=
y,=C2=A0then=C2=A0please=C2=A0suggest=C2=A0only=C2=A0offset=C2=A0is=C2=A0ok=
=C2=A0or=C2=A0we=C2=A0need=C2=A0to=0D=0Aadd=C2=A0string=C2=A0for=C2=A0init=
=C2=A0or=C2=A0core=C2=A0also=C2=A0like=C2=A0below:=0D=0A=C2=A0=0D=0A=C2=A0=
=C2=A0=C2=A0init_text=C2=A0start=C2=A0+=C2=A0offset=0D=0ApS=C2=A00xffff8000=
00eb4000+0x4=C2=A0=5Bcrash=C2=A0init_text=5D=0D=0A=C2=A0=0D=0AAnd=C2=A0also=
=C2=A0then=C2=A0there=C2=A0will=C2=A0be=C2=A0discrepancy=C2=A0for=C2=A0roda=
ta=C2=A0or=C2=A0other=C2=A0sections,=C2=A0which=C2=A0offset=C2=A0to=C2=A0ta=
ke.=0D=0AIf=C2=A0we=C2=A0are=C2=A0taking=C2=A0it=C2=A0from=C2=A0core_layout=
=C2=A0then=C2=A0init=C2=A0section=C2=A0can=C2=A0also=C2=A0be=C2=A0taken=C2=
=A0with=C2=A0same.=0D=0AAs=C2=A0of=C2=A0now=C2=A0it=C2=A0is=C2=A0unique=C2=
=A0offset=C2=A0calculation=C2=A0for=C2=A0all=C2=A0sections.=0D=0A=C2=A0=0D=
=0AThanks,=0D=0AManinder=C2=A0Singh