Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Nava kishore Manne <navam@xilinx.com>
To:     Xu Yilun <yilun.xu@intel.com>
CC:     "mdf@kernel.org" <mdf@kernel.org>,
        "hao.wu@intel.com" <hao.wu@intel.com>,
        "trix@redhat.com" <trix@redhat.com>,
        Michal Simek <michals@xilinx.com>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 2/6] fpga: zynqmp: Initialized variables before using it
Thread-Topic: [PATCH 2/6] fpga: zynqmp: Initialized variables before using it
Thread-Index: AQHYMtFNadCZe0VWu0OEcc9wpwDlOKy6QtkAgAYbAYCAAEp0gIAKZPXw
Date:   Tue, 22 Mar 2022 06:55:44 +0000
Message-ID: <SN6PR02MB45765A42BF873BDC02DF210EC2179@SN6PR02MB4576.namprd02.prod.outlook.com>
References: <20220308094519.1816649-1-nava.manne@xilinx.com>
 <20220308094519.1816649-3-nava.manne@xilinx.com>
 <20220311142814.GA97487@yilunxu-OptiPlex-7050>
 <SN6PR02MB4576FB4490F96E593E09D4B9C2109@SN6PR02MB4576.namprd02.prod.outlook.com>
 <20220315160855.GA121107@yilunxu-OptiPlex-7050>
In-Reply-To: <20220315160855.GA121107@yilunxu-OptiPlex-7050>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2V12AUjXCbjUrEuiDgkdIWvA9PRX1vS6jcg/7/c+cIVoOj8rL4gl8Fra84H9?=
 =?us-ascii?Q?+MwpPUo1TP5JR3WgxB8Af1eHUgmKg3R4YT3CeMNnJQN/oSA+FhIg2R9EdbZS?=
 =?us-ascii?Q?r8eEuvc/4Vo1utfWld+vxfQUcOYIz/BcAPQIylJcX+XG036174TDw2+ycSVh?=
 =?us-ascii?Q?DosSFN7a+SFFUNrxOJCS4+c2Yj27MZt29+n+wLs2bICL4O/nY7YSAli8QNhr?=
 =?us-ascii?Q?VxnTZAq7vbK2BxlOyZfy+Dt532LT9RaQqBHqOJL6D+zlZvfFJf9gD1jzh/sl?=
 =?us-ascii?Q?hUllsPII0VM0uBtDH6ExjxFxkoWRgFnufvl8YkMatiyK0rdoxxxDiv89P3/D?=
 =?us-ascii?Q?5qxvVQK03OmD08r51fFpzx/77cLWfvlD+wKWPeNUhm0NI24ksEX7KL98YJpl?=
 =?us-ascii?Q?yOzIFmxtq5sy2e1n7dzC3lL6Am/KZY+0YTw3oWeIA7Fxd+52Az0ZSTFovVDE?=
 =?us-ascii?Q?UyW+VUQmeQPkwy7Wxhl2trOxtWdkublfNXX8CYki70JnDGwapBAjhZh6or0+?=
 =?us-ascii?Q?Zygs11Ul0wjcBC63J1SvkmEbvfD6KSyP9X2DPFKs3JpwJqjelPi3OKv/XJKD?=
 =?us-ascii?Q?U/MbFu/E7Qya96DO17k7vdjL2/4qEM8pWGKxX8W1fgJBbJKDUCIe3o/U4hAs?=
 =?us-ascii?Q?tR1QGeZ2o1FcX8SrwkdN+2NteR5yNumS5pL76BkieHpu4svMTebtQKW8nuE/?=
 =?us-ascii?Q?a3zv4Guexapev5JuIzGujjBq6vziwW2SrEy9F8wo7LFJv8MGAnaNajXNJmbx?=
 =?us-ascii?Q?HyqPZ1GEUauUgPQXZFB2ZrGfFZ0neM1Zp7RCNPss0cW0Jizw7snjqDQQnRx4?=
 =?us-ascii?Q?VGL7+TwoXbrN2fW0ScoyuLqW+WZMqUXcHVs8Ja+xOVgdji4l5bmaz6CqKyYo?=
 =?us-ascii?Q?HcMQMGV9VjIVyRiqrbZ7d/hUCKny3q1KUWqcZYskgUEwQFkqu9ZNpB+fNzOu?=
 =?us-ascii?Q?8EgdqRCazdNrNfzNWkihNgrIcXAvaf6w/lLZn2nV8GGZ031kPgSQ35gyL8qi?=
 =?us-ascii?Q?/x8iWp2GoGXmjMMhYQRNNNbiXn7uicc8N3rpiwlbJBRMx4kT0BiJulJl+vtC?=
 =?us-ascii?Q?KMXmFteNtW1xyX3iB8aYeX8coA43K5WhUetJD6DoDSLE91xjFUbQeed7mFBl?=
 =?us-ascii?Q?pFOFD18o1Vg9BF/fPRpvkARbFyvS8c8t0UITFUgM1zKgyhjWdMT3LJGpR8Fv?=
 =?us-ascii?Q?Z3jbQb5izfkrPpTnNTAqUCxmOCPR5t4dwkvGMSyWsSGt7BhF+SzlXto9CGtL?=
 =?us-ascii?Q?5iATZKxMX1GwTvzjPM1jwDfL6jgnNMvL9sj9bu4iDzZie9Vga8CiibadXf2d?=
 =?us-ascii?Q?q+5RkkTwq/y/I6lmOl/td8pxUnObSIdYfqZbMdMSyJoYLkKbC2WU/dSFVYIi?=
 =?us-ascii?Q?xsoDt4Ojo796xR3EjWgD5RU2Li+ND8A6HwYtdSYZELhSWXvy5hSHHKNJrwq5?=
 =?us-ascii?Q?DfEQqhlMdXYKN+omn4ci1FLoUxY7HKZa?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4576.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e041eb50-ae4b-497d-2e64-08da0bd0fc94
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2022 06:55:44.4238
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6M8z4ALG0Fzz9qGT/m6R7qI3pu84imsYjJEGxbKQtwXXcPTwO3OcUtv8FmByBDUgr1fQgha88GJW+cJiizw8+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB3650
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Yilun,

	Please find my response inline.

> -----Original Message-----
> From: Xu Yilun <yilun.xu@intel.com>
> Sent: Tuesday, March 15, 2022 9:39 PM
> To: Nava kishore Manne <navam@xilinx.com>
> Cc: mdf@kernel.org; hao.wu@intel.com; trix@redhat.com; Michal Simek
> <michals@xilinx.com>; linux-fpga@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH 2/6] fpga: zynqmp: Initialized variables before using=
 it
>=20
> On Tue, Mar 15, 2022 at 11:48:11AM +0000, Nava kishore Manne wrote:
> > Hi Yilun,
> >
> > 	Thanks for providing the review comments.
> > Please find my response inline.
> >
> > > -----Original Message-----
> > > From: Xu Yilun <yilun.xu@intel.com>
> > > Sent: Friday, March 11, 2022 7:58 PM
> > > To: Nava kishore Manne <navam@xilinx.com>
> > > Cc: mdf@kernel.org; hao.wu@intel.com; trix@redhat.com; Michal Simek
> > > <michals@xilinx.com>; linux-fpga@vger.kernel.org; linux-
> > > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> > > Subject: Re: [PATCH 2/6] fpga: zynqmp: Initialized variables before
> > > using it
> > >
> > > On Tue, Mar 08, 2022 at 03:15:15PM +0530, Nava kishore Manne wrote:
> > > > This patch initialized variables with the proper value.
> > > > Addresses-Coverity: "uninit_use: Using uninitialized value"
> > > >
> > > > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> > > > ---
> > > >  drivers/fpga/zynqmp-fpga.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/fpga/zynqmp-fpga.c
> > > > b/drivers/fpga/zynqmp-fpga.c index c60f20949c47..e931d69819a7
> > > > 100644
> > > > --- a/drivers/fpga/zynqmp-fpga.c
> > > > +++ b/drivers/fpga/zynqmp-fpga.c
> > > > @@ -41,7 +41,7 @@ static int zynqmp_fpga_ops_write(struct
> > > fpga_manager *mgr,
> > > >  				 const char *buf, size_t size)  {
> > > >  	struct zynqmp_fpga_priv *priv;
> > > > -	dma_addr_t dma_addr;
> > > > +	dma_addr_t dma_addr =3D 0;
> > >
> > > The first use of this variable is as an output parameter:
> > >
> > > 	kbuf =3D dma_alloc_coherent(priv->dev, size, &dma_addr,
> GFP_KERNEL);
> > >
> > > So I don't think it needs to be initialized as 0.
> > >
> >
> > This issue is found by Coverity Scan, Whether this param is input/outpu=
t
> this fix will not impact the actual functionality.
> > In order to fix the issues reported by the Coverity tool, this fix is n=
eeded.
>=20
> I didn't see issues about this piece of code, so I don't think we need th=
e fix
> just to make the tool happy. Maybe the tool could be improved to help us
> better.
>=20

Agreed, I will drop this patch in v2.

Regards,
Navakishore.