Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2554598pxp; Tue, 22 Mar 2022 00:30:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+OGZIkH4wdl+rOi40gDBWUtd7rlBJifi4F6p8EpC5q+sb/gwhtB4YnBYguAg7KTZ2q8Q3 X-Received: by 2002:a65:5b4c:0:b0:384:65b3:408f with SMTP id y12-20020a655b4c000000b0038465b3408fmr1489029pgr.543.1647934210567; Tue, 22 Mar 2022 00:30:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647934210; cv=none; d=google.com; s=arc-20160816; b=QN4GtaJtomsfSIMF0DquT/3lTKLoXJ6weiz4p0A+kMYAdl/dyAH6ZVyHO+TgCP4BKO f6lOqz0qQAzjqLQmeQlBg4fwOnx1Fq5jxV44j+xLrtS5v0rYvcpm9q6/VfUwvbqCzm3u l4q/VrtuEOQ/SCcBXLyN/OejkmCJzzKirY6HzmKYOuZp9u2Y/kWd+zCD/J0VIEhgbzhx 7uVpxrqWcJUQ2wY2gqWmkerCbw+qeuvJQxEUvuR+w4au/hEExKRjYoIIN6pIobA2ZC4V MzhaA4gaVgg3Mfe1k0NrEs3VTMtxTj82t9IbeOAqHLdUIN0lGvcXFlAcx/mb/QFsfr1X TvDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=rYikdF40SXf7xi+HwkY/x3YoTFSrAuyc/7qiBvixRb4=; b=0x0sq05wuHib5Y8e/r3Re9B5b7alFbdiYrvuaj92D8HxWmPGdhkNg2p6zHlPVKqUUN B6cO7qhY3Ibd+66dAzG6FNTbz4v5GG/WMWFBwSeT9Hh1id2dtNEBNE8Ie518XqKp1KsG KWLwB+Td1NwenNSpCunGGzfX5XyC6qvVhZaBJV09okAbZAlE29rYakHTJlfcPp2a7c8t 1JtLzGJGUeVBfA2kqE9U7Bra6Q3crnFosZq9pL2WBxbAL9D5aga+ScglglcTWTG3ATdz D9zZRWX3cyZpe5mF52G2YMsHBmgttVY7Vjb62WBvDBaSPCXWvKg/C1eXFAvQkUuQg/aC Jm+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=GSEHR0RL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id me13-20020a17090b17cd00b001bf22e81deasi1563345pjb.68.2022.03.22.00.30.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Mar 2022 00:30:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=GSEHR0RL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 984CD5BE73; Tue, 22 Mar 2022 00:07:27 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237231AbiCVHIu (ORCPT + 99 others); Tue, 22 Mar 2022 03:08:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237233AbiCVHIo (ORCPT ); Tue, 22 Mar 2022 03:08:44 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAAAF5A143; Tue, 22 Mar 2022 00:07:16 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id w8so14685784pll.10; Tue, 22 Mar 2022 00:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=rYikdF40SXf7xi+HwkY/x3YoTFSrAuyc/7qiBvixRb4=; b=GSEHR0RLh04Nz7yeZGkTfKjhwk+vUEXMSOxUTFD+XpigilckpbzkhnwweQjBcneuRm 7SOmwnszgKNT7AbNYdg/8SPXTwYI/P6tkFA7PeXh1jQtE57uAkLxNriozHNklQSs3LYP I1r/ZEi3+n+fvfm/p/G/1ZvGbM9Uqg38l96T962cUrjCpItKlNkczdwWt6/bCfhfjuA7 VezHs+eaMxp7ypZ6vl8VCBe1xcEBPYhw1jg5osO+FEw0xnoIjJLx1SyLH8hdYfUTjKzy 7hcZ0y2y4lR+UM/ISw7VLZc50jKdRJ5a3WJcS32AvrnmLmH8YIcYVkUIvMTyHbIPjBLP i70A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=rYikdF40SXf7xi+HwkY/x3YoTFSrAuyc/7qiBvixRb4=; b=PmN5yMM47jnzUmSfefE2lAa1DpR1xYhzyi9lRzcDIkqXwFhQB/aJk8yjkPco8bXkSl UB1Be9BFYldScJAe5HISLuD/JGMLeXMj2YSqCSUF+WtKyLtIGF1NE5aO+7tfOiJBfvi7 LxTGlYuDPB1IkFb0BLz8t3+B5r9uj0XrFqoC42ysAy3B1zdlwgRt89/jbZr3yYDHYewv mhdiW1K0RZp3SBYgouhIG2MUpmyu243i7/OAkyofSjEejJxxU25auY71AUqBG7Ergdt9 sdMYf6XF0fBsZyrTWgiigTb3cOgbXsmXQucqo2e9QSFwCRLBfE3yiEmvUeCf+lgmac+5 TN1Q== X-Gm-Message-State: AOAM531dpb0Qz9WNqdCn3O0goTh5KwiBW5eMJ3Ko8ksKRoSMbqz18zCT 9FiDF4NPr08lqShv4fEEJ2gDkG7+o4f+cg== X-Received: by 2002:a17:90b:3a8e:b0:1bf:7fb5:af06 with SMTP id om14-20020a17090b3a8e00b001bf7fb5af06mr3292555pjb.7.1647932836230; Tue, 22 Mar 2022 00:07:16 -0700 (PDT) Received: from [192.168.255.10] ([203.205.141.118]) by smtp.gmail.com with ESMTPSA id fy9-20020a17090b020900b001c690bc05c4sm1574256pjb.0.2022.03.22.00.06.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Mar 2022 00:07:15 -0700 (PDT) Message-ID: <4bc9b537-f0de-5b75-5418-61c1d6dca849@gmail.com> Date: Tue, 22 Mar 2022 15:06:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 6/7] perf/x86/amd/core: Add PerfMonV2 overflow handling Content-Language: en-US To: Sandipan Das Cc: peterz@infradead.org, bp@alien8.de, dave.hansen@linux.intel.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, namhyung@kernel.org, jolsa@kernel.org, tglx@linutronix.de, mingo@redhat.com, pbonzini@redhat.com, jmattson@google.com, eranian@google.com, ananth.narayan@amd.com, ravi.bangoria@amd.com, santosh.shukla@amd.com, "linux-kernel@vger.kernel.org" , linux-perf-users@vger.kernel.org, x86@kernel.org References: <7d43b4ba8a7c3c0833495f3fabfcfc6df8db3732.1647498015.git.sandipan.das@amd.com> From: Like Xu Organization: Tencent In-Reply-To: <7d43b4ba8a7c3c0833495f3fabfcfc6df8db3732.1647498015.git.sandipan.das@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/3/2022 2:28 pm, Sandipan Das wrote: > + val = x86_perf_event_update(event); The variable 'val' set but not used. > + mask = BIT_ULL(idx); > + > + if (!(status & mask)) Needed here ? > + continue;