Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2563043pxp; Tue, 22 Mar 2022 00:46:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/064Vi6374wERuWjjDgXK8wCO8NleCdmh2k1mf8GAmF4DcmeUi0Lz0QSH9orie1+RSIrX X-Received: by 2002:a17:90a:4882:b0:1c5:f4e2:989a with SMTP id b2-20020a17090a488200b001c5f4e2989amr3510743pjh.160.1647935165293; Tue, 22 Mar 2022 00:46:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647935165; cv=none; d=google.com; s=arc-20160816; b=DwDzGzLo9jwShk1D7TVeAWLOi8wpOBCQgPohrAJ5VIUVLg5p8AEBsZUnJDfcJOY8TI YEPKU3BrWPOD8nqLydSN0yx65+fo1YZn1iCsTaLCYK6dZxqW+eDIXDHW+vP6UcfSXoQ0 6mEK0gFmnipYcwz3t755muOXwzMWyVNOvsFV9lHOEwVkAsQawK2uXjqGStloVVV7yLmL URMlieAMqIOZkSNe4XGh2H5JZ5Ru7SuaaQJd8IPrBiI4mJSV5w/5SvKbUNK9PlXzFkra mJlVCIsGNESosbygrjlxCGyxly9s6AxXf3nd+E9gyydWRKfdEeLfllVItF2UNLwNgdDz BE/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=KeL0XwdZoDHk0HJY6UD4i5wOSw01lP9KaIX9E/wmf14=; b=joGPOwTPnfwYy87SxE1Vswdq+YJpDHc4iIz6BPyJXOsNZ2HsDtsS/9JEYdhuxII+7q Th9xHk+bNXeMPg9w/wN41aphBDuP8TUwdsQWaMR1ABznqiXqkkyDOFbciuSTuu1cEEPx LxkHCu5EwcmaDYBS+494H+YwtYBheXQiNpNopwi9FHGZ6yBWDIE2rW29MeEjZ1hDGUDW 0hRl+IIylkUO4jIOZSzHxv06Anb+h5IH2F/SedJIWawnlSFUSuPHlOl5TKlXMMVquOS3 Vrkq0fZf3+OxPTLp+ksY3LIzxBDkNYPmxqSH7AVZNpk7SmEUKqIs4n+M1DyQhyXFzdsE ZYAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Ghj1Jwr7; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id me13-20020a17090b17cd00b001bf22e81deasi1594450pjb.68.2022.03.22.00.46.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Mar 2022 00:46:05 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Ghj1Jwr7; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D9EFB26AE3; Tue, 22 Mar 2022 00:33:56 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233905AbiCVHfK (ORCPT + 99 others); Tue, 22 Mar 2022 03:35:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237625AbiCVHe6 (ORCPT ); Tue, 22 Mar 2022 03:34:58 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0F19220FA for ; Tue, 22 Mar 2022 00:33:29 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id p9so23613595wra.12 for ; Tue, 22 Mar 2022 00:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KeL0XwdZoDHk0HJY6UD4i5wOSw01lP9KaIX9E/wmf14=; b=Ghj1Jwr7ot5jaMNP4tgZiZFZL7OwaoIaxLvWPfbUSU3LVjjJMwkPb4phdWEskVIQYa 1NhjsthU4Uibt9mwHfI3JumhT0MwIwUrgRiuxbwi+zspq5hEShpCEKmyxQHKUKm/ApqS KzcCAYNQBh5mnxsooaC4By2KqQg53TdhPFAzw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KeL0XwdZoDHk0HJY6UD4i5wOSw01lP9KaIX9E/wmf14=; b=7+eLNPEOwmGZhv8iPCgGIV0HV3PFN9m01WOd6sFw4EN2CXhCruRx2pDFAZMXMmRUWG Yw4a5HfCnLuH1NlUeAg0sfQJxGcLTq+HP5SelwZgioAOSVLmYSxMdc4b/zgkmpXnMWhm afOFvdvHSjx4tRAURX7hfkdGeSVA12jpBQJajXvjmViRm6EamTIn8qms8DeGs3jK4/0r WLiyONkbT4Dka52VQUoqMqK08LlsxFOgfpX/hvhc/b1NbaYDrdbABmaJcdyQJ8FjiId9 KMgVuSmPlMfOGfxwf1O6N27PkgomdIdRdMrBHhF9376jPs9c959WC/C50ZyJklZAbNp5 FBLg== X-Gm-Message-State: AOAM533eYmWBANHmGgjVlKcaDP6yveq/lu6V/s6aTCHEgLmTw7iV7VxC 5ets8APvMoe/E1s0VdXuPNk9B8DZumTtlofv+liZGA== X-Received: by 2002:adf:d1e3:0:b0:204:7e76:8a70 with SMTP id g3-20020adfd1e3000000b002047e768a70mr1860283wrd.580.1647934408221; Tue, 22 Mar 2022 00:33:28 -0700 (PDT) MIME-Version: 1.0 References: <20220302120925.4153592-1-xji@analogixsemi.com> In-Reply-To: From: Pin-yen Lin Date: Tue, 22 Mar 2022 15:33:17 +0800 Message-ID: Subject: Re: drm/bridge: anx7625: Set downstream sink into normal status To: Xin Ji Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , treapking@google.com, qwen@analogixsemi.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, hsinyi@chromium.org, bliang@analogixsemi.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xin, Can we use dev_dbg instead of dev_info for the logging? The log here is more like a debugging message, and using dev_dbg makes it consistent with anx7625_dp_stop. Sorry for not catching this earlier. Best regards, Pin-yen On Thu, Mar 3, 2022 at 3:52 PM Pin-yen Lin wrote: > > Reviewed-by: Pin-Yen Lin > > > On Wed, Mar 2, 2022 at 8:09 PM Xin Ji wrote: > > > > As downstream sink was set into standby mode while bridge disabled, > > this patch used for setting downstream sink into normal status > > while enable bridge. > > > > Signed-off-by: Xin Ji > > --- > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > index 9aab879a8851..963eaf73ecab 100644 > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > @@ -919,12 +919,20 @@ static void anx7625_dp_start(struct anx7625_data *ctx) > > { > > int ret; > > struct device *dev = &ctx->client->dev; > > + u8 data; > > > > if (!ctx->display_timing_valid) { > > DRM_DEV_ERROR(dev, "mipi not set display timing yet.\n"); > > return; > > } > > > > + dev_info(dev, "set downstream sink into normal\n"); > > + /* Downstream sink enter into normal mode */ > > + data = 1; > > + ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, 0x000600, 1, &data); > > + if (ret < 0) > > + dev_err(dev, "IO error : set sink into normal mode fail\n"); > > + > > /* Disable HDCP */ > > anx7625_write_and(ctx, ctx->i2c.rx_p1_client, 0xee, 0x9f); > >