Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2586065pxp; Tue, 22 Mar 2022 01:30:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzr3yPYow5A02mK8tU2zPWdvUmomO/98fvMCWobiGiCMLCgr2ZWUu8VHM1ttizKunR1MXJ+ X-Received: by 2002:a17:90a:1596:b0:1bd:4af:6055 with SMTP id m22-20020a17090a159600b001bd04af6055mr3605506pja.139.1647937845294; Tue, 22 Mar 2022 01:30:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647937845; cv=none; d=google.com; s=arc-20160816; b=TcEJuxzqrXzSjPQcoBmAjduyPuvWMUAKxYs/XpoNrX0hTwBy8fRkndK3o694wqRUrr HHqXEIwNEXfFO9Wkf7wxj9DrtKbqMrEecwXnhAqmHkx0y1kF4rNGQtbvAaKCvx7VOWGE mrOJR5x3FMsDeXDW9OeaTuL/+Bv+LWkxl89j2HFY+ljb9Vz1y/mqHtlHJ4UqhoB93d6j MIFy3MlRU3CI7Yxu0XXCFAb82HIgzbeJJcKTeB2oX4IIa8LEneAuAXYQPMOI/3Ue/CO6 zGjg8rEtEFC048U2SPhCcuWeLRfisI1xGvXthS7pd3gLgHOtZkLmZ1IzloXi9DHOdNmx qFHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=87Bh+QidxYMpsTYJqSrvJQ/cLDGkqP1N5aKJGexsbZ8=; b=qZshhroOcXzyFPh+jBb4RhJd/z0Rct3z2BPee7h+hfeqMuz5w8TKS0hOD57NpXFMc/ tvvtMdfFU7sVYOa55YPmUGcrit0tDUcPSMIrLkBIiWbYv9J3e4Ee9NRI6qmhTrzYTIFC bxiwnk8dtPhNrtnP1K+AwbXtd3+TNRvSCLDR4nWSTQ9/yNrgJLoIL76W5cUwwe+3EEGt VjII8nOxCmOZe/T63WwxnO1C+AFQVm/03q3ivcoz/gy3wsHBltjDWcSiKjsWHdXPYuVI ib1IoCJ4Siob9YBBBBFrW7/avWhnk3NlC6kfQNttOlHtCyMsIF1otDiUCBS/MtUbTu30 3VVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=UntMI064; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id np5-20020a17090b4c4500b001bed912d3c4si1609420pjb.174.2022.03.22.01.30.30; Tue, 22 Mar 2022 01:30:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=UntMI064; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231156AbiCVIZq (ORCPT + 99 others); Tue, 22 Mar 2022 04:25:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231143AbiCVIZd (ORCPT ); Tue, 22 Mar 2022 04:25:33 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80A4165E6 for ; Tue, 22 Mar 2022 01:24:05 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id h23so23188015wrb.8 for ; Tue, 22 Mar 2022 01:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=87Bh+QidxYMpsTYJqSrvJQ/cLDGkqP1N5aKJGexsbZ8=; b=UntMI064I4h4ouP4KOJ7gqzkm7PmMH9vI17MKSNFgn3wq/uh0ECMIt0Wum/7pYQLIG CF5qBREq7d7xNCgDHi+Ssg57wHI7f9XS9l2hCZ3FPmB/Y8Z7aC4BhUPhqVjCnfoZhOLm CaKh/rBCwdFKiC7OokdIBLk11nGnzs+X/16vfiRfDNq7ikugOnBBSpW1pMOOlxZXFs8Z w1yNrULd3jjat3CWVriijurqzl6TaditTbuVlTI3zuNc80i3PcLCZw1oCUfa32DelVTa aFzFvd4SR41BRDH2prRLnHcPr/BoVrSe2MhkpDnMRxeEPk6Oyi5jgGA6Mz7oe+1Sbr8Y xbUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=87Bh+QidxYMpsTYJqSrvJQ/cLDGkqP1N5aKJGexsbZ8=; b=M4hlVYBtrLAMXK/w3JPNdp7gmuZeKxv9yasaCQ6wUX9nYK5x34Hd5V/lBUfnVNEPXt EFELHKUTq9tS7k9HuRVBSZJyLOcHDfbcvrehs96P+gR7UqF+r0DNtOznhTFLSXmGXXqs pX0ntAO03ofYtNyoKDBqdnXrP5SG3E50rbvpQdBmFnbENQ4Ljotsvkj8PixMRg1Fl6rm JrmvxuKdhdTAnjn9CfaqUenlzjfnVmc5OXm3UagzHD0Ud0SRcsLL+zMYn4ZrmHpkj1nr w9x4XE/3IUo2zg3AWzLkGtnGQ6Blan8IDNBfAopJq39uNxIWLpxnk7Lt1dT3BMrx7k2k UDTw== X-Gm-Message-State: AOAM532GL32mXCH118JK10SMQH+epDp301EKbHETA/AhQcLrTgU0l0Dj uWZeKX9vfBAcSfiReipE1dtsow== X-Received: by 2002:a5d:6542:0:b0:203:da90:969f with SMTP id z2-20020a5d6542000000b00203da90969fmr20612878wrv.479.1647937443900; Tue, 22 Mar 2022 01:24:03 -0700 (PDT) Received: from google.com (110.121.148.146.bc.googleusercontent.com. [146.148.121.110]) by smtp.gmail.com with ESMTPSA id b3-20020adfd1c3000000b00203f94379a4sm10515962wrd.67.2022.03.22.01.24.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Mar 2022 01:24:02 -0700 (PDT) Date: Tue, 22 Mar 2022 09:23:59 +0100 From: "Steinar H. Gunderson" To: Adrian Hunter Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] perf intel-pt: Synthesize cycle events Message-ID: References: <20220321181447.1323742-1-sesse@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 22, 2022 at 09:13:42AM +0200, Adrian Hunter wrote: > Thanks for sending the patch. There is one variable leftover from my > earlier suggestions - see below. That should be easy enough to fix. :-) By the way, I updated the documentation slightly in v2 to reflect what you said about when CYC packets are emitted, and the possible (partial) mitigation of noretcomp. /* Steinar */