Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Mar 2022 16:52:08 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Hsin-Yi Wang <hsinyi@chromium.org>
Cc:     Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Robert Foss <robert.foss@linaro.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, bliang@analogixsemi.com,
        qwen@analogixsemi.com, treapking@chromium.org, pihsun@chromium.org,
        tzungbi@google.com, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal
 status
Message-ID: <20220322085208.GA1487511@anxtwsw-Precision-3640-Tower>
References: <20220322080213.1487134-1-xji@analogixsemi.com>
 <CAJMQK-j+PhB6dZBuKG3NtW94oT0bVkp9G1bXhmyZLgYOmTCgog@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJMQK-j+PhB6dZBuKG3NtW94oT0bVkp9G1bXhmyZLgYOmTCgog@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y+GkO3RFrT7Snm7OsLMe0j0nJo5RgrVfPxTSb8M42E0dgT8l/HOmhXHP5rvH?=
 =?us-ascii?Q?0zSd3GXL8xcDaA5pwf26TB6p7lJT+zaQXFZ6qRAZoE06Ft2PlvQxS+I21C3k?=
 =?us-ascii?Q?e9FD0qaDxlTFT0rw0o0E+B9kpyjRQii34/eFN6J0CECba8/qVVeSAbNW+HJO?=
 =?us-ascii?Q?1iaDV7+CIJoeWLlIGhNKkWKO0wQGXoKvJfxF/ybJsdcwa9KHU2z/1cW+wot/?=
 =?us-ascii?Q?dkyZdt0V17UIV75zj7zxUlR51FGyGygEQUDlHT1FuXUCP71k2nKMlRY/C4qP?=
 =?us-ascii?Q?xS8X+WZYfuTHjY9uz/WRiGmz48HzNJqcW5B77zpQh0CEO9WnFVOhG1pfbCUo?=
 =?us-ascii?Q?mxV0e5V3IFT+tdspxAF0nAc9ErtQca8qQ2TjDTObI+cQJqbHrWmyhgW4GGRQ?=
 =?us-ascii?Q?PFjL8LClc98YSBPSDV9C0Xgek6e/NWurnuq6F3FJV3weZlhXayJVSUcB1b77?=
 =?us-ascii?Q?MQvYMomwJRiEmkG42YmzFObqMfP9UIaz4UY65mUIGEhsHtgR8diRO3kjriPR?=
 =?us-ascii?Q?01mSp/hjguEqyxsPY/R+YHhxX28QALQuAiUfOefi/YAiKk/MwlpgBpSj7R0T?=
 =?us-ascii?Q?IPBOdzqPTRmOs/Pnzgskrj/xTvzGs/ilk0373fM7Pgxt0TVq++xRbMoVClRK?=
 =?us-ascii?Q?HDXCLPsCPXmLn3YRfiQxRNdBQ3Bf+rbDAYhf/dA9IVTjAtjJeZwRJRDDE1wC?=
 =?us-ascii?Q?IcMl2PjkzXg4FzcDfsnacOjGvCSrfAmYwKlO38K7ErZOsn2+Nw87CQopzb0d?=
 =?us-ascii?Q?zqJxCIiJ5cPfIGn/Z9hrlKWzU5bHPEPhqyeCE0kMtcy+hePBM0rvg7SiBFj1?=
 =?us-ascii?Q?hbQ1aEncVt/MIpF22olHmpbgo9NOD7yI/VB3GOyWy4sN0Ur4jPx550gaWpZY?=
 =?us-ascii?Q?5io9v6W05hsW9KGgjyoWCGNFbq1A2Pr58dd4rVgBhqM39zwrjUqMP8PO9Ttl?=
 =?us-ascii?Q?HjzmiT/DBlRTnGcp98REM20Tt9G723EgckRngbL0Cfm1lyuVy0LnDwcQ7g3h?=
 =?us-ascii?Q?Yueu1kgxAWYuQlHQU6ubGEtrZmu/CIRVYO0KiqBLC6E+zC/J+16h7mArHUyv?=
 =?us-ascii?Q?YMikH0HYI5Be8vh9D32mjsDyfgSYofC+hb1uvDnCr5lnXQcfjr+vL3FS9wiY?=
 =?us-ascii?Q?ZW7DAaNEhqlX8/8EG8dX27HoJatEI/9ob9Em21SpmhoNgp2ZT1swx2igK37u?=
 =?us-ascii?Q?yAE9UKLbj9nuBjCg2dz1IEmqi9kWfRTrFRUNu1S5JnmbFLiaJ1SmqDcLICam?=
 =?us-ascii?Q?eyNhhMUZYbIEuESBZaCc59F34K/k6LBEmFFUHY1Fcs9zLB+2VE3M9VCqgzez?=
 =?us-ascii?Q?vwiZn+Ob5msgSoNE7LXO3doSKf9j134h8h6m8GER+Np4j1dsSHJM7+FME4Zd?=
 =?us-ascii?Q?mjbC7FPfXgsNyILF7iD/dYN9GcdBeNnEtvi4SqrGFywH2s+SFkSDrmfbR41K?=
 =?us-ascii?Q?KI8OAk5mcqopKVOHFIGv1hIxBj/6vaFy?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eeadc973-b38f-417f-b37e-08da0be14258
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2022 08:52:13.7033
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KFUqaUuEboQDdvUwW+REFkX9Zfk3jAU0MoQt0A0y7/uSUX70pZoblQ6dY38G8uLDSNfKruFIcZS6QfvPvMDOwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6834
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 22, 2022 at 04:43:20PM +0800, Hsin-Yi Wang wrote:
> On Tue, Mar 22, 2022 at 4:02 PM Xin Ji <xji@analogixsemi.com> wrote:
> >
> > As downstream sink was set into standby mode while bridge disabled,
> > this patch used for setting downstream sink into normal status
> > while enable bridge.
> >
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > Reviewed-by: Pin-Yen Lin <treapking@chromium.org>
> >
> > ---
> > V1 -> V2: use dev_dbg replace of dev_info
> > ---
> >  drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index 9a2a19ad4202..dcf3275a00fe 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -924,12 +924,20 @@ static void anx7625_dp_start(struct anx7625_data *ctx)
> >  {
> >         int ret;
> >         struct device *dev = &ctx->client->dev;
> > +       u8 data;
> >
> >         if (!ctx->display_timing_valid) {
> >                 DRM_DEV_ERROR(dev, "mipi not set display timing yet.\n");
> >                 return;
> >         }
> >
> > +       dev_dbg(dev, "set downstream sink into normal\n");
> > +       /* Downstream sink enter into normal mode */
> > +       data = 1;
> > +       ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, 0x000600, 1, &data);
> > +       if (ret < 0)
> > +               dev_err(dev, "IO error : set sink into normal mode fail\n");
> > +
> 
> The driver uses DRM_DEV_* for logs. Can we use this?
Hi Hsin-Yi, as comment in drm/drm_print.h:
"NOTE: this is deprecated in favor of drm_dbg". DRM bridge driver not
use DRM_DEV_* any more. I'll send a patch to replace all of DRM_DEV_*
later.

Thanks,
Xin
> 
> >         /* Disable HDCP */
> >         anx7625_write_and(ctx, ctx->i2c.rx_p1_client, 0xee, 0x9f);
> >
> > --
> > 2.25.1
> >