Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Mar 2022 11:49:28 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     David Kershner <david.kershner@unisys.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        sparmaintainer@unisys.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: unisys: Properly test debugfs_create_dir()
 return values
Message-ID: <20220322084928.GM3293@kadam>
References: <20220322083858.16887-1-fmdefrancesco@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220322083858.16887-1-fmdefrancesco@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZTdgmSvj2gQ4RIZfa8ZtShF2VLjMFhlQAxvSwulpRA//wzSec+c5dqnYKwSt?=
 =?us-ascii?Q?mf43YYHPceQdGEnqCgwBJIrYqzLbzyrzdLiArQWcZb7KZWxfZM9qZM2kk7FM?=
 =?us-ascii?Q?wVpFzqDKLUF8B2fOgDpYCOPYEwaesB/3hVmmBTMuM7nYKldrF2KO+Twrcurj?=
 =?us-ascii?Q?+kCoOCHOJV+NmYnUYikueFPSwWy8LtIzcG+bc2J5s1/PV6hX53R5uOzkmmyc?=
 =?us-ascii?Q?x421cUVU8qTNvMV2ncq4EHN3d/bxxdscia1WwSDctA+BQx7JZvMLTNcUsejD?=
 =?us-ascii?Q?bdJoHHTwEKvUjNZhPAp+XDdP/5qL1N6jDrAkzUg+ZKlUu6XsQTQFmPUptWY+?=
 =?us-ascii?Q?e80rZr36Lzi9i4SQEziSj1yvHcZsnDA9QfNp+9DMxjEyIf7RQf1Kung0b6lf?=
 =?us-ascii?Q?SEqPo6PrkmuWaiobUwp7yBRrJCL2f21A9f3vRdwlULqfVoTiIJlAKPqnZjMM?=
 =?us-ascii?Q?l3PE/fSNrlVYjPwcaH8PIMwXbdIHTpEiM+ViEK4hdMU0q2pjxWpJa8gftPI5?=
 =?us-ascii?Q?LLWSL0hD+/UzEdXU4v2bAh5FzBIF5nk/4lXGFDNf+/KM8b/xzA5N1S1oWsMd?=
 =?us-ascii?Q?AXf2hJM8TPE2iFehHmOpqjHVeJ4eSWa9WPQxDRigco+2I5SR3xTi3dg/RDKA?=
 =?us-ascii?Q?e8XMTGtq0Yq9hcAVTaz8WBfeglwP3i0t3M/WMzg0TElg8RPYUCnv1JrtwJsu?=
 =?us-ascii?Q?sJuOFyHo4YJCvpurki9mpl0EaZ7fy7DLl2dvLjpTDy5w4ShKACdPNGV6JH/7?=
 =?us-ascii?Q?iz7i4qgGme3A+gK5H6hM/86KkUbbj8X5YQqwqT9O5/lrngWzHRhm/2i3y1Pd?=
 =?us-ascii?Q?zFWvnaxneFfxHTV1753hzkIfMumgojSrD3G8eOXg5z1dEqtqkbZX1mVKE1NL?=
 =?us-ascii?Q?9rsWt5wUBq0gULjiXVdUQWDqhcru/I+xkiSavZ495GArLcaPMyHPonDKGhXg?=
 =?us-ascii?Q?0NFWOe6mqVuuwFXsIwVzYpHn2thC8UxPR+nWuXjumRM73OvNw1Y5TyWSAtN/?=
 =?us-ascii?Q?GI0iO/XKIImPxXiCXmqhig+uUk7ZAEsAbf4SC+sYWEyKi6IpMSabl5q+VdVX?=
 =?us-ascii?Q?AFcXi1NmVFbNLzjKrwFixcv6uWDqFpQT9Wi3sfRLkGMpGRA9xWcAbhYuyIa2?=
 =?us-ascii?Q?qEnufBxv98Cp89xo2CWKW7IHcyP8NHwof9s6uyZRQMxVrSgoEa0bBoXxljFB?=
 =?us-ascii?Q?quYGEemXq7eCvLc0JXIa7PdTIT/tM2zKHKw0F00uHcxGxdg3y/CCdZUSRBg/?=
 =?us-ascii?Q?SkAFX0TIffqz6wveQTIXES117m84fP9CV4fws2pklKtNUTieHNVCcpQSUHtk?=
 =?us-ascii?Q?bDOZ59qkpS4R844zG+tcgRnz982WVX4OTV3ExNXq4MYIBk0QDgCu1PPMri3r?=
 =?us-ascii?Q?7qrJAZUgrwkIKE8CJL6XQp/OyZe6rQPSFSa+wqQwwinu9/PBA6IdKX8UAhRw?=
 =?us-ascii?Q?qXM0YDykeNNNfU8s0KR8DjJzjIQuAykWMXQAQrzhwB7A/eQmVQaJsA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bcf03a34-cfd4-4e31-62b0-08da0be0ea6b
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2022 08:49:46.5457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SWvahAbAJ7nrZhvTa0mvcL6ANzXnNLMOiHjybJ79pC53zmzEQTbkId1wrivYOwEPDwU6AbuF9+LeKhM5lIEchleFsTbGVlP+UY+PYsJiP1c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2318
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10293 signatures=694221
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 suspectscore=0 malwarescore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203220053
X-Proofpoint-GUID: tU003N5cf2Ce3TXAIFe2isH0RRlINZf8
X-Proofpoint-ORIG-GUID: tU003N5cf2Ce3TXAIFe2isH0RRlINZf8
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 22, 2022 at 09:38:58AM +0100, Fabio M. De Francesco wrote:
> debugfs_create_dir() returns a pointers to a dentry objects. On failures
> it returns errors. Currently the values returned to visornic_probe()
> seem to be tested for being equal to NULL in case of failures.
> 
> Properly test with "if (IS_ERR())" and then assign the correct error 
> value to the "err" variable.
> 
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
>  drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
> index 643432458105..58d03f3d3173 100644
> --- a/drivers/staging/unisys/visornic/visornic_main.c
> +++ b/drivers/staging/unisys/visornic/visornic_main.c
> @@ -1922,11 +1922,11 @@ static int visornic_probe(struct visor_device *dev)
>  	/* create debug/sysfs directories */
>  	devdata->eth_debugfs_dir = debugfs_create_dir(netdev->name,
>  						      visornic_debugfs_dir);
> -	if (!devdata->eth_debugfs_dir) {
> +	if (IS_ERR(devdata->eth_debugfs_dir)) {

Normally I would say to just delete the error handling.  But in this
case you can delete the whole devdata->eth_debugfs_dir and the related
code.  It's not used at all.

regards,
dan carpenter