Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2673419pxp; Tue, 22 Mar 2022 03:51:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzVal+bz3Xm/eMAFG+YCA3fUg0ooELGVyOIl7XCthV9ogphHFuVPrRykjb+rM2tGQ62GwZD X-Received: by 2002:a63:f95b:0:b0:382:aad5:809c with SMTP id q27-20020a63f95b000000b00382aad5809cmr4405177pgk.82.1647946288050; Tue, 22 Mar 2022 03:51:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647946288; cv=none; d=google.com; s=arc-20160816; b=azSTn4PmzS17qUpbNHJgfGRPzNrtLF8q0jJbC5/QyFNlV1VzqMd8b6Jjc4hJLrULQX dgM4SP4Nvg089JbATbbulzESKTHU8b1HN+QlTIIq1kVw8YZkYCRTpvL8CUWT96dX2Iqe Fa4fpslJ16yhLnMacXZTXTR6gFVVjz4VlqPFz4HR30P+yuYuPTE+PHLlVQjTppstgGJS knNm0h0TFGC+Yn2AQkd8cRMeHxKhuKtLcnLZjCL9TEEJhauBsRgCQTi6dCPyXDj01sSC msYK+LDjw/4ciLnLZOxETJc3IKwZ8/xaHFo30oyQ1MXRSqiCzV6OfpX5g2knaPKHhzlO 6WOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JN566uKc3ktadTMCdQh9ajk9oRH/gQn83cevsJDA16g=; b=lpR+M61yRM1L9Jul0GyRI7yTgHoeX7HKWyxCb5qr7oIQVjP58dNGRVu4K/YVTBAklv rYB+krqB+wKo2sFl6KgJn9e6zNIeLiGQ+TKcPdYrr5GyfFdoZD9mgEVBxgAX/QbBSj6T 2vCGPI8q2SfSCnNxJPAPSv6zLmb+TRdTlmdPO2reinKSjTbBXkFIq2TnwAMB7u3CKOCV yngoPh/YrP9LG3s7fYoPfB2XmffyNXiwcrkrQV6/A0wL6y59Ver45P+SUcz4uCBG1zg0 xgL4Kfiq4zKhqU6Tp09jVU1pIyLPPWNYbXQcEa4YRbW27WzsllKzIB8fEYbvUlEpg+HD II2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=WzTG+Kri; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p189-20020a6342c6000000b003816043f0e4si15407926pga.729.2022.03.22.03.51.16; Tue, 22 Mar 2022 03:51:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=WzTG+Kri; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230016AbiCVIoY (ORCPT + 99 others); Tue, 22 Mar 2022 04:44:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231570AbiCVIoX (ORCPT ); Tue, 22 Mar 2022 04:44:23 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AA2653E17; Tue, 22 Mar 2022 01:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JN566uKc3ktadTMCdQh9ajk9oRH/gQn83cevsJDA16g=; b=WzTG+Kri6NXIKO65agZ9YL1KcE +7l44pyNx6KCZIn8yUvwbZMvNBC6PeA/dLZt+Q7+sJKDDpXGG72Deis+K8Gb+YpdPx7MhIy5Rj16K 12BQVMeSiB1l6m1N3VmF3OkfDOfsmnKDu+o78MaIv/BzBUQ9VqjDTGL39pkUHNiWEoPbe9jl1bnZR Kfhb3/4qI99IGspiAwFRqssW8Ml56Da8TNNxH7CQWQ8+COZd/JO2pchMUQfT6zB3aFJelGuZ6nABd KM223BOwIOxhuL+eBB9cGjdnzlnLzc/a9cv4jjGRp3CVtNavfeyWAGX/2+WfZ+rRyflLC7Q4D6TLN Zg51C/Cw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWa6M-00ASLb-Cr; Tue, 22 Mar 2022 08:42:50 +0000 Date: Tue, 22 Mar 2022 01:42:50 -0700 From: Christoph Hellwig To: Jane Chu Cc: david@fromorbit.com, djwong@kernel.org, dan.j.williams@intel.com, hch@infradead.org, vishal.l.verma@intel.com, dave.jiang@intel.com, agk@redhat.com, snitzer@redhat.com, dm-devel@redhat.com, ira.weiny@intel.com, willy@infradead.org, vgoyal@redhat.com, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v6 2/6] x86/mce: relocate set{clear}_mce_nospec() functions Message-ID: References: <20220319062833.3136528-1-jane.chu@oracle.com> <20220319062833.3136528-3-jane.chu@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220319062833.3136528-3-jane.chu@oracle.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +EXPORT_SYMBOL(set_mce_nospec); No need for this export at all. > + > +/* Restore full speculative operation to the pfn. */ > +int clear_mce_nospec(unsigned long pfn) > +{ > + return set_memory_wb((unsigned long) pfn_to_kaddr(pfn), 1); > +} > +EXPORT_SYMBOL(clear_mce_nospec); And this should be EXPORT_SYMBOL_GPL.