Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cb10f1946d38d551e408e3ab14998c0b434bf56a.camel@redhat.com>
Subject: Re: [PATCH] qed: remove an unneed NULL check on list iterator
From:   Paolo Abeni <pabeni@redhat.com>
To:     Xiaomeng Tong <xiam0nd.tong@gmail.com>, davem@davemloft.net,
        kuba@kernel.org
Cc:     aelior@marvell.com, manishc@marvell.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Tue, 22 Mar 2022 09:52:27 +0100
In-Reply-To: <20220319043606.23292-1-xiam0nd.tong@gmail.com>
References: <20220319043606.23292-1-xiam0nd.tong@gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello,

On Sat, 2022-03-19 at 12:36 +0800, Xiaomeng Tong wrote:
> The define for_each_pci_dev(d) is:
>  while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL)
> 
> Thus, the list iterator 'd' is always non-NULL so it doesn't need to
> be checked. So just remove the unnecessary NULL check. Also remove the
> unnecessary initializer because the list iterator is always initialized.
> 
> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>

This looks like a net-next change, but net-next is now closed. please
repost 2 weeks, thanks!

Paolo