Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2814482pxp; Tue, 22 Mar 2022 06:38:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWZ5Fju1mrCWZPvohGR1gttIRgfLZoDvbgQtgqjxvb5AEOxlSWGikTrWlyNInyjfuY1+C6 X-Received: by 2002:a17:906:4785:b0:6df:6784:a7f8 with SMTP id cw5-20020a170906478500b006df6784a7f8mr27387749ejc.301.1647956313265; Tue, 22 Mar 2022 06:38:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647956313; cv=none; d=google.com; s=arc-20160816; b=jmuX7ZLnl1BD1vP8Dbe8VO8kcL51jvbkOSTUsv4RufXZOeIlrKH1ArYCZ+0lDxkpxf xoP0LzK+UmcDd4e2ioN0HkzunAXbEzrG5sxgl5C0YuGsMo5beBULQSY6R6guLeZq0DJ8 GCpu+YqazoORlXiBfff15rwxEOa6qt9MKiXwcPIOn8dWFyNvwuMIFoTEuUA1gGtKIu+m /6UpmvC4vAjq7s53bWcz5SwpQTLD4I4VOifOpWlUdkgfrKb8gxC5SHE6dqF4/G9Y5kwT T5ii2in/bWGMYMNvIBI7x/8OiUcODkbCTN11d44rQTzSLsXQTuJz7EjJsxJ1O60yA0Si UMNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Foep9qwuSy7RGj2tpo/Vjb7AfMjE/bPfHhnx/xK8Y6w=; b=MGigVCwuYdlR+1kOKz371XCIKUEqTpyWVPKnxVjLfWGgPloo2ed7sKll65sVHCGEv7 JoVEN96pnLY1RWHi6yJuMQH/qPnfx7EpNehNvt8w62CIkzk1vqyLriOvz9hFaY8i3I5T ovsomTrTf/vOMk2QGsh7PE0dBO3aOZdbE0ComMu1FofcrLmc5fdqe4MjGxOmoTHFmB7a ypMtnXUC2d03bdXq1+96r3OfeEpeMCKpebmrnjkt5N9z0xqamb7RXgJIVF5Dt2tomoIz 0XQx68Cb5KIzEXgdoSQkxVhS7vjKGEquUXojx3X+24Y0ObovF8gBnijZP8Wrf6AwRA1d Wu5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VKlKsR5I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nb24-20020a1709071c9800b006e02924244csi4555391ejc.963.2022.03.22.06.38.07; Tue, 22 Mar 2022 06:38:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VKlKsR5I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230511AbiCVJF1 (ORCPT + 99 others); Tue, 22 Mar 2022 05:05:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231705AbiCVJFV (ORCPT ); Tue, 22 Mar 2022 05:05:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4634E3ED23; Tue, 22 Mar 2022 02:03:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B592561660; Tue, 22 Mar 2022 09:03:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B053C340EC; Tue, 22 Mar 2022 09:03:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647939833; bh=fjzX2BdQHdr3ZaSisD0rP9IQyxDRzYITaNP9a8Lv4Uw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VKlKsR5IXWOK5v94DA2C7CBG4kD+8/4ucEdUKjxK0HshUFGD4Ks3nqTpoKYYNUQQh yFtaZUUaskv9i6EnHrmuxKqTOXP6RanGWgGLeztREGm12HEbFhNb4uz9dg9irRll0H oHHKGUokk775vkKikfm5va1HmL7KjWTWFAkl+nSA= Date: Mon, 21 Mar 2022 16:56:08 +0100 From: Greg Kroah-Hartman To: Will Deacon Cc: Sudeep Holla , Darren Hart , Dietmar Eggemann , Vincent Guittot , LKML , Linux Arm , "Rafael J. Wysocki" , Catalin Marinas , Peter Zijlstra , Valentin Schneider , "D . Scott Phillips" , Ilkka Koskinen , stable@vger.kernel.org, Barry Song <21cnbao@gmail.com> Subject: Re: [PATCH v3] topology: make core_mask include at least cluster_siblings Message-ID: References: <7ac47c67-0b5e-5caa-20bb-a0100a0cb78f@arm.com> <9398d7ad-30e7-890a-3e18-c3011c383585@arm.com> <20220321143021.GB11145@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220321143021.GB11145@willie-the-truck> X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DATE_IN_PAST_12_24, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 21, 2022 at 02:30:22PM +0000, Will Deacon wrote: > On Wed, Mar 16, 2022 at 03:55:41PM +0000, Sudeep Holla wrote: > > On Wed, Mar 16, 2022 at 08:20:32AM -0700, Darren Hart wrote: > > > On Wed, Mar 16, 2022 at 03:48:50PM +0100, Dietmar Eggemann wrote: > > > > [...] > > > > > > > > > > Yeah, I can see your point. It's the smaller hack. My solution just > > > > prevents us to manipulate the coregroup mask only to get the MC layer > > > > degenerated by the core topology code. But people might say that's a > > > > clever thing to do here. So I'm fine with your original solution as well. > > > > > > > > [...] > > > > > > Thanks Dietmar, > > > > > > Sudeep, do we have sufficient consensus to pull in this patch? > > > > Indeed. I have already Acked, and sure after all these discussions we have > > concluded that this is the best we can do though not matches everyone's taste. > > > > Greg or Will(not sure why he had asked since v3 doesn't touch arm64), > > Can one of you pick this patch ? > > Right, this doesn't touch arm64 any more so I don't think I'm the right > person to queue it. It's too late for 5.18-rc1. Please rebase and resend it after that is out and I will be glad to queue it up. thanks, greg k-h