Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Mar 2022 18:13:42 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Chen-Yu Tsai <wenst@chromium.org>
Cc:     Hsin-Yi Wang <hsinyi@chromium.org>,
        dri-devel@lists.freedesktop.org, Jonas Karlman <jonas@kwiboo.se>,
        David Airlie <airlied@linux.ie>,
        Robert Foss <robert.foss@linaro.org>, qwen@analogixsemi.com,
        Neil Armstrong <narmstrong@baylibre.com>,
        linux-kernel@vger.kernel.org,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        treapking@chromium.org, pihsun@chromium.org,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Andrzej Hajda <andrzej.hajda@intel.com>, tzungbi@google.com,
        bliang@analogixsemi.com
Subject: Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal
 status
Message-ID: <20220322101342.GA1493353@anxtwsw-Precision-3640-Tower>
References: <20220322080213.1487134-1-xji@analogixsemi.com>
 <CAJMQK-j+PhB6dZBuKG3NtW94oT0bVkp9G1bXhmyZLgYOmTCgog@mail.gmail.com>
 <20220322085208.GA1487511@anxtwsw-Precision-3640-Tower>
 <CAGXv+5Gddu8VU7xjX-r2=u85i7Ut=_6JpQV6py52OyzEkpezTg@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGXv+5Gddu8VU7xjX-r2=u85i7Ut=_6JpQV6py52OyzEkpezTg@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1G05xl5miLlkoctskU/vaehHztNOUcdzx/q0F7yqRhaAa5sC7SV8zyO9x9zL?=
 =?us-ascii?Q?XbuhJFJ0G91Y+7ryGIJ0+LF85z+2Q9Xlb29EFyI3o/+wdDjmIRoUhcD3HT4M?=
 =?us-ascii?Q?ECGCQyOj2PPaYcVToLOFaYxJT6JtcF5+ljpE1F+KTOeNzlE0bjmv2Llkg2nF?=
 =?us-ascii?Q?PqToBAI4oE7tc+ZkWWNjdJGn5uZzejFsp6Y3xcttkhc0U/ppJX1CYGjoBu1q?=
 =?us-ascii?Q?KL/gX59lhzzqlqSpDtqKW2AJ0SIa7CBdSyahOyMOmMA82sIfMzoIPIGdC0Xk?=
 =?us-ascii?Q?UnwcrqxjfcMGvUZJrgNE4TG04gHh9tUD/zu4XLaOLMzDUpX4G902Ji4f/WTK?=
 =?us-ascii?Q?PG/XRPdGc8zDBMFksj+SuAHctPHuRvG8mTJ2XIGuPisng15kGJc2rGBsbkJg?=
 =?us-ascii?Q?EFnBjrtFDBfRtL3bnGRK6uTzixwExuyag1EttJttElZ+UKQz2hEF5+RBWP9s?=
 =?us-ascii?Q?Fm/9SofKrSSbdsq+WMOFGCUMvSgncAfYX6uflZr7tqt+QD9m53zPqsnUYAfO?=
 =?us-ascii?Q?JNXQ2Z4xfud9eORytZ9GMgUSp0ambKZYo0XSDBypkxu0k/IMIx0e2hQ0a/NA?=
 =?us-ascii?Q?DpWwPxym+3olfzPNNTRRO5gk3XIyEi3i61L+DzTLe5dKeX431L+h3uo6dMc9?=
 =?us-ascii?Q?cj3XzBR3U0tbTIf6nIx7T1QWRqTk9rvLj5rxg6qgI5gq3e9/XbsIow6PTDdv?=
 =?us-ascii?Q?bjWTGZG1bUPnEkcYD3C3ilvKbF87mPvYTG73DO/bn8UUnLAhomgY64DQjJJN?=
 =?us-ascii?Q?97amo7bpQMC4k03W9usHSpaOD4yEdF4qF7ZANvWCPnVTw6G1QA0c9LUFzRSL?=
 =?us-ascii?Q?PTQqQU8zBMb6JnUfvfs9q/9/x3ZobqfyFViUIkEgzt69qvqUCYKdJBStl40v?=
 =?us-ascii?Q?G/I0PR3qYZwnb2yhSCgS+m/Y5r0q/yWFzTkiUAs5zSA2JXlwm2TxODTYvmPn?=
 =?us-ascii?Q?1472eSGG4oAhG63CYZ8NPjK1n4NVUegLuWo+9riwi9KYtfAttYe5CJirmVxL?=
 =?us-ascii?Q?TB8ZArw3+8ztOBeXxaY+vIIXP5hA9QqmX59ZexKxCaJaf4/uTEZmpc9NKte8?=
 =?us-ascii?Q?hkI6UsEbZohYPCL5UWUUYXDfAVNFy1Cax7qWCcEhWl0WSSoHvZ99tNLzUe43?=
 =?us-ascii?Q?TY9NMVI1hPltE4GWgTQsd3WggYHFce0QRDvEe+U7GG/LcYTCsG+eDC1PHtyv?=
 =?us-ascii?Q?6hC6STKLMiogZqiEIkcurHpIQr0UY9W+N1NDLhPF1LH64jjEM59n2iQNpnVl?=
 =?us-ascii?Q?cZtCi7CxHojj6Odmt4MVEvdrN9lZx2a3QYik9Bj1XXhXbcPkjp/1tEy/B1bc?=
 =?us-ascii?Q?6FfGXy2XgQZILtIefOeWjTLSdfwkyER3IcjDEHI2y6oCB8dAUy2T+28BHfSk?=
 =?us-ascii?Q?6Fq9t5CbQgnI8gaQYCT2PoOg21b+cbZmEaRVSZWdUGjR+3Gu8Dvpi1ruL9r4?=
 =?us-ascii?Q?QqJY+h3nwu8kMff9P9FFAP3X9RXlsvLz?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 84138553-5f88-4ab1-572b-08da0beca7b5
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2022 10:13:48.2725
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wgQ5W44xYoHZlPC1AC7f6YMtjHUp0IQgykqzuBm8WyTvBN19TyP4wOG0QAtvCmNr7pXEaflVLo1NwDzZx3DUTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR04MB4228
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 22, 2022 at 05:16:43PM +0800, Chen-Yu Tsai wrote:
> On Tue, Mar 22, 2022 at 4:52 PM Xin Ji <xji@analogixsemi.com> wrote:
> >
> > On Tue, Mar 22, 2022 at 04:43:20PM +0800, Hsin-Yi Wang wrote:
> > > On Tue, Mar 22, 2022 at 4:02 PM Xin Ji <xji@analogixsemi.com> wrote:
> > > >
> > > > As downstream sink was set into standby mode while bridge disabled,
> > > > this patch used for setting downstream sink into normal status
> > > > while enable bridge.
> > > >
> > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > Reviewed-by: Pin-Yen Lin <treapking@chromium.org>
> > > >
> > > > ---
> > > > V1 -> V2: use dev_dbg replace of dev_info
> > > > ---
> > > >  drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++++++
> > > >  1 file changed, 8 insertions(+)
> > > >
> > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > index 9a2a19ad4202..dcf3275a00fe 100644
> > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > @@ -924,12 +924,20 @@ static void anx7625_dp_start(struct anx7625_data *ctx)
> > > >  {
> > > >         int ret;
> > > >         struct device *dev = &ctx->client->dev;
> > > > +       u8 data;
> > > >
> > > >         if (!ctx->display_timing_valid) {
> > > >                 DRM_DEV_ERROR(dev, "mipi not set display timing yet.\n");
> > > >                 return;
> > > >         }
> > > >
> > > > +       dev_dbg(dev, "set downstream sink into normal\n");
> > > > +       /* Downstream sink enter into normal mode */
> > > > +       data = 1;
> > > > +       ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, 0x000600, 1, &data);
> > > > +       if (ret < 0)
> > > > +               dev_err(dev, "IO error : set sink into normal mode fail\n");
> > > > +
> > >
> > > The driver uses DRM_DEV_* for logs. Can we use this?
> > Hi Hsin-Yi, as comment in drm/drm_print.h:
> > "NOTE: this is deprecated in favor of drm_dbg". DRM bridge driver not
> > use DRM_DEV_* any more. I'll send a patch to replace all of DRM_DEV_*
> > later.
> 
> drm_dbg is better than dev_dbg though. With the former, you still get the
> option to control it with the drm.debug module parameter, unlike the latter
> which normally gets compiled out.
> 
> Please use drm_dbg*.
> 
> ChenYu

Hi ChenYu, the parameter of drm_dbg is "drm", if use drm_dbg, it will
change more code, I'll consider to upstream new patch to replace all of
them later.

Thanks,
Xin
> 
> > Thanks,
> > Xin
> > >
> > > >         /* Disable HDCP */
> > > >         anx7625_write_and(ctx, ctx->i2c.rx_p1_client, 0xee, 0x9f);
> > > >
> > > > --
> > > > 2.25.1
> > > >