Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2872941pxp; Tue, 22 Mar 2022 07:38:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzef2qyoajEuehgbA5k2AGy7eU9XWrLAeunXeSumtzxe2GpNIGda1wTMIdHC4Ek7ZPUVX+g X-Received: by 2002:a17:906:38da:b0:6da:8221:c82f with SMTP id r26-20020a17090638da00b006da8221c82fmr25860751ejd.443.1647959897600; Tue, 22 Mar 2022 07:38:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647959897; cv=none; d=google.com; s=arc-20160816; b=Dn7n9tPhY9RO2UhcLaEIbfJLe6bJDigATobj7pflybD3MPeLiTFmfO5GnOJ6QwtRhJ lMtejGvPNvMcjAHvYX68yKhReHHGyh4Xo1+R3vhVrj8LnuM7l/vtksYSO2zAbJtBjjXO vnpCgty33d4cS/smPreTwFQ7+7vhhvfgc9KaVC2khu4BCWLo8mSnilvO8xV+WK+CVS7S F0d9OERv3/F4wSQ2k0vY09NOThrUdNaYsgzz/iZpAwi/MCaaCbF1TQCiviRaJ8CDh4O7 PvB0STeknHI/+6ScmIuPWE/iEExKtAce7Ngvu+P61BUO0YJz5Svl62MCZyog5wMylyST ptdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=smeZKydfYPmYKL/wBGLkiYT4K39RFeTlS3mi5VsQIR0=; b=DkFCm51YcVSMNhL0LHkNOVj7ZaRR50Qyzx6AWx3603fKVqDqC5sn0lK/dy5QncPFuT v4PecyzAGqjOAckx4TUoDzXTawrijAErcXRdzHfRC0F/BkXJjHLqNGAc8w1BZmlfZsZR CZ9AP0eYVpv+pmEWqQ3CzI4XR25oor5Ka5VzfRxipumsoJOMDvPDMsaUQvQ7tHQggkDu JmP4gzzv/Dst9qtrgBVmyu/1ZfL9G4M1n3hO+xTQYVxKHupabDgZmT4Ha+hppHuHkmnj WE3ypolPTFuuEz4EQ/xWYqYEkEuwvHs+xPzzaOAp17SBvCIKBzqypTm3G687EYdA4Ee7 x2Pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e12-20020a50a68c000000b00418c2b5be3asi12167538edc.284.2022.03.22.07.37.52; Tue, 22 Mar 2022 07:38:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234073AbiCVLUU (ORCPT + 99 others); Tue, 22 Mar 2022 07:20:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232248AbiCVLUS (ORCPT ); Tue, 22 Mar 2022 07:20:18 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E23AD26DB; Tue, 22 Mar 2022 04:18:51 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 5189868AFE; Tue, 22 Mar 2022 12:18:48 +0100 (CET) Date: Tue, 22 Mar 2022 12:18:48 +0100 From: Christoph Hellwig To: John Garry Cc: axboe@kernel.dk, damien.lemoal@opensource.wdc.com, bvanassche@acm.org, jejb@linux.ibm.com, martin.petersen@oracle.com, hch@lst.de, ming.lei@redhat.com, hare@suse.de, chenxiang66@hisilicon.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, dm-devel@redhat.com, beanhuo@micron.com Subject: Re: [PATCH 01/11] blk-mq: Add blk_mq_init_queue_ops() Message-ID: <20220322111848.GA29270@lst.de> References: <1647945585-197349-1-git-send-email-john.garry@huawei.com> <1647945585-197349-2-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1647945585-197349-2-git-send-email-john.garry@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 22, 2022 at 06:39:35PM +0800, John Garry wrote: > Add an API to allocate a request queue which accepts a custom set of > blk_mq_ops for that request queue. > > The reason which we may want custom ops is for queuing requests which we > don't want to go through the normal queuing path. Eww. I really do not think we should do separate ops per queue, as that is going to get us into a deep mess eventually.