Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220321163055.4058-1-pali@kernel.org>
In-Reply-To: <20220321163055.4058-1-pali@kernel.org>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 22 Mar 2022 16:29:08 +0200
Message-ID: <CAHp75VddDG-ZJpbAb5ZhKaMpP0L+CMEx2pcYy3FOMiaxNydCWA@mail.gmail.com>
Subject: Re: [PATCH 0/3] serial: Fix support for UPF_SPD_* flags
To:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Johan Hovold <johan@kernel.org>,
        =?UTF-8?B?TWFyZWsgQmVow7pu?= <kabel@kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Mar 21, 2022 at 11:07 PM Pali Roh=C3=A1r <pali@kernel.org> wrote:
>
> Support for UPF_SPD_* flags is currently broken in more drivers for two
> reasons. First one is that uart_update_timeout() function does not

the uart_update_timeout()

> calculate timeout for UPF_SPD_CUST flag correctly. Second reason is that
> userspace termios structre is modified by most drivers after each

structure

...

> (error handling was ommited for simplification)

omitted

> After calling set_active_spd_cust_baud() function SPD custom divisor
> should be active and therefore is_spd_cust_active() should return true.
>
> But it is not active (cfgetospeed does not return B38400) and this patch
> series should fix it. I have tested it with 8250 driver.

drivers

> Originally Johan Hovold reported that there may be issue with these
> ASYNC_SPD_FLAGS in email:
> https://lore.kernel.org/linux-serial/20211007133146.28949-1-johan@kernel.=
org/
>
>
> Johan, Greg, could you please test these patches if there is not any
> regression?

I'm wondering why we are still supporting this ugly hack?
Doesn't BOTHER work for you?

I would rather expect to have this removed completely.

--=20
With Best Regards,
Andy Shevchenko