Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Mar 2022 15:41:15 +0000
Message-ID: <87bkxyxaec.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Rob Herring <robh@kernel.org>
Cc:     Robin Murphy <robin.murphy@arm.com>,
        dann frazier <dann.frazier@canonical.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        PCI <linux-pci@vger.kernel.org>,
        Toan Le <toan@os.amperecomputing.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        =?UTF-8?B?U3TDqXBo?= =?UTF-8?B?YW5l?= Graber 
        <stgraber@ubuntu.com>,
        Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH v2 0/2] PCI: xgene: Restore working PCIe functionnality
In-Reply-To: <Yjnfr7V6egc1sewb@robh.at.kernel.org>
References: <20220321104843.949645-1-maz@kernel.org>
        <CAL_JsqJacC6GbNebTfYyUEScROCFN4+Fg2v1_iYFfqAvW4E9Vw@mail.gmail.com>
        <87h77rxnyl.wl-maz@kernel.org>
        <CAL_JsqK57KpZmzCE=86dLcHK4Ws_0w0ga4_qoYUe2GwFNpDzRw@mail.gmail.com>
        <87fsnbxgau.wl-maz@kernel.org>
        <e52c8cbd-031b-848f-3d78-dff8b93bd416@arm.com>
        <61809b8f-acaa-bae2-ac5e-aa47c55eea23@arm.com>
        <Yjnfr7V6egc1sewb@robh.at.kernel.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 22 Mar 2022 14:39:43 +0000,
Rob Herring <robh@kernel.org> wrote:
>=20
> On Tue, Mar 22, 2022 at 01:16:35PM +0000, Robin Murphy wrote:
> > On 2022-03-21 20:06, Robin Murphy wrote:
> > > On 2022-03-21 19:21, Marc Zyngier wrote:
> > > > On Mon, 21 Mar 2022 18:03:27 +0000,
> > > > Rob Herring <robh@kernel.org> wrote:
> > > > >=20
> > > > > On Mon, Mar 21, 2022 at 11:36 AM Marc Zyngier <maz@kernel.org> wr=
ote:
> > > > > >=20
> > > > > > On Mon, 21 Mar 2022 15:17:34 +0000,
> > > > > > Rob Herring <robh@kernel.org> wrote:
> > > > > > >=20
> > > > > > > On Mon, Mar 21, 2022 at 5:49 AM Marc Zyngier <maz@kernel.org>=
 wrote:
> > > > > > > >=20
> > > > > > > For XGene-1, I'd still like to understand what the issue is. =
Reverting
> > > > > > > the first fix and fixing 'dma-ranges' should have fixed it. I=
 need a
> > > > > > > dump of how the IB registers are initialized in both cases. I=
'm not
> > > > > > > saying changing 'dma-ranges' in the firmware is going to be r=
equired
> > > > > > > here. There's a couple of other ways we could fix that withou=
t a
> > > > > > > firmware change, but first I need to understand why it broke.
> > > > > >=20
> > > > > > Reverting 6dce5aa59e0b was enough for me, without changing anyt=
hing
> > > > > > else.
> > > > >=20
> > > > > Meaning c7a75d07827a didn't matter for you. I'm not sure that it =
would.
> > > > >=20
> > > > > Can you tell me what 'dma-ranges' contains on your system?
> > > >=20
> > > > Each pcie node (all 5 of them) has:
> > > >=20
> > > > dma-ranges =3D <0x42000000 0x80 0x00 0x80 0x00 0x00 0x80000000
> > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 0x42000000 0x00 0x00 0x00 0x00 0x80 0x00>;
>=20
> This is the same as what St=C3=A9phane has for Merlin. So c7a75d07827a ("=
PCI:=20
> xgene: Fix IB window setup") should have fixed Mustang.

Should, but didn't. The DT also carries additional properties:

ib-ranges =3D <0x42000000 0x40 0x00 0x40 0x00 0x40 0x00
             0x00 0x00 0x79000000 0x00 0x79000000 0x00 0x800000>;

which the driver ignores, but that could be relevant. FWIW, I've
stashed the DT at [1].

	M.

[1] http://www.loen.fr/tmp/mustang.dts

--=20
Without deviation from the norm, progress is not possible.