Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220310150905.1.Ie0a005d7a763d501e03b7abe8ee968ca99d23282@changeid>
 <CAMRc=McbY6vK_M9fP7Hzg8LE9ANOZKN49hmBFn92YFH+2ToM8w@mail.gmail.com>
 <CACRpkdb-W10YAQff_dTUL7B-DH01Z9nn7cE71Zv5xjALtDGQ1g@mail.gmail.com> <CA+ASDXOOzECbCBoehKjmFjLTtsssk9AH1NabA=FSRvoVWp8KMQ@mail.gmail.com>
In-Reply-To: <CA+ASDXOOzECbCBoehKjmFjLTtsssk9AH1NabA=FSRvoVWp8KMQ@mail.gmail.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Tue, 22 Mar 2022 14:14:13 +0100
Message-ID: <CAMuHMdUANNFNt6yuTEcadkdVhKHDmVAVofWOfFpW-r2wkL=vdQ@mail.gmail.com>
Subject: Re: [PATCH] gpio: Drop CONFIG_DEBUG_GPIO
To:     Brian Norris <briannorris@chromium.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Jianqun Xu <jay.xu@rock-chips.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Brian,

On Tue, Mar 15, 2022 at 1:19 AM Brian Norris <briannorris@chromium.org> wrote:
> On Mon, Mar 14, 2022 at 3:23 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Mon, Mar 14, 2022 at 4:00 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > I like it. It's true we don't see many of those DEBUG constructs
> > > anymore nowadays and overhead for might_sleep() and WARN_ON() is
> > > negligible.
> >
> > I agree.  I have something similar for pinctrl, maybe that needs to
> > go too.
>
> Huh, yeah, CONFIG_DEBUG_PINCTRL does look awfully similar, and I just
> didn't notice because we don't happen to have it enabled for Chromium
> kernels. We happen to have CONFIG_DEBUG_GPIO enabled though, and the
> "new" rockchip-gpio log messages triggered me :)
>
> I guess one difference is that CONFIG_DEBUG_PINCTRL is almost
> exclusively (aside from some renesas drivers?) about extra logging and
> less about interesting checks that one might want to enable in more
> general settings. So it's a clearer call to make that people generally
> want it disabled.

For the Renesas pinctrl drivers, it enables sanity checks on the pin
control tables, which you definitely do not want in your production
kernel.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds