Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220320064529.12827-1-sensor1010@163.com> <CAHp75VfkDbO3J=MgTdRF_UyMvZ9XCJEQcEOUEBuyqEwnrNwbsA@mail.gmail.com>
In-Reply-To: <CAHp75VfkDbO3J=MgTdRF_UyMvZ9XCJEQcEOUEBuyqEwnrNwbsA@mail.gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 22 Mar 2022 16:56:02 +0200
Message-ID: <CAHp75Vc5FZ-N68vDhyGhCObUdek6JFccotctH-C5KmZ_boL6Wg@mail.gmail.com>
Subject: Re: [PATCH] drivers/bus/brcmstb_gisb.c : Remove the
 suppress_bind_attrs attribute of the driver
To:     lizhe <sensor1010@163.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Mar 22, 2022 at 4:52 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Tue, Mar 22, 2022 at 12:41 AM lizhe <sensor1010@163.com> wrote:
> >
> > Even if platform_driver does not set suppress_bind_attrs attribute,
> > when registering with platform_driver_probe,  the value of
> > suppress_bind_attrs is still true, see __platform_driver_probe()
>
> Any reasons it can't be switched to builtin_platform_driver() macro
> and hence constification of the driver structure?

Ah, the patch that brought that assignment actually allows to built
the driver as a module, so, the correct patch would be to switch to
module_platform_driver() I suppose.

-- 
With Best Regards,
Andy Shevchenko