Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <Ydm7ReZWQPrbIugn@gmail.com> <YjBr10JXLGHfEFfi@gmail.com>
 <CAKBF=pvWzuPx0JB3XZ-v+i7KGbhMQTgH6xtii_Bed+qKRFx+ww@mail.gmail.com> <b8095bf8-961f-827c-2bd6-2ffa6298b730@infradead.org>
In-Reply-To: <b8095bf8-961f-827c-2bd6-2ffa6298b730@infradead.org>
From:   Kari Argillander <kari.argillander@gmail.com>
Date:   Tue, 22 Mar 2022 18:22:24 +0200
Message-ID: <CAC=eVgQCs97N_jkB1LKOdxhd=Yvgf1SZfBWcDbG2dGhsihXLqw@mail.gmail.com>
Subject: Re: [TREE] "Fast Kernel Headers" Tree -v3
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Kari Argillander <kari.argillander@stargateuniverse.net>,
        Ingo Molnar <mingo@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arch@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ard Biesheuvel <ardb@kernel.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

22.03.2022 17.37 Randy Dunlap (rdunlap@infradead.org) wrote:
>
> Hi Kari,
>
> On 3/22/22 00:59, Kari Argillander wrote:
> > 15.3.2022 12.35 Ingo Molnar (mingo@kernel.org) wrote:
> >>
> >> This is -v3 of the "Fast Kernel Headers" tree, which is an ongoing rew=
ork
> >> of the Linux kernel's header hierarchy & header dependencies, with the=
 dual
> >> goals of:
> >>
> >>  - speeding up the kernel build (both absolute and incremental build t=
imes)
> >>
> >>  - decoupling subsystem type & API definitions from each other
> >>
> >> The fast-headers tree consists of over 25 sub-trees internally, spanni=
ng
> >> over 2,300 commits, which can be found at:
> >>
> >>     git://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git master
> >
> > I have had problems to build master branch (defconfig) with gcc9
> >     gcc (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
> >
> > I did also test v2 and problems where there too. I have no problem with=
 gcc10 or
> > Clang11. Error I get is:
> >
> > In file included from ./include/linux/rcuwait_api.h:7,
> >                  from ./include/linux/rcuwait.h:6,
> >                  from ./include/linux/irq_work.h:7,
> >                  from ./include/linux/perf_event_types.h:44,
> >                  from ./include/linux/perf_event_api.h:17,
> >                  from arch/x86/kernel/kprobes/opt.c:8:
> > ./include/linux/rcuwait_api.h: In function =E2=80=98rcuwait_active=E2=
=80=99:
> > ./include/linux/rcupdate.h:328:9: error: dereferencing pointer to
> > incomplete type =E2=80=98struct task_struct=E2=80=99
> >   328 |  typeof(*p) *local =3D (typeof(*p) *__force)READ_ONCE(p); \
> >       |         ^
> > ./include/linux/rcupdate.h:439:31: note: in expansion of macro
> > =E2=80=98__rcu_access_pointer=E2=80=99
> >   439 | #define rcu_access_pointer(p) __rcu_access_pointer((p),
> > __UNIQUE_ID(rcu), __rcu)
> >       |                               ^~~~~~~~~~~~~~~~~~~~
> > ./include/linux/rcuwait_api.h:15:11: note: in expansion of macro
> > =E2=80=98rcu_access_pointer=E2=80=99
> >    15 |  return !!rcu_access_pointer(w->task);
> >
> >     Argillander
>
> You could try the patch here:
> https://lore.kernel.org/all/917e9ce0-c8cf-61b2-d1ba-ebf25bbd979d@infradea=
d.org/

I have to edit it to <linux/cgroup_types.h> as there is no <linux/cgroup-de=
fs.h>
with fast headers. I also tried a couple other things but it didn't
seem to make a
difference.

> although the build error that it fixes doesn't look exactly the same
> as yours.

Quite close still. Maybe I should try to bisect this and I will also
see how bisectable
this branch is.

> >> There's various changes in -v3, and it's now ported to the latest kern=
el
> >> (v5.17-rc8).
> >>
> >> Diffstat difference:
> >>
> >>  -v2: 25332 files changed, 178498 insertions(+), 74790 deletions(-)
> >>  -v3: 25513 files changed, 180947 insertions(+), 74572 deletions(-)
>
>
> --
> ~Randy