Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f4b82d3d-5c8b-2973-4918-5308210e4431@redhat.com>
Date:   Tue, 22 Mar 2022 12:28:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] winmate-fm07-keys: Winmate FM07/FM07P buttons
Content-Language: en-US
To:     Daniel Beer <daniel.beer@tirotech.co.nz>
Cc:     Mark Gross <markgross@kernel.org>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <6237f057.1c69fb81.1689.fec7@mx.google.com>
 <2cf4e8b2-dfaa-dd7d-9c00-c7d58eeb367b@redhat.com>
 <20220321193258.GA31646@nyquist.nev>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20220321193258.GA31646@nyquist.nev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 3/21/22 20:32, Daniel Beer wrote:
> On Mon, Mar 21, 2022 at 11:22:40AM +0100, Hans de Goede wrote:
>> Do you have control of the firmware on this device?
>>
>> If yes then IMHO it would be better to implement this in ACPI
>> using the intel-hid fw API for this, see:
> 
> Hi Hans,
> 
> Unfortunately not. I don't work for Winmate and they haven't provided
> any documentation on this.

Ok, in that case please send a v2 addressing Barnabás' remarks.

I'll do a full review of v2 and then depending on what I find
merge it, or ask you to do a v3.

Regards,

Hans