Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <381b7144-3e60-a825-06fb-ea15ecb4c365@linux.ibm.com>
Date:   Tue, 22 Mar 2022 09:41:22 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH v18 14/18] s390/vfio-ap: sysfs attribute to display the
 guest's matrix
Content-Language: en-US
To:     jjherne@linux.ibm.com, linux-s390@vger.kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc:     freude@linux.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com,
        mjrosato@linux.ibm.com, pasic@linux.ibm.com,
        alex.williamson@redhat.com, kwankhede@nvidia.com,
        fiuczy@linux.ibm.com
References: <20220215005040.52697-1-akrowiak@linux.ibm.com>
 <20220215005040.52697-15-akrowiak@linux.ibm.com>
 <d66ef5e1-9a77-a71c-e182-ca1f3fc17574@linux.ibm.com>
From:   Tony Krowiak <akrowiak@linux.ibm.com>
In-Reply-To: <d66ef5e1-9a77-a71c-e182-ca1f3fc17574@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 3/22/22 09:22, Jason J. Herne wrote:
> On 2/14/22 19:50, Tony Krowiak wrote:
>> The matrix of adapters and domains configured in a guest's APCB may
>> differ from the matrix of adapters and domains assigned to the matrix 
>> mdev,
>> so this patch introduces a sysfs attribute to display the matrix of
>> adapters and domains that are or will be assigned to the APCB of a guest
>> that is or will be using the matrix mdev. For a matrix mdev denoted by
>> $uuid, the guest matrix can be displayed as follows:
>>
>>     cat /sys/devices/vfio_ap/matrix/$uuid/guest_matrix
> My OCD wants you to name this matrix_guest instead of guest_matrix. 
> Simply
> because then "matrix" and "matrix_guest" will be grouped together when 
> doing
> an ls on the parent directory. As a system admin, its the little 
> things that
> make the difference :) Please consider... though I won't withhold an 
> R-b for
> it.

I am going to leave it as guest_matrix for two reasons:
1. To me, the name matrix_guest reads like the guest belongs to the 
matrix rather
     than the matrix belonging to the guest.
2. Changing it will require changes to all of the automated test cases 
that check
     sysfs to determine whether the attribute is present and I don't 
think the juice
     is worth the squeeze.

>
> Reviewed-by: Jason J. Herne <jjherne@linux.ibm.com>
>