Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3284474pxp; Tue, 22 Mar 2022 16:27:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYEeJMHLbLMGhvSRJQ7mCZfYi1WUE2xpBvE4ITAvPel7GfWq9Y0LTTxWz7k2TRU0VfaDa4 X-Received: by 2002:a17:902:d50c:b0:154:172:3688 with SMTP id b12-20020a170902d50c00b0015401723688mr20830950plg.17.1647991645956; Tue, 22 Mar 2022 16:27:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647991645; cv=none; d=google.com; s=arc-20160816; b=jMxhCK5YYUOdpvFvF//kpRPLaJ/LopTV4cNDDwNVoidKtvnFUkmzOa3IOWkTAx1Bzt wi+7zBMN9/LVVf2YJYcKSNcSZA9GSnDk226AFQzBQoweZJZx1iD2uBmU7luA7r2GeUHC RKRiGmtj+bKS0jcFFMyDWLuIROcY0Nmd1dwgyBJN1/lxthMMFtoyhlxRUiPxVjYJpxn2 L5pmSD4l2EiJnz5spgIaea888WTJeC7/4Hwds0ZFJ3iQeA4itvr+7Oh8WUKZmrJP0uS1 E+J6uLckijiK7ZzgadZsUkfjX6wXTJKzXHm0Z/5rcLYY87QgxPp2WJRG6SnQMpoY+mnt keTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=CTZu+aAjGtXbM3jBypGogmPu5vUABzZBTRhCCSqoFwc=; b=LcbKGW00SY1mUvTxni7NbkUK7afGU5PKC2HOju3PcyXx/HMOqtzWa7Hb33pemHTPmD +rILvYMJroIn+SkW4fFyg7O/q8FKuanB868iRwrpjWlZvag4V8Mn0gsRfNh0LbpTM+3V APMUQ3GN7d6hiYUHYG5UJkDAEB7mBUDlJhwRLiQgaMP5ZosP5VcYO1gAMcuwrl57t1BB PpwS55mDSIYKER+6iyjZc1JLZM8eBG+EhZclpSw+9rx5Wq1BaV6N232q7VsdLewrRl/b ytKBMKPrN4R0nBx1oT4UnREj7w2AqqurJhxu+MYhRd+sjW1W+MyXBr1pDE+gg+Svfjc9 UqzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="fCZjD/Fl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j20-20020aa78dd4000000b004fa3a8e009asi11275638pfr.337.2022.03.22.16.27.04; Tue, 22 Mar 2022 16:27:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="fCZjD/Fl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235251AbiCVOy4 (ORCPT + 99 others); Tue, 22 Mar 2022 10:54:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233916AbiCVOyy (ORCPT ); Tue, 22 Mar 2022 10:54:54 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A0783525D for ; Tue, 22 Mar 2022 07:53:26 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id o10so17994280ejd.1 for ; Tue, 22 Mar 2022 07:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CTZu+aAjGtXbM3jBypGogmPu5vUABzZBTRhCCSqoFwc=; b=fCZjD/FlPyo91HLM3S5Xv48gNzf9IYzMQtgPIPjHfvZ8JuuhVINkE/8wj+OwFkJ68N 3X85MRvQAnvo4jpNcVwzlbeYFY0pzy6rdCf1mJYEIGnCo1xfX1T0tQaMhMCDPTUnU4pB 5KYpF1Tu1o+dVn9usYerGsCCPhTN53Q89Tuiz7stPwpcPhIF2y6tU2qmE/b0PVsAwql0 pB8ngzOAtJoUX4qqfJz5mJedeGTBzo6f9Z25PU3CclCeGQLHAo2LltOzdqeXwTbv+dS5 5NOYdtdH3hDBm8GxKYe8Cqgtm8Tj5YhyAqNdydyota3BDDm2FsroiV2xf8pTMhw6wC6c 8KQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CTZu+aAjGtXbM3jBypGogmPu5vUABzZBTRhCCSqoFwc=; b=cjgrpCBZ0pF1zYcX3rw6ES5YIlqyJ+xCQhC+W4IabLYzlnKn8Ih170vySVj4hrxUNK zwbuyYjwRlUYlPRLOAYrgTPoYwkQAzzs9jOBYPEEzNhsYAT3hGlfKflDkrOZfk5D+r3+ 3lXrT4fw78xx0AvRF/8HrZe5fq4pdlfky3p4J8bEY3mN6Bca3fXCcOk20T8Q6JKJIBU6 MpEA1SvNlSlWVReVxiMhZPA4ZcBWHum5JmFWqj6L+lF7YYwokMeD3D/UNJ/wUQlJbBks yfje5u1eVMZvEiJkpmuKHLmlKtOFERkk2xLjidaFUCXTKR6/gKiwA8Mn1PhvBek1Qd0U hwDw== X-Gm-Message-State: AOAM530Dcr/sZS0pbj4gMsKXrN8gcxvWsV7i3TelVb7RbQHOQflZI349 RwOtGWzXFuuKRGfYHmkETw1gmXnayh89V9cWt+A= X-Received: by 2002:a17:907:e8d:b0:6e0:19e7:9549 with SMTP id ho13-20020a1709070e8d00b006e019e79549mr8735310ejc.44.1647960804724; Tue, 22 Mar 2022 07:53:24 -0700 (PDT) MIME-Version: 1.0 References: <20220320064529.12827-1-sensor1010@163.com> In-Reply-To: <20220320064529.12827-1-sensor1010@163.com> From: Andy Shevchenko Date: Tue, 22 Mar 2022 16:52:14 +0200 Message-ID: Subject: Re: [PATCH] drivers/bus/brcmstb_gisb.c : Remove the suppress_bind_attrs attribute of the driver To: lizhe Cc: Florian Fainelli , bcm-kernel-feedback-list , linux-arm Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 22, 2022 at 12:41 AM lizhe wrote: > > Even if platform_driver does not set suppress_bind_attrs attribute, > when registering with platform_driver_probe, the value of > suppress_bind_attrs is still true, see __platform_driver_probe() Any reasons it can't be switched to builtin_platform_driver() macro and hence constification the driver structure? -- With Best Regards, Andy Shevchenko