Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH linux-next] selftests/vDSO: fix array_size.cocci warning
To:     Guo Zhengkui <guozhengkui@vivo.com>, Shuah Khan <shuah@kernel.org>,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     zhengkui_guo@outlook.com, Shuah Khan <skhan@linuxfoundation.org>
References: <20220321052757.10918-1-guozhengkui@vivo.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <489c8759-27c6-c71f-987d-3fc6d255f3b8@linuxfoundation.org>
Date:   Tue, 22 Mar 2022 17:01:01 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20220321052757.10918-1-guozhengkui@vivo.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/20/22 11:27 PM, Guo Zhengkui wrote:
> Fix the following coccicheck warning:
> 
> tools/testing/selftests/vDSO/vdso_test_correctness.c:309:46-47:
> WARNING: Use ARRAY_SIZE
> tools/testing/selftests/vDSO/vdso_test_correctness.c:373:46-47:
> WARNING: Use ARRAY_SIZE
> 
> It has been tested with gcc (Debian 8.3.0-6) 8.3.0 on x86_64.
> 
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
> ---
>   tools/testing/selftests/vDSO/vdso_test_correctness.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/testing/selftests/vDSO/vdso_test_correctness.c b/tools/testing/selftests/vDSO/vdso_test_correctness.c
> index c4aea794725a..e691a3cf1491 100644
> --- a/tools/testing/selftests/vDSO/vdso_test_correctness.c
> +++ b/tools/testing/selftests/vDSO/vdso_test_correctness.c
> @@ -20,6 +20,7 @@
>   #include <limits.h>
>   
>   #include "vdso_config.h"
> +#include "../kselftest.h"
>   
>   static const char **name;
>   
> @@ -306,10 +307,8 @@ static void test_clock_gettime(void)
>   		return;
>   	}
>   
> -	for (int clock = 0; clock < sizeof(clocknames) / sizeof(clocknames[0]);
> -	     clock++) {
> +	for (int clock = 0; clock < ARRAY_SIZE(clocknames); clock++)
>   		test_one_clock_gettime(clock, clocknames[clock]);
> -	}
>   
>   	/* Also test some invalid clock ids */
>   	test_one_clock_gettime(-1, "invalid");
> @@ -370,10 +369,8 @@ static void test_clock_gettime64(void)
>   		return;
>   	}
>   
> -	for (int clock = 0; clock < sizeof(clocknames) / sizeof(clocknames[0]);
> -	     clock++) {
> +	for (int clock = 0; clock < ARRAY_SIZE(clocknames); clock++)
>   		test_one_clock_gettime64(clock, clocknames[clock]);
> -	}
>   
>   	/* Also test some invalid clock ids */
>   	test_one_clock_gettime64(-1, "invalid");
> 

Looks good to me. I will apply this once merge window closes.

thanks,
-- Shuah