Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3349487pxp; Tue, 22 Mar 2022 18:10:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkQXMOQGRZVxskuOhx3gyiq2AN8hz3Tg+RL2DxmY9Ll1H4irFTzupqozaxVXKlKoR2zoEF X-Received: by 2002:aa7:8ec2:0:b0:4f7:4a9:7fcd with SMTP id b2-20020aa78ec2000000b004f704a97fcdmr32420338pfr.26.1647997854357; Tue, 22 Mar 2022 18:10:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647997854; cv=none; d=google.com; s=arc-20160816; b=aWaBP6IYXtHsHKsFGMRwhwy44KbO4xdHqEielU2WdETzK2/lTJeM1SJ+GHNy3gkK+u mrZRdynoPgnvaut2GQj1pzFf1nZ1UXHne0akVVw1F/rTK6aE8j1UDEh9I2bPmwLgCtxz h+Rxh23EhTNf9OYewxq88Op7iMX9mcHsCY9Ty1IIzpqutQBmmOk/Vy01iN21MKGS9yv2 OlZ1R18RFgUGsoNhdD4uy51SHv9Ab7PY/Lm2X8RGT90gb2DbKyo2e5PttL0LHYxBZBn9 x1I62HIbys3m/vdbo2C15ak5GIq6jwxstOZGNySGDZuI5in7pIrnOO9sPEYLJ1S+taFQ JiSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RbhQPydmDT5HJoVo/2TcWUBUNks7IHa1xt/QhPs46t8=; b=i0ivup/WQ1E/cobEtw7DK30uHxNLn3yen4aiwbevpc6Y8cQtvG0iMQ60UxITRg5giI oEHiOAoYWJgHktxZhEUFx0iNLZtdC3dU04Ov5tX5lhmnwpd6bUsAgwf2/yztCKOOfKLl TjaCOnFp4bgNLIBio+rsZzqZ46L7uQHfB0h2gG7xD36Iywa6feAAoLJCOHFKQrntCFH0 MunEDA1jZ6uhT4aXRitX3HFXDI+S+2Un3/WTDzDFp1SeE7NnlbsCzB1PMHkuF2VrzpE2 5LfffhWb2cz6hzOXuAfrtrDO0mgMOAhT64yLrffkgo8uGbs+c9x6GwAT6+m2dSmq7+7B KMDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Zl87S7Yp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 129-20020a630487000000b0038216f93fadsi15993366pge.326.2022.03.22.18.10.38; Tue, 22 Mar 2022 18:10:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Zl87S7Yp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237716AbiCVOTC (ORCPT + 99 others); Tue, 22 Mar 2022 10:19:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236801AbiCVOP2 (ORCPT ); Tue, 22 Mar 2022 10:15:28 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4885D4E3B4; Tue, 22 Mar 2022 07:13:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D7458B81D08; Tue, 22 Mar 2022 14:13:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE7B1C36AE5; Tue, 22 Mar 2022 14:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647958427; bh=btEIS1j3Ond3ZP9qah9C8gQBs8ZC16Vm5hgbF/uIHr4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zl87S7YpSbRhvw8gFFY9v18aPQG+x35lGIDEB0ogtbQVwCY9oc1mmNmpno23HCzQr pM7oWt5hJu/5ovcKYJIKGL10kWJ6zdtqQOFEYh19NdkzNLGJeJCNhEwdtcoOCeipU/ xS4RWhOBAtU8LXagat7LgQ6h6N/0RcewTvqAjNsGHh413Ob6qWOEkNROQ+0awx1EXW LH/k69NaBimqXAVj2Ejp+DjBnPsFuJ+8zyz2EXMsmH+ZOyb3iNIoYyXLqc8gPKq6Wo wGRuKKLmcVGgYcbyUVvk/SZBs+lpoKda4TTyYm0XkfKuSmD4DG9kBq0iz8N/nG6SQj qC9zM1AvmjgLQ== From: Jeff Layton To: idryomov@gmail.com, xiubli@redhat.com Cc: ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-kernel@vger.kernel.org, lhenriques@suse.de Subject: [RFC PATCH v11 30/51] ceph: don't allow changing layout on encrypted files/directories Date: Tue, 22 Mar 2022 10:12:55 -0400 Message-Id: <20220322141316.41325-31-jlayton@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220322141316.41325-1-jlayton@kernel.org> References: <20220322141316.41325-1-jlayton@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Luis Henriques Encryption is currently only supported on files/directories with layouts where stripe_count=1. Forbid changing layouts when encryption is involved. Signed-off-by: Luis Henriques Signed-off-by: Jeff Layton --- fs/ceph/ioctl.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/ceph/ioctl.c b/fs/ceph/ioctl.c index b9f0f4e460ab..9675ef3a6c47 100644 --- a/fs/ceph/ioctl.c +++ b/fs/ceph/ioctl.c @@ -294,6 +294,10 @@ static long ceph_set_encryption_policy(struct file *file, unsigned long arg) struct inode *inode = file_inode(file); struct ceph_inode_info *ci = ceph_inode(inode); + /* encrypted directories can't have striped layout */ + if (ci->i_layout.stripe_count > 1) + return -EINVAL; + ret = vet_mds_for_fscrypt(file); if (ret) return ret; -- 2.35.1