Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d318c7ce-3b9d-0a61-e501-52fd43b77f8f@intel.com>
Date:   Tue, 22 Mar 2022 13:10:07 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [Intel-gfx] [PATCH v11 0/5] Add driver for GSC controller
Content-Language: en-US
To:     Alexander Usyskin <alexander.usyskin@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
CC:     <linux-kernel@vger.kernel.org>,
        Tomas Winkler <tomas.winkler@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>,
        <intel-gfx@lists.freedesktop.org>
References: <20220315131157.3972238-1-alexander.usyskin@intel.com>
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
In-Reply-To: <20220315131157.3972238-1-alexander.usyskin@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUxLQitoTVI2WFo0YlhVT1J0WFBpaS9PZU9Ud2UySWJTaG9nRjhnRUl6ck1S?=
 =?utf-8?B?dGJCY0prN3FXdXYvRHRQcHJqSHdNaU00Yzd1RHExKzIyT1FCYnZmeGEyQkd2?=
 =?utf-8?B?b3ZVYVQwbjlMcTJUeWRCb3JpM2hMOGpKTnV2aXlsTFliY2VYbVB1Vjlia0hK?=
 =?utf-8?B?VGQvdHhTRUx0SnJzbHZ3MzI5ZmZaTEk4cVlXTlZDQVFYYU0zbXR4blJtSDg5?=
 =?utf-8?B?NVVYL2JIK0RERHhROWFpdDczeVNqQW82VHVaQkZkRmZhSkpyMHpwc2MzbVBa?=
 =?utf-8?B?S2VrOCsyTVcvTWs4VzBGN3Jya0thK0hQazNWL1FMeThFRzR6RTJFdXhnRjNJ?=
 =?utf-8?B?U1J0eHFNZDVuS3BDd3UwMmEzS3RSdGxxSGtYcTdDWjZPM1MrSFdSalY3bk1X?=
 =?utf-8?B?RlZ2OGlEU09nay8yc3JoVDNIR05mS0xvbmFjZzBvM1B4N1pmVmR2VkV6WS9T?=
 =?utf-8?B?b2VQVzArbnBqQlluM2R6ZkRXaUFMM2xZazVReUJpQ2tucWhiV0dsQXlrSzNC?=
 =?utf-8?B?bDNXdDlENEhKWnowbHI5K2VJZDJseWdHNnB6STVRV29pZW9mWVdGU2paenpt?=
 =?utf-8?B?ekNTUFRiYmowc2UvdXB3bkU1bVVnN2tSR3F1Vk53MVVRTE1lSDd3aWI0SFcv?=
 =?utf-8?B?bkZQQkFteGZ4emJsVVlXRnN3d1o1cWRFRXd0VUpSK0loM2orTytoZ1dzdW9l?=
 =?utf-8?B?RU51QmxUWmJ6ZE1GUmNQRFk2eklueGRrVEpsQ0NLZ1dsRHYvSXN6eVRUWWhO?=
 =?utf-8?B?NXdhcndUTGxaK1RYa2o0Ty8rZnpZSmZVc3RUMmxOZVBlUWhqUXhEdm9KdWhL?=
 =?utf-8?B?WDAwSGpqY2p5cWc3WjRSOThWT0hXdjJRVzRHYWFyb0ZmR1M3cjVwd1JXSWJu?=
 =?utf-8?B?Yy9hblcyMFd2NStIcW5LZmYxTEZCQjduSkNRWDJyYS8rUm9kMllLUUp6SXpw?=
 =?utf-8?B?ZnJKZUVwTnp0L1p3cWlEVEVRSitzR2FLRWYxRlhwb1ZiMVJVNitST0d3TFQ3?=
 =?utf-8?B?VXVNektuWGJHbmFHa1djampTdlErWExtNi9lMXpER1MxL21GM3RHRUdXbWZF?=
 =?utf-8?B?bDNFd1lZTG9GVXByMUlMNFVBZUcvZlBPc21rSW9FYXFRb0xXcXhYdURwMGJK?=
 =?utf-8?B?SVdhSVZWMU1CUDNVeHVxbisva09BcHZBc2FGVkprNlpzSytqd1RNcGN1Tkxl?=
 =?utf-8?B?Vjk4RFhiaksxVjFHNFVFQmdaYXdsMXBTTUR1QlZNS3NpeWtEejVFVEYzODVx?=
 =?utf-8?B?RG5TZm1tVElsTXd3alU1ZGtqWWlsSUR4djUrK2daOENoRHdXZVhzNXpmVHJX?=
 =?utf-8?B?akhKOGw2R3g4UU9lUWZucW41UlRXQTB1eUFVa3cxcUNKOVdUTW1uNjFGR29B?=
 =?utf-8?B?NFRTVm8yY3M0c0psc0p4Y3BCTzRObTdrQlJ0ZEhpaVJZU05lWXJvYVBSTzJ3?=
 =?utf-8?B?d1hSc1MxaTRzSytTWldEN3N3VU5aUy9QZ0hpOXVQK0s4TTJjWGx3SlRGL2VM?=
 =?utf-8?B?SUxSL3NQMW13Tno1OUtXa2RoVVZXN3NsaEkzU051Y1dhMXNwb2pLcnVBcFJ2?=
 =?utf-8?B?WjdwcjdCaGJoSm5NcFpUeUowUWI2R255ZXhGYVRYT1JkdWJpZ3Qwc2Q0V1Nh?=
 =?utf-8?B?cy8yeGJlbEtYMWdSeUF2Q1RVNGY2SGRueXY2bnlIdmZRZCtPL2I3QTJzZ0l2?=
 =?utf-8?B?WjkyWjNvOUtvM1JwclBqZHlGNmJYb01CWlRKWVdYM0V5T0lVQjQvUFFuRndO?=
 =?utf-8?B?NE4wVkwzNFh3WElKY0pVNFdFeDhKUmJDNitmTC9YQjBaUWZxVDN0OFZXQmVt?=
 =?utf-8?B?TmJIZGVqdlN2cE9wcWtWWFNSckpQVm9UQ1pROHhpL2NkdE9tbDZKRVhwSDJ6?=
 =?utf-8?B?M2QrTjU5ZWNPcy9VUm96VEI2T3ZkMGxCVGtNM0RlVXVadFY3MHNhVzNKMGU0?=
 =?utf-8?B?VmlkcUdwQVpnNVRwRm5iTEl2N0ZmakRHUERjaElKSG5mQnVVVnZkOHg0UWcz?=
 =?utf-8?Q?PJwc9k3DMbAErGgHRLewQVkUZkvBR0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d92aa58f-513c-4446-df5b-08da0c3ff7d4
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5488.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2022 20:10:11.1116
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LVKd+1pGYhltoLMYQEOwwDzSvyiEeMhhGMWNyMRjanky7FI8LZP8Je3Po0yEMZLb6MJAEJHe2yupSxDpOH8bsiH/Un8SBDaCgiaZkl39W5s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1594
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Can you re-send this series with an added patch to force 
CONFIG_INTEL_MEI_GSC to be selected for CI? we don't need to review or 
merge that additional patch, but I want to make sure we get CI results 
with the config turned on before we merge this series. I'm also going to 
ping the CI team to see if we can turn it on by default for CI builds.

Daniele

On 3/15/2022 6:11 AM, Alexander Usyskin wrote:
> GSC is a graphics system controller, it provides
> a chassis controller for graphics discrete cards.
>
> There are two MEI interfaces in GSC: HECI1 and HECI2.
>
> This series includes instantiation of the auxiliary devices for HECI2
> and mei-gsc auxiliary device driver that binds to the auxiliary device.
>
> The prinicpal user of this interface is the
> Intel Graphics System Controller Firmware Update Library (IGSC FU)
> (https://github.com/intel/igsc)
>
> In v2 the platform device was replaced by the auxiliary device.
> v3 is the rebase over drm-tip to make public CI running.
> In v4 the not needed debug prints and empty line were removed,
>        'select' were replaced by 'depends on' in MEI Kconfig,
>        the new include file now listed in the MAINTATINERS file.
> V5, rebase and add Greg KH Reviewed-by
> V6, rebase and drop redundant assignments found by the kernel test
> robot.
> V7, add Greg KH Reviewed-by to the individual patches
> V8, address Tvrtko comments for i915
> V9, rebase and address more Tvrtko comments, use drm error printing
> V10, rebase
> V11, address Rodrigo comments about code style,
>       set missed mask in the interrupt config,
>       add explicit devm_irq_free to error and remove flows
>
> Tomas, please look at the devm_irq_free part.
>
> Alexander Usyskin (2):
>    mei: gsc: setup char driver alive in spite of firmware handshake
>      failure
>    mei: gsc: retrieve the firmware version
>
> Tomas Winkler (3):
>    drm/i915/gsc: add gsc as a mei auxiliary device
>    mei: add support for graphics system controller (gsc) devices
>    mei: gsc: add runtime pm handlers
>
>   MAINTAINERS                              |   1 +
>   drivers/gpu/drm/i915/Kconfig             |   1 +
>   drivers/gpu/drm/i915/Makefile            |   3 +
>   drivers/gpu/drm/i915/gt/intel_gsc.c      | 204 ++++++++++++++++++
>   drivers/gpu/drm/i915/gt/intel_gsc.h      |  37 ++++
>   drivers/gpu/drm/i915/gt/intel_gt.c       |   3 +
>   drivers/gpu/drm/i915/gt/intel_gt.h       |   5 +
>   drivers/gpu/drm/i915/gt/intel_gt_irq.c   |  13 ++
>   drivers/gpu/drm/i915/gt/intel_gt_regs.h  |   1 +
>   drivers/gpu/drm/i915/gt/intel_gt_types.h |   2 +
>   drivers/gpu/drm/i915/i915_drv.h          |   8 +
>   drivers/gpu/drm/i915/i915_pci.c          |   3 +-
>   drivers/gpu/drm/i915/i915_reg.h          |   2 +
>   drivers/gpu/drm/i915/intel_device_info.h |   2 +
>   drivers/misc/mei/Kconfig                 |  14 ++
>   drivers/misc/mei/Makefile                |   3 +
>   drivers/misc/mei/bus-fixup.c             |  25 +++
>   drivers/misc/mei/gsc-me.c                | 259 +++++++++++++++++++++++
>   drivers/misc/mei/hw-me.c                 |  29 ++-
>   drivers/misc/mei/hw-me.h                 |   2 +
>   include/linux/mei_aux.h                  |  19 ++
>   21 files changed, 633 insertions(+), 3 deletions(-)
>   create mode 100644 drivers/gpu/drm/i915/gt/intel_gsc.c
>   create mode 100644 drivers/gpu/drm/i915/gt/intel_gsc.h
>   create mode 100644 drivers/misc/mei/gsc-me.c
>   create mode 100644 include/linux/mei_aux.h
>