Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH linux-next] selftests/proc: fix array_size.cocci warning
To:     Guo Zhengkui <guozhengkui@vivo.com>, Shuah Khan <shuah@kernel.org>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kselftest@vger.kernel.org
Cc:     zhengkui_guo@outlook.com, Shuah Khan <skhan@linuxfoundation.org>
References: <20220321102546.12569-1-guozhengkui@vivo.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <eb5dd04b-a20c-1874-e71e-60c962ad8dcb@linuxfoundation.org>
Date:   Tue, 22 Mar 2022 17:02:11 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20220321102546.12569-1-guozhengkui@vivo.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/21/22 4:25 AM, Guo Zhengkui wrote:
> Fix the following coccicheck warning:
> 
> tools/testing/selftests/proc/proc-pid-vm.c:371:26-27:
> WARNING: Use ARRAY_SIZE
> tools/testing/selftests/proc/proc-pid-vm.c:420:26-27:
> WARNING: Use ARRAY_SIZE
> 
> It has been tested with gcc (Debian 8.3.0-6) 8.3.0 on x86_64.
> 
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
> ---
>   tools/testing/selftests/proc/proc-pid-vm.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/proc/proc-pid-vm.c b/tools/testing/selftests/proc/proc-pid-vm.c
> index 18a3bde8bc96..28604c9f805c 100644
> --- a/tools/testing/selftests/proc/proc-pid-vm.c
> +++ b/tools/testing/selftests/proc/proc-pid-vm.c
> @@ -46,6 +46,8 @@
>   #include <sys/time.h>
>   #include <sys/resource.h>
>   
> +#include "../kselftest.h"
> +
>   static inline long sys_execveat(int dirfd, const char *pathname, char **argv, char **envp, int flags)
>   {
>   	return syscall(SYS_execveat, dirfd, pathname, argv, envp, flags);
> @@ -368,7 +370,7 @@ int main(void)
>   		};
>   		int i;
>   
> -		for (i = 0; i < sizeof(S)/sizeof(S[0]); i++) {
> +		for (i = 0; i < ARRAY_SIZE(S); i++) {
>   			assert(memmem(buf, rv, S[i], strlen(S[i])));
>   		}
>   
> @@ -417,7 +419,7 @@ int main(void)
>   		};
>   		int i;
>   
> -		for (i = 0; i < sizeof(S)/sizeof(S[0]); i++) {
> +		for (i = 0; i < ARRAY_SIZE(S); i++) {
>   			assert(memmem(buf, rv, S[i], strlen(S[i])));
>   		}
>   	}
> 

Looks good to me. I will apply this once merge window closes.


thanks,
-- Shuah